[INFO] crate pwds 0.2.0 is already in cache [INFO] extracting crate pwds 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pwds/0.2.0 [INFO] extracting crate pwds 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pwds/0.2.0 [INFO] validating manifest of pwds-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pwds-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pwds-0.2.0 [INFO] finished frobbing pwds-0.2.0 [INFO] frobbed toml for pwds-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pwds/0.2.0/Cargo.toml [INFO] started frobbing pwds-0.2.0 [INFO] finished frobbing pwds-0.2.0 [INFO] frobbed toml for pwds-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pwds/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pwds-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pwds/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e59a7fa3cc9a9a0c2d301bfc4304df235fc6ba8b7f3f968c67aa11881776f92 [INFO] running `"docker" "start" "-a" "5e59a7fa3cc9a9a0c2d301bfc4304df235fc6ba8b7f3f968c67aa11881776f92"` [INFO] [stderr] Checking pwds v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let home_path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / let mut end = chars.next().unwrap(); [INFO] [stderr] 56 | | if start.1 == '.' { // show an extra char for hidden directories [INFO] [stderr] 57 | | length += 1; [INFO] [stderr] 58 | | end = chars.next().unwrap(); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let end = if start.1 == '.' { ..; chars.next().unwrap() } else { chars.next().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let home_path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / let mut end = chars.next().unwrap(); [INFO] [stderr] 56 | | if start.1 == '.' { // show an extra char for hidden directories [INFO] [stderr] 57 | | length += 1; [INFO] [stderr] 58 | | end = chars.next().unwrap(); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let end = if start.1 == '.' { ..; chars.next().unwrap() } else { chars.next().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "5e59a7fa3cc9a9a0c2d301bfc4304df235fc6ba8b7f3f968c67aa11881776f92"` [INFO] running `"docker" "rm" "-f" "5e59a7fa3cc9a9a0c2d301bfc4304df235fc6ba8b7f3f968c67aa11881776f92"` [INFO] [stdout] 5e59a7fa3cc9a9a0c2d301bfc4304df235fc6ba8b7f3f968c67aa11881776f92