[INFO] crate pvss 0.1.0 is already in cache [INFO] extracting crate pvss 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pvss/0.1.0 [INFO] extracting crate pvss 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pvss/0.1.0 [INFO] validating manifest of pvss-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pvss-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pvss-0.1.0 [INFO] finished frobbing pvss-0.1.0 [INFO] frobbed toml for pvss-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pvss/0.1.0/Cargo.toml [INFO] started frobbing pvss-0.1.0 [INFO] finished frobbing pvss-0.1.0 [INFO] frobbed toml for pvss-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pvss/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pvss-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pvss/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b54d4a91c7582f24ae4454f2f01b337f8a46c5cab4359e88faa0fd00916ae2c4 [INFO] running `"docker" "start" "-a" "b54d4a91c7582f24ae4454f2f01b337f8a46c5cab4359e88faa0fd00916ae2c4"` [INFO] [stderr] Checking pvss v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dleq.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | return Proof { c: c, z: r }; [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdleq.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdleq.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^^^ help: replace it with: `zs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | commitments: commitments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commitments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dleq.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | return Proof { c: c, z: r }; [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdleq.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdleq.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^^^ help: replace it with: `zs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | commitments: commitments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commitments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrape.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return (PublicKey { point: p }, PrivateKey { scalar: s }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(PublicKey { point: p }, PrivateKey { scalar: s })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return openssl::ec::EcGroup::from_curve_name(CURVE).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `openssl::ec::EcGroup::from_curve_name(CURVE).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return order; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Self::from_u32(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::from_u32(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return Scalar { bn: BigNum::from_slice(&self.bn.to_vec()).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: BigNum::from_slice(&self.bn.to_vec()).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return self.bn.to_vec() == other.bn.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bn.to_vec() == other.bn.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | return Point { point: get_point_at_infinity() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: get_point_at_infinity() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return Point { point: curve_generator() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: curve_generator() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | return Point { point: p }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return Point { point: p }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | return self.point.to_bytes(&grp, POINT_CONVERSION_COMPRESSED, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.point.to_bytes(&grp, POINT_CONVERSION_COMPRESSED, &mut ctx).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Point { point: EcPoint::from_bytes(&grp, &bytes, &mut ctx).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: EcPoint::from_bytes(&grp, &bytes, &mut ctx).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | return b1 == b2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b1 == b2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return Polynomial { elements: vec }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Polynomial { elements: vec }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.elements.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return self.elements[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements[0].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dleq.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return Proof { c: c, z: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Proof { c: c, z: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dleq.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.c == Scalar::hash_points(vec![dleq.h1, dleq.h2, a1, a2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.c == Scalar::hash_points(vec![dleq.h1, dleq.h2, a1, a2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdleq.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Proof { c: c, zs: zs }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdleq.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.c == c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.c == c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return Escrow { [INFO] [stderr] 58 | | extra_generator: gen, [INFO] [stderr] 59 | | polynomial: poly, [INFO] [stderr] 60 | | secret: g_s, [INFO] [stderr] 61 | | proof: proof, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | Escrow { [INFO] [stderr] 58 | extra_generator: gen, [INFO] [stderr] 59 | polynomial: poly, [INFO] [stderr] 60 | secret: g_s, [INFO] [stderr] 61 | proof: proof, [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return commitments; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commitments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / return EncryptedShare { [INFO] [stderr] 90 | | id: share_id, [INFO] [stderr] 91 | | encrypted_val: yi, [INFO] [stderr] 92 | | proof: proof, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | EncryptedShare { [INFO] [stderr] 90 | id: share_id, [INFO] [stderr] 91 | encrypted_val: yi, [INFO] [stderr] 92 | proof: proof, [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | / return DecryptedShare { [INFO] [stderr] 163 | | id: share.id, [INFO] [stderr] 164 | | decrypted_val: si, [INFO] [stderr] 165 | | proof: proof, [INFO] [stderr] 166 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 162 | DecryptedShare { [INFO] [stderr] 163 | id: share.id, [INFO] [stderr] 164 | decrypted_val: si, [INFO] [stderr] 165 | proof: proof, [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / return Escrow { [INFO] [stderr] 76 | | threshold: t, [INFO] [stderr] 77 | | extra_generator: gen, [INFO] [stderr] 78 | | polynomial: poly, [INFO] [stderr] 79 | | secret: g_s, [INFO] [stderr] 80 | | proof: proof, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | Escrow { [INFO] [stderr] 76 | threshold: t, [INFO] [stderr] 77 | extra_generator: gen, [INFO] [stderr] 78 | polynomial: poly, [INFO] [stderr] 79 | secret: g_s, [INFO] [stderr] 80 | proof: proof, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return PublicShares { [INFO] [stderr] 120 | | threshold: escrow.threshold, [INFO] [stderr] 121 | | extra_generator: escrow.extra_generator.clone(), [INFO] [stderr] 122 | | secret_proof: escrow.proof.clone(), [INFO] [stderr] ... | [INFO] [stderr] 125 | | proofs: pdleq, [INFO] [stderr] 126 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | PublicShares { [INFO] [stderr] 120 | threshold: escrow.threshold, [INFO] [stderr] 121 | extra_generator: escrow.extra_generator.clone(), [INFO] [stderr] 122 | secret_proof: escrow.proof.clone(), [INFO] [stderr] 123 | encrypted_shares: shares, [INFO] [stderr] 124 | commitments: commitments, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.commitments.len() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.commitments.len() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return v == Point::infinity(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v == Point::infinity()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / return DecryptedShare { [INFO] [stderr] 206 | | id: share.id, [INFO] [stderr] 207 | | decrypted_val: si, [INFO] [stderr] 208 | | proof: proof, [INFO] [stderr] 209 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 205 | DecryptedShare { [INFO] [stderr] 206 | id: share.id, [INFO] [stderr] 207 | decrypted_val: si, [INFO] [stderr] 208 | proof: proof, [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return public_shares.secret_proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `public_shares.secret_proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return (PublicKey { point: p }, PrivateKey { scalar: s }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(PublicKey { point: p }, PrivateKey { scalar: s })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return openssl::ec::EcGroup::from_curve_name(CURVE).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `openssl::ec::EcGroup::from_curve_name(CURVE).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return order; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Self::from_u32(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::from_u32(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return Scalar { bn: BigNum::from_slice(&self.bn.to_vec()).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: BigNum::from_slice(&self.bn.to_vec()).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return Scalar { bn: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Scalar { bn: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return self.bn.to_vec() == other.bn.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bn.to_vec() == other.bn.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | return Point { point: get_point_at_infinity() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: get_point_at_infinity() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return Point { point: curve_generator() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: curve_generator() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | return Point { point: p }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return Point { point: p }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | return self.point.to_bytes(&grp, POINT_CONVERSION_COMPRESSED, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.point.to_bytes(&grp, POINT_CONVERSION_COMPRESSED, &mut ctx).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Point { point: EcPoint::from_bytes(&grp, &bytes, &mut ctx).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: EcPoint::from_bytes(&grp, &bytes, &mut ctx).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return Point { point: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point { point: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crypto.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | return b1 == b2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b1 == b2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return Polynomial { elements: vec }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Polynomial { elements: vec }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.elements.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return self.elements[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements[0].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dleq.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return Proof { c: c, z: r }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Proof { c: c, z: r }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dleq.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.c == Scalar::hash_points(vec![dleq.h1, dleq.h2, a1, a2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.c == Scalar::hash_points(vec![dleq.h1, dleq.h2, a1, a2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdleq.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Proof { c: c, zs: zs }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Proof { c: c, zs: zs }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pdleq.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.c == c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.c == c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return Escrow { [INFO] [stderr] 58 | | extra_generator: gen, [INFO] [stderr] 59 | | polynomial: poly, [INFO] [stderr] 60 | | secret: g_s, [INFO] [stderr] 61 | | proof: proof, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | Escrow { [INFO] [stderr] 58 | extra_generator: gen, [INFO] [stderr] 59 | polynomial: poly, [INFO] [stderr] 60 | secret: g_s, [INFO] [stderr] 61 | proof: proof, [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return commitments; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commitments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / return EncryptedShare { [INFO] [stderr] 90 | | id: share_id, [INFO] [stderr] 91 | | encrypted_val: yi, [INFO] [stderr] 92 | | proof: proof, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | EncryptedShare { [INFO] [stderr] 90 | id: share_id, [INFO] [stderr] 91 | encrypted_val: yi, [INFO] [stderr] 92 | proof: proof, [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | / return DecryptedShare { [INFO] [stderr] 163 | | id: share.id, [INFO] [stderr] 164 | | decrypted_val: si, [INFO] [stderr] 165 | | proof: proof, [INFO] [stderr] 166 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 162 | DecryptedShare { [INFO] [stderr] 163 | id: share.id, [INFO] [stderr] 164 | decrypted_val: si, [INFO] [stderr] 165 | proof: proof, [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/simple.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / return Escrow { [INFO] [stderr] 76 | | threshold: t, [INFO] [stderr] 77 | | extra_generator: gen, [INFO] [stderr] 78 | | polynomial: poly, [INFO] [stderr] 79 | | secret: g_s, [INFO] [stderr] 80 | | proof: proof, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | Escrow { [INFO] [stderr] 76 | threshold: t, [INFO] [stderr] 77 | extra_generator: gen, [INFO] [stderr] 78 | polynomial: poly, [INFO] [stderr] 79 | secret: g_s, [INFO] [stderr] 80 | proof: proof, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return PublicShares { [INFO] [stderr] 120 | | threshold: escrow.threshold, [INFO] [stderr] 121 | | extra_generator: escrow.extra_generator.clone(), [INFO] [stderr] 122 | | secret_proof: escrow.proof.clone(), [INFO] [stderr] ... | [INFO] [stderr] 125 | | proofs: pdleq, [INFO] [stderr] 126 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | PublicShares { [INFO] [stderr] 120 | threshold: escrow.threshold, [INFO] [stderr] 121 | extra_generator: escrow.extra_generator.clone(), [INFO] [stderr] 122 | secret_proof: escrow.proof.clone(), [INFO] [stderr] 123 | encrypted_shares: shares, [INFO] [stderr] 124 | commitments: commitments, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.commitments.len() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.commitments.len() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return v == Point::infinity(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v == Point::infinity()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | return self.proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / return DecryptedShare { [INFO] [stderr] 206 | | id: share.id, [INFO] [stderr] 207 | | decrypted_val: si, [INFO] [stderr] 208 | | proof: proof, [INFO] [stderr] 209 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 205 | DecryptedShare { [INFO] [stderr] 206 | id: share.id, [INFO] [stderr] 207 | decrypted_val: si, [INFO] [stderr] 208 | proof: proof, [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scrape.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return public_shares.secret_proof.verify(dleq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `public_shares.secret_proof.verify(dleq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | p.mul_generator(&grp, &order, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | p.mul_generator(&grp, &pow, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | p.mul_generator(&grp, &s.bn, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:217:41 [INFO] [stderr] | [INFO] [stderr] 217 | r.mul(&grp, &self.point, &s.bn, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `invert` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:226:24 [INFO] [stderr] | [INFO] [stderr] 226 | p.invert(&grp, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dleqs` [INFO] [stderr] --> src/pdleq.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..self.zs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for (i, ) in dleqs.iter().enumerate().take(self.zs.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `commitments` [INFO] [stderr] --> src/simple.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for j in 0..(commitments.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (j, ) in commitments.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scrape.rs:84:45 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn create_shares(escrow: &Escrow, pubs: &Vec) -> PublicShares { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pubs` [INFO] [stderr] --> src/scrape.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for (i, ) in pubs.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let ref public = pubs[i]; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let public = &pubs[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `publics` [INFO] [stderr] --> src/scrape.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..publics.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in publics.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let ref public = publics[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let public = &publics[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | let ref vi = self.commitments[i].point; [INFO] [stderr] | ----^^^^^^----------------------------- help: try: `let vi = &self.commitments[i].point;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | let ref esi = self.encrypted_shares[i].encrypted_val; [INFO] [stderr] | ----^^^^^^^------------------------------------------ help: try: `let esi = &self.encrypted_shares[i].encrypted_val;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | let ref commitment = self.commitments[idx]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------- help: try: `let commitment = &self.commitments[idx];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | p.mul_generator(&grp, &order, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | p.mul_generator(&grp, &pow, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul_generator` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | p.mul_generator(&grp, &s.bn, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `mul` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:217:41 [INFO] [stderr] | [INFO] [stderr] 217 | r.mul(&grp, &self.point, &s.bn, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `invert` doesn't need a mutable reference [INFO] [stderr] --> src/crypto.rs:226:24 [INFO] [stderr] | [INFO] [stderr] 226 | p.invert(&grp, &mut ctx).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dleqs` [INFO] [stderr] --> src/pdleq.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..self.zs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for (i, ) in dleqs.iter().enumerate().take(self.zs.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `commitments` [INFO] [stderr] --> src/simple.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for j in 0..(commitments.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (j, ) in commitments.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scrape.rs:84:45 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn create_shares(escrow: &Escrow, pubs: &Vec) -> PublicShares { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pubs` [INFO] [stderr] --> src/scrape.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for (i, ) in pubs.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let ref public = pubs[i]; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let public = &pubs[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `publics` [INFO] [stderr] --> src/scrape.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..publics.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in publics.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let ref public = publics[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let public = &publics[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | let ref vi = self.commitments[i].point; [INFO] [stderr] | ----^^^^^^----------------------------- help: try: `let vi = &self.commitments[i].point;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | let ref esi = self.encrypted_shares[i].encrypted_val; [INFO] [stderr] | ----^^^^^^^------------------------------------------ help: try: `let esi = &self.encrypted_shares[i].encrypted_val;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scrape.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | let ref commitment = self.commitments[idx]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------- help: try: `let commitment = &self.commitments[idx];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `"docker" "inspect" "b54d4a91c7582f24ae4454f2f01b337f8a46c5cab4359e88faa0fd00916ae2c4"` [INFO] running `"docker" "rm" "-f" "b54d4a91c7582f24ae4454f2f01b337f8a46c5cab4359e88faa0fd00916ae2c4"` [INFO] [stdout] b54d4a91c7582f24ae4454f2f01b337f8a46c5cab4359e88faa0fd00916ae2c4