[INFO] crate pusoy_dos 0.1.1 is already in cache [INFO] extracting crate pusoy_dos 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pusoy_dos/0.1.1 [INFO] extracting crate pusoy_dos 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pusoy_dos/0.1.1 [INFO] validating manifest of pusoy_dos-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pusoy_dos-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pusoy_dos-0.1.1 [INFO] finished frobbing pusoy_dos-0.1.1 [INFO] frobbed toml for pusoy_dos-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pusoy_dos/0.1.1/Cargo.toml [INFO] started frobbing pusoy_dos-0.1.1 [INFO] finished frobbing pusoy_dos-0.1.1 [INFO] frobbed toml for pusoy_dos-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pusoy_dos/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pusoy_dos-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pusoy_dos/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecb63c606c4460dafb1e6d8907b9a83bd2cc20e073d5604d60882befbf861263 [INFO] running `"docker" "start" "-a" "ecb63c606c4460dafb1e6d8907b9a83bd2cc20e073d5604d60882befbf861263"` [INFO] [stderr] Checking pusoy_dos v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:54 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reversed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | hand: hand [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player_move.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | cards: cards [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | current_player: current_player, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | last_move: last_move, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_move` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | first_round: first_round [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | last_move: last_move, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_move` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | pass_count: pass_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pass_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:154:11 [INFO] [stderr] | [INFO] [stderr] 154 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:155:11 [INFO] [stderr] | [INFO] [stderr] 155 | winners: winners, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `winners` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | reversed: reversed [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reversed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cards/card.rs:67:54 [INFO] [stderr] | [INFO] [stderr] 67 | Card{suit: suit, rank: rank, colour: colour, reversed: reversed} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reversed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | hand: hand [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player_move.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | cards: cards [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | current_player: current_player, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | last_move: last_move, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_move` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | first_round: first_round [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | last_move: last_move, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_move` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/round.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | pass_count: pass_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pass_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:154:11 [INFO] [stderr] | [INFO] [stderr] 154 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:155:11 [INFO] [stderr] | [INFO] [stderr] 155 | winners: winners, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `winners` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | reversed: reversed [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reversed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | round:round, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:449:9 [INFO] [stderr] | [INFO] [stderr] 449 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:513:9 [INFO] [stderr] | [INFO] [stderr] 513 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:545:9 [INFO] [stderr] | [INFO] [stderr] 545 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:576:9 [INFO] [stderr] | [INFO] [stderr] 576 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests/game/game.rs:616:9 [INFO] [stderr] | [INFO] [stderr] 616 | round: round, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `round` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/round.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return !self.first_round; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.first_round` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/round.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/game/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub mod game; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/round.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return !self.first_round; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.first_round` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/round.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/game/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub mod game; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests/game/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod game; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn previous_rank(&self) -> Option{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cards/card.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.reversed { [INFO] [stderr] 73 | | false => previous_rank(&self.rank), [INFO] [stderr] 74 | | true => next_rank(&self.rank) [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.reversed { next_rank(&self.rank) } else { previous_rank(&self.rank) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn next_rank(&self) -> Option{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cards/card.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.reversed { [INFO] [stderr] 81 | | false => next_rank(&self.rank), [INFO] [stderr] 82 | | true => previous_rank(&self.rank) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.reversed { previous_rank(&self.rank) } else { next_rank(&self.rank) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn alternate_colour(&self) -> Colour{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn reverse(&self) -> Card{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | fn previous_rank(rank:&Rank) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:146:19 [INFO] [stderr] | [INFO] [stderr] 146 | fn next_rank(rank:&Rank) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards/types.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | let icon = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 19 | | &Suit::Diamonds => "♦", [INFO] [stderr] 20 | | &Suit::Clubs => "♣", [INFO] [stderr] 21 | | &Suit::Hearts => "♥", [INFO] [stderr] 22 | | &Suit::Spades => "♠" [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | let icon = match *self { [INFO] [stderr] 19 | Suit::Diamonds => "♦", [INFO] [stderr] 20 | Suit::Clubs => "♣", [INFO] [stderr] 21 | Suit::Hearts => "♥", [INFO] [stderr] 22 | Suit::Spades => "♠" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cards::deck::Deck` [INFO] [stderr] --> src/cards/deck.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut cards:Vec = Vec::with_capacity(52); [INFO] [stderr] 15 | | for suit in &[Suit::Spades, Suit::Hearts, Suit::Diamonds, Suit::Clubs] { [INFO] [stderr] 16 | | for rank in &[Rank::Ace, Rank::Two, Rank::Three, Rank::Four, [INFO] [stderr] ... | [INFO] [stderr] 25 | | Deck(cards) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cards/deck.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Card::new(rank.clone(), suit.clone(), false); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*rank` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cards/deck.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Card::new(rank.clone(), suit.clone(), false); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*suit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cards/deck.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | while deck_stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deck_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/player.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn remove(&self, cards:&Vec) -> Player { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PlayerCard]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/player.rs:75:39 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn remove_jokers(&self, cards:&Vec)-> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PlayerCard]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/player.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match *card { [INFO] [stderr] 81 | | PlayerCard::Wildcard(_) => jokers += 1, [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ help: try this: `if let PlayerCard::Wildcard(_) = *card { jokers += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/player_move.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | .map(|&c|{ c.clone() }).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/round.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/round.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | *self.players.get(index).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.players[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/game.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match p_move { [INFO] [stderr] 129 | | Some(Move::FiveCardTrick(t)) => match t.trick_type { [INFO] [stderr] 130 | | TrickType::FourOfAKind [INFO] [stderr] 131 | | | TrickType::FiveOfAKind => { [INFO] [stderr] ... | [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(Move::FiveCardTrick(t)) = p_move { match t.trick_type { [INFO] [stderr] 129 | TrickType::FourOfAKind [INFO] [stderr] 130 | | TrickType::FiveOfAKind => { [INFO] [stderr] 131 | // update round to reverse last_move cards [INFO] [stderr] 132 | round = round.reverse_last_move(); [INFO] [stderr] 133 | // update players to reverse cards in hand [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/game.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | let id = match self.round.has_started() { [INFO] [stderr] | __________________^ [INFO] [stderr] 176 | | true => self.round.get_next_player(), [INFO] [stderr] 177 | | false => match Game::get_next(&self.players) { [INFO] [stderr] 178 | | Some(player) => player.get_id(), [INFO] [stderr] 179 | | _ => self.round.get_next_player() [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 175 | let id = if self.round.has_started() { self.round.get_next_player() } else { match Game::get_next(&self.players) { [INFO] [stderr] 176 | Some(player) => player.get_id(), [INFO] [stderr] 177 | _ => self.round.get_next_player() [INFO] [stderr] 178 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | fn get_next(players: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game/game.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | if current_player.get_hand().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_player.get_hand().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game.rs:237:51 [INFO] [stderr] | [INFO] [stderr] 237 | fn get_players_for_next_round(&self, players: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game/game.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | .filter(|player|{ player.get_hand().len() > 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!player.get_hand().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn previous_rank(&self) -> Option{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cards/card.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.reversed { [INFO] [stderr] 73 | | false => previous_rank(&self.rank), [INFO] [stderr] 74 | | true => next_rank(&self.rank) [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.reversed { next_rank(&self.rank) } else { previous_rank(&self.rank) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn next_rank(&self) -> Option{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cards/card.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.reversed { [INFO] [stderr] 81 | | false => next_rank(&self.rank), [INFO] [stderr] 82 | | true => previous_rank(&self.rank) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.reversed { previous_rank(&self.rank) } else { next_rank(&self.rank) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn alternate_colour(&self) -> Colour{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn reverse(&self) -> Card{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | fn previous_rank(rank:&Rank) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cards/card.rs:146:19 [INFO] [stderr] | [INFO] [stderr] 146 | fn next_rank(rank:&Rank) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards/types.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | let icon = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 19 | | &Suit::Diamonds => "♦", [INFO] [stderr] 20 | | &Suit::Clubs => "♣", [INFO] [stderr] 21 | | &Suit::Hearts => "♥", [INFO] [stderr] 22 | | &Suit::Spades => "♠" [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | let icon = match *self { [INFO] [stderr] 19 | Suit::Diamonds => "♦", [INFO] [stderr] 20 | Suit::Clubs => "♣", [INFO] [stderr] 21 | Suit::Hearts => "♥", [INFO] [stderr] 22 | Suit::Spades => "♠" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cards::deck::Deck` [INFO] [stderr] --> src/cards/deck.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut cards:Vec = Vec::with_capacity(52); [INFO] [stderr] 15 | | for suit in &[Suit::Spades, Suit::Hearts, Suit::Diamonds, Suit::Clubs] { [INFO] [stderr] 16 | | for rank in &[Rank::Ace, Rank::Two, Rank::Three, Rank::Four, [INFO] [stderr] ... | [INFO] [stderr] 25 | | Deck(cards) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cards/deck.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Card::new(rank.clone(), suit.clone(), false); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*rank` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cards/deck.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Card::new(rank.clone(), suit.clone(), false); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*suit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cards/deck.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | while deck_stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deck_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/player.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn remove(&self, cards:&Vec) -> Player { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PlayerCard]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/player.rs:75:39 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn remove_jokers(&self, cards:&Vec)-> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PlayerCard]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/player.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match *card { [INFO] [stderr] 81 | | PlayerCard::Wildcard(_) => jokers += 1, [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ help: try this: `if let PlayerCard::Wildcard(_) = *card { jokers += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/player_move.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | .map(|&c|{ c.clone() }).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/round.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/round.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | *self.players.get(index).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.players[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/game.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match p_move { [INFO] [stderr] 129 | | Some(Move::FiveCardTrick(t)) => match t.trick_type { [INFO] [stderr] 130 | | TrickType::FourOfAKind [INFO] [stderr] 131 | | | TrickType::FiveOfAKind => { [INFO] [stderr] ... | [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(Move::FiveCardTrick(t)) = p_move { match t.trick_type { [INFO] [stderr] 129 | TrickType::FourOfAKind [INFO] [stderr] 130 | | TrickType::FiveOfAKind => { [INFO] [stderr] 131 | // update round to reverse last_move cards [INFO] [stderr] 132 | round = round.reverse_last_move(); [INFO] [stderr] 133 | // update players to reverse cards in hand [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/game.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | let id = match self.round.has_started() { [INFO] [stderr] | __________________^ [INFO] [stderr] 176 | | true => self.round.get_next_player(), [INFO] [stderr] 177 | | false => match Game::get_next(&self.players) { [INFO] [stderr] 178 | | Some(player) => player.get_id(), [INFO] [stderr] 179 | | _ => self.round.get_next_player() [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 175 | let id = if self.round.has_started() { self.round.get_next_player() } else { match Game::get_next(&self.players) { [INFO] [stderr] 176 | Some(player) => player.get_id(), [INFO] [stderr] 177 | _ => self.round.get_next_player() [INFO] [stderr] 178 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | fn get_next(players: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game/game.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | if current_player.get_hand().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_player.get_hand().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game.rs:237:51 [INFO] [stderr] | [INFO] [stderr] 237 | fn get_players_for_next_round(&self, players: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game/game.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | .filter(|player|{ player.get_hand().len() > 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!player.get_hand().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/tests/cards/card.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn rank_order_is_correct() { [INFO] [stderr] 14 | | let three = Card::new(Rank::Three, Suit::Spades, false); [INFO] [stderr] 15 | | let four = Card::new(Rank::Four, Suit::Spades, false); [INFO] [stderr] 16 | | let five = Card::new(Rank::Five, Suit::Spades, false); [INFO] [stderr] ... | [INFO] [stderr] 53 | | assert_eq!(two.next_rank(), None); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/tests/cards/card.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn rank_order_is_correct_reversed() { [INFO] [stderr] 58 | | let three = Card::new(Rank::Three, Suit::Spades, true); [INFO] [stderr] 59 | | let four = Card::new(Rank::Four, Suit::Spades, true); [INFO] [stderr] 60 | | let five = Card::new(Rank::Five, Suit::Spades, true); [INFO] [stderr] ... | [INFO] [stderr] 97 | | assert_eq!(two.previous_rank(), None); [INFO] [stderr] 98 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.41s [INFO] running `"docker" "inspect" "ecb63c606c4460dafb1e6d8907b9a83bd2cc20e073d5604d60882befbf861263"` [INFO] running `"docker" "rm" "-f" "ecb63c606c4460dafb1e6d8907b9a83bd2cc20e073d5604d60882befbf861263"` [INFO] [stdout] ecb63c606c4460dafb1e6d8907b9a83bd2cc20e073d5604d60882befbf861263