[INFO] crate pushover 0.3.0 is already in cache [INFO] extracting crate pushover 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/pushover/0.3.0 [INFO] extracting crate pushover 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pushover/0.3.0 [INFO] validating manifest of pushover-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pushover-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pushover-0.3.0 [INFO] finished frobbing pushover-0.3.0 [INFO] frobbed toml for pushover-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/pushover/0.3.0/Cargo.toml [INFO] started frobbing pushover-0.3.0 [INFO] finished frobbing pushover-0.3.0 [INFO] frobbed toml for pushover-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pushover/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pushover-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pushover/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af7bd6dc95cc69fd87904ef8f328819850865e2d6f827f3569c0f402934bc5f6 [INFO] running `"docker" "start" "-a" "af7bd6dc95cc69fd87904ef8f328819850865e2d6f827f3569c0f402934bc5f6"` [INFO] [stderr] Compiling http-muncher v0.3.2 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking mockito v0.8.2 [INFO] [stderr] Checking pushover v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | Self { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/groups/toggle_user.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | toggle: toggle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `toggle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/license/assign.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | user_type: user_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/open_client/delete_messages.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | Self { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/groups/toggle_user.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | toggle: toggle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `toggle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/license/assign.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | user_type: user_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requests/open_client/delete_messages.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const API_URL: &'static str = "https://api.pushover.net"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | pub const API_VERSION: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/requests/verification/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod verification; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/requests/glance/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod glance; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const API_URL: &'static str = "https://api.pushover.net"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | pub const API_VERSION: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/requests/verification/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod verification; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/requests/glance/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod glance; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::AsyncAPIBuilder` [INFO] [stderr] --> src/client.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let mut inner = async::ClientBuilder::new(); [INFO] [stderr] 29 | | inner.timeout(Duration::from_secs(DEFAULT_TIMEOUT)); [INFO] [stderr] 30 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for client::AsyncAPIBuilder { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::SyncAPIBuilder` [INFO] [stderr] --> src/client.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> Self { [INFO] [stderr] 108 | | let mut inner = reqwest::ClientBuilder::new(); [INFO] [stderr] 109 | | inner.timeout(Duration::from_secs(DEFAULT_TIMEOUT)); [INFO] [stderr] 110 | | [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | impl Default for client::SyncAPIBuilder { [INFO] [stderr] 107 | fn default() -> Self { [INFO] [stderr] 108 | Self::new() [INFO] [stderr] 109 | } [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/priority.rs:58:76 [INFO] [stderr] | [INFO] [stderr] 58 | .ok_or_else(|| de::Error::invalid_value(de::Unexpected::Signed(raw as i64), &"-2, -1, 0, 1, 2")) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(raw)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::AsyncAPIBuilder` [INFO] [stderr] --> src/client.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let mut inner = async::ClientBuilder::new(); [INFO] [stderr] 29 | | inner.timeout(Duration::from_secs(DEFAULT_TIMEOUT)); [INFO] [stderr] 30 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for client::AsyncAPIBuilder { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::SyncAPIBuilder` [INFO] [stderr] --> src/client.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> Self { [INFO] [stderr] 108 | | let mut inner = reqwest::ClientBuilder::new(); [INFO] [stderr] 109 | | inner.timeout(Duration::from_secs(DEFAULT_TIMEOUT)); [INFO] [stderr] 110 | | [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | impl Default for client::SyncAPIBuilder { [INFO] [stderr] 107 | fn default() -> Self { [INFO] [stderr] 108 | Self::new() [INFO] [stderr] 109 | } [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/priority.rs:58:76 [INFO] [stderr] | [INFO] [stderr] 58 | .ok_or_else(|| de::Error::invalid_value(de::Unexpected::Signed(raw as i64), &"-2, -1, 0, 1, 2")) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(raw)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/requests.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | api [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/requests.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | let api = SyncAPIBuilder::new() [INFO] [stderr] | _______________^ [INFO] [stderr] 12 | | .base_url(mockito::SERVER_URL) [INFO] [stderr] 13 | | .build() [INFO] [stderr] 14 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/requests.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | api [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/requests.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | let api = AsyncAPIBuilder::new() [INFO] [stderr] | _______________^ [INFO] [stderr] 21 | | .base_url(mockito::SERVER_URL) [INFO] [stderr] 22 | | .build(handle) [INFO] [stderr] 23 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.79s [INFO] running `"docker" "inspect" "af7bd6dc95cc69fd87904ef8f328819850865e2d6f827f3569c0f402934bc5f6"` [INFO] running `"docker" "rm" "-f" "af7bd6dc95cc69fd87904ef8f328819850865e2d6f827f3569c0f402934bc5f6"` [INFO] [stdout] af7bd6dc95cc69fd87904ef8f328819850865e2d6f827f3569c0f402934bc5f6