[INFO] crate purp 0.1.0 is already in cache [INFO] extracting crate purp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/purp/0.1.0 [INFO] extracting crate purp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/purp/0.1.0 [INFO] validating manifest of purp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of purp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing purp-0.1.0 [INFO] finished frobbing purp-0.1.0 [INFO] frobbed toml for purp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/purp/0.1.0/Cargo.toml [INFO] started frobbing purp-0.1.0 [INFO] finished frobbing purp-0.1.0 [INFO] frobbed toml for purp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/purp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting purp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/purp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a69d7a0f8f49a437a062ad4e656e392335577e4ac554755bdb7f9480d5a04d08 [INFO] running `"docker" "start" "-a" "a69d7a0f8f49a437a062ad4e656e392335577e4ac554755bdb7f9480d5a04d08"` [INFO] [stderr] Checking purp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return paths; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / return Command::new("psc-package") [INFO] [stderr] 95 | | .arg("build") [INFO] [stderr] 96 | | .arg("--") [INFO] [stderr] 97 | | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] ... | [INFO] [stderr] 100 | | .wait() [INFO] [stderr] 101 | | .expect("Error in `psc-package`"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 94 | Command::new("psc-package") [INFO] [stderr] 95 | .arg("build") [INFO] [stderr] 96 | .arg("--") [INFO] [stderr] 97 | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] 98 | .spawn() [INFO] [stderr] 99 | .expect("Error in launching `psc-package`") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LinkedList::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return paths; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / return Command::new("psc-package") [INFO] [stderr] 95 | | .arg("build") [INFO] [stderr] 96 | | .arg("--") [INFO] [stderr] 97 | | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] ... | [INFO] [stderr] 100 | | .wait() [INFO] [stderr] 101 | | .expect("Error in `psc-package`"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 94 | Command::new("psc-package") [INFO] [stderr] 95 | .arg("build") [INFO] [stderr] 96 | .arg("--") [INFO] [stderr] 97 | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] 98 | .spawn() [INFO] [stderr] 99 | .expect("Error in launching `psc-package`") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | .args(paths.unwrap_or_else(|| LinkedList::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LinkedList::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "a69d7a0f8f49a437a062ad4e656e392335577e4ac554755bdb7f9480d5a04d08"` [INFO] running `"docker" "rm" "-f" "a69d7a0f8f49a437a062ad4e656e392335577e4ac554755bdb7f9480d5a04d08"` [INFO] [stdout] a69d7a0f8f49a437a062ad4e656e392335577e4ac554755bdb7f9480d5a04d08