[INFO] crate punch 0.1.2 is already in cache [INFO] extracting crate punch 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/punch/0.1.2 [INFO] extracting crate punch 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/punch/0.1.2 [INFO] validating manifest of punch-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of punch-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing punch-0.1.2 [INFO] finished frobbing punch-0.1.2 [INFO] frobbed toml for punch-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/punch/0.1.2/Cargo.toml [INFO] started frobbing punch-0.1.2 [INFO] finished frobbing punch-0.1.2 [INFO] frobbed toml for punch-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/punch/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting punch-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/punch/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27ffee8d7fd853ca58ee860f69aa55442195390b62402012a66f9d5d0aec3dae [INFO] running `"docker" "start" "-a" "27ffee8d7fd853ca58ee860f69aa55442195390b62402012a66f9d5d0aec3dae"` [INFO] [stderr] Checking punch v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:297:2 [INFO] [stderr] | [INFO] [stderr] 297 | return seek_to_record_offset(config_file, offset_from_end). [INFO] [stderr] | _____^ [INFO] [stderr] 298 | | and_then(|_| populate_record_at_current_offset(config_file, record)) [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 297 | seek_to_record_offset(config_file, offset_from_end). [INFO] [stderr] 298 | and_then(|_| populate_record_at_current_offset(config_file, record)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | conf_file.push(env::home_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:355:19 [INFO] [stderr] | [INFO] [stderr] 355 | conf_dir.push(env::home_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:155:6 [INFO] [stderr] | [INFO] [stderr] 155 | if !read_attempt.is_ok() || record.timestamp < start_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `read_attempt.is_err() || record.timestamp < start_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | if !seek_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `seek_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:297:2 [INFO] [stderr] | [INFO] [stderr] 297 | return seek_to_record_offset(config_file, offset_from_end). [INFO] [stderr] | _____^ [INFO] [stderr] 298 | | and_then(|_| populate_record_at_current_offset(config_file, record)) [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 297 | seek_to_record_offset(config_file, offset_from_end). [INFO] [stderr] 298 | and_then(|_| populate_record_at_current_offset(config_file, record)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | conf_file.push(env::home_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:355:19 [INFO] [stderr] | [INFO] [stderr] 355 | conf_dir.push(env::home_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:155:6 [INFO] [stderr] | [INFO] [stderr] 155 | if !read_attempt.is_ok() || record.timestamp < start_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `read_attempt.is_err() || record.timestamp < start_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | if !seek_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `seek_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.15s [INFO] running `"docker" "inspect" "27ffee8d7fd853ca58ee860f69aa55442195390b62402012a66f9d5d0aec3dae"` [INFO] running `"docker" "rm" "-f" "27ffee8d7fd853ca58ee860f69aa55442195390b62402012a66f9d5d0aec3dae"` [INFO] [stdout] 27ffee8d7fd853ca58ee860f69aa55442195390b62402012a66f9d5d0aec3dae