[INFO] crate pulsar 0.1.1 is already in cache [INFO] extracting crate pulsar 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pulsar/0.1.1 [INFO] extracting crate pulsar 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pulsar/0.1.1 [INFO] validating manifest of pulsar-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pulsar-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pulsar-0.1.1 [INFO] finished frobbing pulsar-0.1.1 [INFO] frobbed toml for pulsar-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pulsar/0.1.1/Cargo.toml [INFO] started frobbing pulsar-0.1.1 [INFO] finished frobbing pulsar-0.1.1 [INFO] frobbed toml for pulsar-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pulsar/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pulsar-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pulsar/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4e10d95ae3a9f6321319b863dd6e5cb2ed7e3415d3e901815d7c8249c0dc338 [INFO] running `"docker" "start" "-a" "e4e10d95ae3a9f6321319b863dd6e5cb2ed7e3415d3e901815d7c8249c0dc338"` [INFO] [stderr] Checking futures-timer v0.1.1 [INFO] [stderr] Compiling petgraph v0.4.13 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling env_logger v0.5.13 [INFO] [stderr] Compiling prost v0.4.0 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Compiling prost-build v0.4.0 [INFO] [stderr] Compiling prost-derive v0.4.0 [INFO] [stderr] Compiling prost-types v0.4.0 [INFO] [stderr] Compiling pulsar v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/connection.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 101 | | if let Some(request_key) = msg.request_key() { [INFO] [stderr] 102 | | if let Some(resolver) = self.pending_requests.remove(&request_key) { [INFO] [stderr] 103 | | // We don't care if the receiver has dropped their future [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if let Some(request_key) = msg.request_key() { [INFO] [stderr] 101 | if let Some(resolver) = self.pending_requests.remove(&request_key) { [INFO] [stderr] 102 | // We don't care if the receiver has dropped their future [INFO] [stderr] 103 | let _ = resolver.send(msg); [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | self.received_messages.insert(request_key, msg); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:1047:55 [INFO] [stderr] | [INFO] [stderr] 1047 | assert_eq!(payload.metadata.publish_time, 1533850624062); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_533_850_624_062` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/connection.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 101 | | if let Some(request_key) = msg.request_key() { [INFO] [stderr] 102 | | if let Some(resolver) = self.pending_requests.remove(&request_key) { [INFO] [stderr] 103 | | // We don't care if the receiver has dropped their future [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if let Some(request_key) = msg.request_key() { [INFO] [stderr] 101 | if let Some(resolver) = self.pending_requests.remove(&request_key) { [INFO] [stderr] 102 | // We don't care if the receiver has dropped their future [INFO] [stderr] 103 | let _ = resolver.send(msg); [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | self.received_messages.insert(request_key, msg); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .or(command.send_error.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] | ______________^ [INFO] [stderr] 51 | | producer_id: r.producer_id, [INFO] [stderr] 52 | | sequence_id: r.sequence_id, [INFO] [stderr] 53 | | })) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | .or_else(|| command.send_error.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] 51 | producer_id: r.producer_id, [INFO] [stderr] 52 | sequence_id: r.sequence_id, [INFO] [stderr] 53 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .or(command.send_receipt.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] | ______________^ [INFO] [stderr] 47 | | producer_id: r.producer_id, [INFO] [stderr] 48 | | sequence_id: r.sequence_id [INFO] [stderr] 49 | | })) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | .or_else(|| command.send_receipt.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] 47 | producer_id: r.producer_id, [INFO] [stderr] 48 | sequence_id: r.sequence_id [INFO] [stderr] 49 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | .map(|request_id| RequestKey::RequestId(request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestKey::RequestId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .or(command.get_schema_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_schema_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .or(command.get_schema.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_schema.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .or(command.get_topics_of_namespace_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_topics_of_namespace_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | .or(command.get_topics_of_namespace.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_topics_of_namespace.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | .or(command.get_last_message_id_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_last_message_id_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .or(command.get_last_message_id.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_last_message_id.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .or(command.consumer_stats_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.consumer_stats_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | .or(command.consumer_stats.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.consumer_stats.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .or(command.error.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.error.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .or(command.producer_success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer_success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .or(command.success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .or(command.close_consumer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.close_consumer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .or(command.close_producer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.close_producer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | .or(command.seek.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.seek.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .or(command.unsubscribe.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.unsubscribe.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .or(command.producer_success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer_success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .or(command.producer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .or(command.lookup_topic_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.lookup_topic_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | .or(command.lookup_topic.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.lookup_topic.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | .or(command.partition_metadata_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.partition_metadata_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | .or(command.partition_metadata.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.partition_metadata.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .or(command.send_error.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] | ______________^ [INFO] [stderr] 51 | | producer_id: r.producer_id, [INFO] [stderr] 52 | | sequence_id: r.sequence_id, [INFO] [stderr] 53 | | })) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | .or_else(|| command.send_error.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] 51 | producer_id: r.producer_id, [INFO] [stderr] 52 | sequence_id: r.sequence_id, [INFO] [stderr] 53 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .or(command.send_receipt.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] | ______________^ [INFO] [stderr] 47 | | producer_id: r.producer_id, [INFO] [stderr] 48 | | sequence_id: r.sequence_id [INFO] [stderr] 49 | | })) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | .or_else(|| command.send_receipt.as_ref().map(|r| RequestKey::ProducerSend { [INFO] [stderr] 47 | producer_id: r.producer_id, [INFO] [stderr] 48 | sequence_id: r.sequence_id [INFO] [stderr] 49 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | .map(|request_id| RequestKey::RequestId(request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestKey::RequestId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .or(command.get_schema_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_schema_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .or(command.get_schema.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_schema.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .or(command.get_topics_of_namespace_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_topics_of_namespace_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | .or(command.get_topics_of_namespace.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_topics_of_namespace.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | .or(command.get_last_message_id_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_last_message_id_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .or(command.get_last_message_id.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.get_last_message_id.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .or(command.consumer_stats_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.consumer_stats_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | .or(command.consumer_stats.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.consumer_stats.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .or(command.error.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.error.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .or(command.producer_success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer_success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .or(command.success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .or(command.close_consumer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.close_consumer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .or(command.close_producer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.close_producer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | .or(command.seek.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.seek.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .or(command.unsubscribe.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.unsubscribe.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .or(command.producer_success.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer_success.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .or(command.producer.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.producer.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .or(command.lookup_topic_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.lookup_topic_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | .or(command.lookup_topic.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.lookup_topic.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | .or(command.partition_metadata_response.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.partition_metadata_response.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/message.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | .or(command.partition_metadata.as_ref().map(|m| m.request_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| command.partition_metadata.as_ref().map(|m| m.request_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/consumer.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new( [INFO] [stderr] 23 | | addr: String, [INFO] [stderr] 24 | | topic: String, [INFO] [stderr] 25 | | subscription: String, [INFO] [stderr] ... | [INFO] [stderr] 54 | | }) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/consumer.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | deserialize: Option Result + Send>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `error::SharedError` [INFO] [stderr] --> src/error.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> SharedError { [INFO] [stderr] 49 | | SharedError { [INFO] [stderr] 50 | | error_set: Arc::new(AtomicBool::new(false)), [INFO] [stderr] 51 | | error: Arc::new(Mutex::new(None)), [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::SerialId` [INFO] [stderr] --> src/connection.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | / pub fn new() -> SerialId { [INFO] [stderr] 196 | | SerialId(Arc::new(AtomicUsize::new(0))) [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/connection.rs:419:52 [INFO] [stderr] | [INFO] [stderr] 419 | } else if message.command.send_error.is_some() { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 420 | | Err(Error::PulsarError(format!("{:?}", message.command.error.unwrap()))) [INFO] [stderr] 421 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/connection.rs:417:40 [INFO] [stderr] | [INFO] [stderr] 417 | if message.command.error.is_some() { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 418 | | Err(Error::PulsarError(format!("{:?}", message.command.error.unwrap()))) [INFO] [stderr] 419 | | } else if message.command.send_error.is_some() { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/consumer.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new( [INFO] [stderr] 23 | | addr: String, [INFO] [stderr] 24 | | topic: String, [INFO] [stderr] 25 | | subscription: String, [INFO] [stderr] ... | [INFO] [stderr] 54 | | }) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: Could not compile `pulsar`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/consumer.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | deserialize: Option Result + Send>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `error::SharedError` [INFO] [stderr] --> src/error.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> SharedError { [INFO] [stderr] 49 | | SharedError { [INFO] [stderr] 50 | | error_set: Arc::new(AtomicBool::new(false)), [INFO] [stderr] 51 | | error: Arc::new(Mutex::new(None)), [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::SerialId` [INFO] [stderr] --> src/connection.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | / pub fn new() -> SerialId { [INFO] [stderr] 196 | | SerialId(Arc::new(AtomicUsize::new(0))) [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/connection.rs:419:52 [INFO] [stderr] | [INFO] [stderr] 419 | } else if message.command.send_error.is_some() { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 420 | | Err(Error::PulsarError(format!("{:?}", message.command.error.unwrap()))) [INFO] [stderr] 421 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/connection.rs:417:40 [INFO] [stderr] | [INFO] [stderr] 417 | if message.command.error.is_some() { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 418 | | Err(Error::PulsarError(format!("{:?}", message.command.error.unwrap()))) [INFO] [stderr] 419 | | } else if message.command.send_error.is_some() { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pulsar`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e4e10d95ae3a9f6321319b863dd6e5cb2ed7e3415d3e901815d7c8249c0dc338"` [INFO] running `"docker" "rm" "-f" "e4e10d95ae3a9f6321319b863dd6e5cb2ed7e3415d3e901815d7c8249c0dc338"` [INFO] [stdout] e4e10d95ae3a9f6321319b863dd6e5cb2ed7e3415d3e901815d7c8249c0dc338