[INFO] crate pulldown-cmark-to-cmark 1.1.0 is already in cache [INFO] extracting crate pulldown-cmark-to-cmark 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/pulldown-cmark-to-cmark/1.1.0 [INFO] extracting crate pulldown-cmark-to-cmark 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pulldown-cmark-to-cmark/1.1.0 [INFO] validating manifest of pulldown-cmark-to-cmark-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pulldown-cmark-to-cmark-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pulldown-cmark-to-cmark-1.1.0 [INFO] finished frobbing pulldown-cmark-to-cmark-1.1.0 [INFO] frobbed toml for pulldown-cmark-to-cmark-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pulldown-cmark-to-cmark/1.1.0/Cargo.toml [INFO] started frobbing pulldown-cmark-to-cmark-1.1.0 [INFO] finished frobbing pulldown-cmark-to-cmark-1.1.0 [INFO] frobbed toml for pulldown-cmark-to-cmark-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pulldown-cmark-to-cmark/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pulldown-cmark-to-cmark-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pulldown-cmark-to-cmark/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b841abe87d218e6af1616af714e141c3584b87d7dda0677fc5524db81381ef6 [INFO] running `"docker" "start" "-a" "3b841abe87d218e6af1616af714e141c3584b87d7dda0677fc5524db81381ef6"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Checking pulldown-cmark-to-cmark v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/fmt.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | / if state.list_stack.len() > 1 { [INFO] [stderr] 171 | | if state.newlines_before_start < options.newlines_after_rest { [INFO] [stderr] 172 | | state.newlines_before_start = options.newlines_after_rest; [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | if state.list_stack.len() > 1 && state.newlines_before_start < options.newlines_after_rest { [INFO] [stderr] 171 | state.newlines_before_start = options.newlines_after_rest; [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/fmt.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn cmark_with_options<'a, I, E, F>( [INFO] [stderr] 99 | | events: I, [INFO] [stderr] 100 | | mut formatter: F, [INFO] [stderr] 101 | | state: Option>, [INFO] [stderr] ... | [INFO] [stderr] 352 | | Ok(state) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | / match inner { [INFO] [stderr] 185 | | &Some(n) => write!(formatter, "{}. ", n), [INFO] [stderr] 186 | | &None => formatter.write_str("* "), [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 184 | match *inner { [INFO] [stderr] 185 | Some(n) => write!(formatter, "{}. ", n), [INFO] [stderr] 186 | None => formatter.write_str("* "), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | / if let &TableHead = t { [INFO] [stderr] 276 | | formatter [INFO] [stderr] 277 | | .write_char('\n') [INFO] [stderr] 278 | | .and(padding(&mut formatter, &state.padding))?; [INFO] [stderr] ... | [INFO] [stderr] 300 | | formatter.write_char('|')?; [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 275 | if let TableHead = *t { [INFO] [stderr] | ^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fmt.rs:313:24 [INFO] [stderr] | [INFO] [stderr] 313 | if state.list_stack.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.list_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling indoc-impl v0.2.8 [INFO] [stderr] Checking indoc v0.2.8 [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/stupicat.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | let path = env::args_os() [INFO] [stderr] | ________________^ [INFO] [stderr] 15 | | .skip(1) [INFO] [stderr] 16 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/fmt.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | / if state.list_stack.len() > 1 { [INFO] [stderr] 171 | | if state.newlines_before_start < options.newlines_after_rest { [INFO] [stderr] 172 | | state.newlines_before_start = options.newlines_after_rest; [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | if state.list_stack.len() > 1 && state.newlines_before_start < options.newlines_after_rest { [INFO] [stderr] 171 | state.newlines_before_start = options.newlines_after_rest; [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/fmt.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn cmark_with_options<'a, I, E, F>( [INFO] [stderr] 99 | | events: I, [INFO] [stderr] 100 | | mut formatter: F, [INFO] [stderr] 101 | | state: Option>, [INFO] [stderr] ... | [INFO] [stderr] 352 | | Ok(state) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | / match inner { [INFO] [stderr] 185 | | &Some(n) => write!(formatter, "{}. ", n), [INFO] [stderr] 186 | | &None => formatter.write_str("* "), [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 184 | match *inner { [INFO] [stderr] 185 | Some(n) => write!(formatter, "{}. ", n), [INFO] [stderr] 186 | None => formatter.write_str("* "), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | / if let &TableHead = t { [INFO] [stderr] 276 | | formatter [INFO] [stderr] 277 | | .write_char('\n') [INFO] [stderr] 278 | | .and(padding(&mut formatter, &state.padding))?; [INFO] [stderr] ... | [INFO] [stderr] 300 | | formatter.write_char('|')?; [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 275 | if let TableHead = *t { [INFO] [stderr] | ^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fmt.rs:313:24 [INFO] [stderr] | [INFO] [stderr] 313 | if state.list_stack.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.list_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.50s [INFO] running `"docker" "inspect" "3b841abe87d218e6af1616af714e141c3584b87d7dda0677fc5524db81381ef6"` [INFO] running `"docker" "rm" "-f" "3b841abe87d218e6af1616af714e141c3584b87d7dda0677fc5524db81381ef6"` [INFO] [stdout] 3b841abe87d218e6af1616af714e141c3584b87d7dda0677fc5524db81381ef6