[INFO] crate pug 0.1.7 is already in cache [INFO] extracting crate pug 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/pug/0.1.7 [INFO] extracting crate pug 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pug/0.1.7 [INFO] validating manifest of pug-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pug-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pug-0.1.7 [INFO] finished frobbing pug-0.1.7 [INFO] frobbed toml for pug-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/pug/0.1.7/Cargo.toml [INFO] started frobbing pug-0.1.7 [INFO] finished frobbing pug-0.1.7 [INFO] frobbed toml for pug-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pug/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pug-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pug/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9324cf52ff2cc17afda9e53a252a951edefe125311224e1b46ee160e7d17c17 [INFO] running `"docker" "start" "-a" "e9324cf52ff2cc17afda9e53a252a951edefe125311224e1b46ee160e7d17c17"` [INFO] [stderr] Checking pug v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 52 | | continue; [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | if class.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!class.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 110 | | continue; [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 116 | | continue; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 52 | | continue; [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | if class.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!class.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 110 | | continue; [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(_) = comment { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 116 | | continue; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________________- help: try this: `if comment.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.43s [INFO] running `"docker" "inspect" "e9324cf52ff2cc17afda9e53a252a951edefe125311224e1b46ee160e7d17c17"` [INFO] running `"docker" "rm" "-f" "e9324cf52ff2cc17afda9e53a252a951edefe125311224e1b46ee160e7d17c17"` [INFO] [stdout] e9324cf52ff2cc17afda9e53a252a951edefe125311224e1b46ee160e7d17c17