[INFO] crate pub-sub 2.0.0 is already in cache [INFO] extracting crate pub-sub 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/pub-sub/2.0.0 [INFO] extracting crate pub-sub 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pub-sub/2.0.0 [INFO] validating manifest of pub-sub-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pub-sub-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pub-sub-2.0.0 [INFO] finished frobbing pub-sub-2.0.0 [INFO] frobbed toml for pub-sub-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/pub-sub/2.0.0/Cargo.toml [INFO] started frobbing pub-sub-2.0.0 [INFO] finished frobbing pub-sub-2.0.0 [INFO] frobbed toml for pub-sub-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pub-sub/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pub-sub-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pub-sub/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 089f826bf2cc89a0b1e06773587d275cb88dab9ea3a982b0e87db8284d08d799 [INFO] running `"docker" "start" "-a" "089f826bf2cc89a0b1e06773587d275cb88dab9ea3a982b0e87db8284d08d799"` [INFO] [stderr] Checking pub-sub v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PubSub` [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> PubSub { [INFO] [stderr] 102 | | PubSub { senders: Arc::new(Mutex::new(HashMap::new())) } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in 0..pulses.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | for _ in 0..pulses { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PubSub` [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> PubSub { [INFO] [stderr] 102 | | PubSub { senders: Arc::new(Mutex::new(HashMap::new())) } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.72s [INFO] running `"docker" "inspect" "089f826bf2cc89a0b1e06773587d275cb88dab9ea3a982b0e87db8284d08d799"` [INFO] running `"docker" "rm" "-f" "089f826bf2cc89a0b1e06773587d275cb88dab9ea3a982b0e87db8284d08d799"` [INFO] [stdout] 089f826bf2cc89a0b1e06773587d275cb88dab9ea3a982b0e87db8284d08d799