[INFO] crate pty 0.2.2 is already in cache [INFO] extracting crate pty 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/pty/0.2.2 [INFO] extracting crate pty 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pty/0.2.2 [INFO] validating manifest of pty-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pty-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pty-0.2.2 [INFO] finished frobbing pty-0.2.2 [INFO] frobbed toml for pty-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/pty/0.2.2/Cargo.toml [INFO] started frobbing pty-0.2.2 [INFO] finished frobbing pty-0.2.2 [INFO] frobbed toml for pty-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pty/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pty-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pty/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c1de1b63da91787fdadd53b4b6fe7311da682527204573f89e27e287badd977 [INFO] running `"docker" "start" "-a" "2c1de1b63da91787fdadd53b4b6fe7311da682527204573f89e27e287badd977"` [INFO] [stderr] Checking errno v0.1.8 [INFO] [stderr] Checking pty v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | const DEFAULT_PTMX: &'static str = "/dev/ptmx"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Result` [INFO] [stderr] --> src/descriptor/err.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub type Result = ::std::result::Result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn grantpt(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn unlockpt(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ptsname(&self) -> Result<*const libc::c_char> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(cause) = master.grantpt().err().or(master.unlockpt().err()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| master.unlockpt().err())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | .or(slave.dup2(libc::STDOUT_FILENO) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 59 | | .err() [INFO] [stderr] 60 | | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | .or_else(|| slave.dup2(libc::STDOUT_FILENO) [INFO] [stderr] 59 | .err() [INFO] [stderr] 60 | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| slave.dup2(libc::STDERR_FILENO).err())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fork/mod.rs:100:47 [INFO] [stderr] | [INFO] [stderr] 100 | Fork::Parent(_, ref master) => Ok(master.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*master` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/fork/mod.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match *self { [INFO] [stderr] 117 | | Fork::Parent(_, ref master) => Descriptor::drop(master), [INFO] [stderr] 118 | | _ => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: try this: `if let Fork::Parent(_, ref master) = *self { Descriptor::drop(master) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | const DEFAULT_PTMX: &'static str = "/dev/ptmx"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> examples/new.rs:27:87 [INFO] [stderr] | [INFO] [stderr] 27 | println!("child_tty(\"{}\")[{}] != \"{}\" => {}", child_tty, child_tty.len(), "", child_tty != ""); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Result` [INFO] [stderr] --> src/descriptor/err.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub type Result = ::std::result::Result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn grantpt(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn unlockpt(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fork/pty/master/mod.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ptsname(&self) -> Result<*const libc::c_char> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(cause) = master.grantpt().err().or(master.unlockpt().err()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| master.unlockpt().err())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | .or(slave.dup2(libc::STDOUT_FILENO) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 59 | | .err() [INFO] [stderr] 60 | | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | .or_else(|| slave.dup2(libc::STDOUT_FILENO) [INFO] [stderr] 59 | .err() [INFO] [stderr] 60 | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/fork/mod.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | .or(slave.dup2(libc::STDERR_FILENO).err())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| slave.dup2(libc::STDERR_FILENO).err())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fork/mod.rs:100:47 [INFO] [stderr] | [INFO] [stderr] 100 | Fork::Parent(_, ref master) => Ok(master.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*master` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/fork/mod.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match *self { [INFO] [stderr] 117 | | Fork::Parent(_, ref master) => Descriptor::drop(master), [INFO] [stderr] 118 | | _ => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: try this: `if let Fork::Parent(_, ref master) = *self { Descriptor::drop(master) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> examples/new.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 13 | | let mut string = String::new(); [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | master.read_to_string(&mut string).unwrap_or_else(|e| panic!(e)); [INFO] [stderr] ... | [INFO] [stderr] 39 | | let _ = Command::new("tty").status(); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/new.rs:31:62 [INFO] [stderr] | [INFO] [stderr] 31 | let mut parent_tty_dir: Vec<&str> = parent_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/new.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | let mut child_tty_dir: Vec<&str> = child_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 16 | | let mut string = String::new(); [INFO] [stderr] 17 | | [INFO] [stderr] 18 | | master.read_to_string(&mut string).unwrap_or_else(|e| panic!(e)); [INFO] [stderr] ... | [INFO] [stderr] 45 | | Command::new("tty").status().expect("could not execute tty"); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:36:66 [INFO] [stderr] | [INFO] [stderr] 36 | let mut parent_tty_dir: Vec<&str> = parent_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:37:64 [INFO] [stderr] | [INFO] [stderr] 37 | let mut child_tty_dir: Vec<&str> = child_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 16 | | let mut string = String::new(); [INFO] [stderr] 17 | | [INFO] [stderr] 18 | | master.read_to_string(&mut string).unwrap_or_else(|e| panic!(e)); [INFO] [stderr] ... | [INFO] [stderr] 45 | | Command::new("tty").status().expect("could not execute tty"); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:36:66 [INFO] [stderr] | [INFO] [stderr] 36 | let mut parent_tty_dir: Vec<&str> = parent_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/it_fork_with_new_pty.rs:37:64 [INFO] [stderr] | [INFO] [stderr] 37 | let mut child_tty_dir: Vec<&str> = child_tty.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> tests/it_can_read_write.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | master.read(&mut buf).expect("cannot read 1 byte"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> tests/it_can_read_write.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | master.read(&mut buf).expect("cannot read 1 byte"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/it_can_read_write.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 25 | | let _ = master.write("echo readme!\n".to_string().as_bytes()); [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | read_line(&mut master); // this is the "echo readme!" we just sent [INFO] [stderr] ... | [INFO] [stderr] 32 | | let _ = Command::new("bash").status(); [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/it_can_read_write.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 25 | | let _ = master.write("echo readme!\n".to_string().as_bytes()); [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | read_line(&mut master); // this is the "echo readme!" we just sent [INFO] [stderr] ... | [INFO] [stderr] 32 | | let _ = Command::new("bash").status(); [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] error: Could not compile `pty`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pty`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> examples/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 13 | | // Read output via PTY master [INFO] [stderr] 14 | | let mut output = String::new(); [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 22 | | Command::new("tty").status().expect("could not execute tty"); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2c1de1b63da91787fdadd53b4b6fe7311da682527204573f89e27e287badd977"` [INFO] running `"docker" "rm" "-f" "2c1de1b63da91787fdadd53b4b6fe7311da682527204573f89e27e287badd977"` [INFO] [stdout] 2c1de1b63da91787fdadd53b4b6fe7311da682527204573f89e27e287badd977