[INFO] crate ptime 0.1.1 is already in cache [INFO] extracting crate ptime 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/ptime/0.1.1 [INFO] extracting crate ptime 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ptime/0.1.1 [INFO] validating manifest of ptime-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ptime-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ptime-0.1.1 [INFO] finished frobbing ptime-0.1.1 [INFO] frobbed toml for ptime-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ptime/0.1.1/Cargo.toml [INFO] started frobbing ptime-0.1.1 [INFO] finished frobbing ptime-0.1.1 [INFO] frobbed toml for ptime-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ptime/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ptime-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ptime/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d249d232be0707fe842814af604bbc204526264cb66d5064fee4acc7223fcc1 [INFO] running `"docker" "start" "-a" "0d249d232be0707fe842814af604bbc204526264cb66d5064fee4acc7223fcc1"` [INFO] [stderr] Checking ptime v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let mut i = l - 365 * n + 30; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let mut i = l - 365 * n + 30; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | if jdn > 2299160 { [INFO] [stderr] | ^^^^^^^ help: consider: `2_299_160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let n = 4 * l / 146097; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | l = l - (146097 * n + 3) / 4; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | let i = 4000 * (l + 1) / 1461001; [INFO] [stderr] | ^^^^^^^ help: consider: `1_461_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:334:87 [INFO] [stderr] | [INFO] [stderr] 334 | 367 * gy - ((7 * (gy + 5001 + ((gm - 9) / 7))) / 4) + ((275 * gm) / 9) + gd + 1729777 [INFO] [stderr] | ^^^^^^^ help: consider: `1_729_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:338:21 [INFO] [stderr] | [INFO] [stderr] 338 | let cyc = dep / 1029983; [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | let rem = dep % 1029983; [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:340:26 [INFO] [stderr] | [INFO] [stderr] 340 | let ycyc = if rem == 1029982 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_982` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:344:50 [INFO] [stderr] | [INFO] [stderr] 344 | (2134 * a + 2816 * (rem % 366) + 2815) / 1028522 + a + 1 [INFO] [stderr] | ^^^^^^^ help: consider: `1_028_522` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:474:75 [INFO] [stderr] | [INFO] [stderr] 474 | day + md + (epy * 682 - 110) / 2816 + (epy - 1) * 365 + base / 2820 * 1029983 + 1948320 [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:474:85 [INFO] [stderr] | [INFO] [stderr] 474 | day + md + (epy * 682 - 110) / 2816 + (epy - 1) * 365 + base / 2820 * 1029983 + 1948320 [INFO] [stderr] | ^^^^^^^ help: consider: `1_948_320` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:588:121 [INFO] [stderr] | [INFO] [stderr] 588 | !(hour < 0 || hour > 23 || minute < 0 || minute > 59 || second < 0 || second > 59 || nanosecond < 0 || nanosecond > 999999999) [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | l = l - (146097 * n + 3) / 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `l -= (146097 * n + 3) / 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:352:19 [INFO] [stderr] | [INFO] [stderr] 352 | let dy: f64 = (jdn - get_jdn(year, 1, 1) + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(jdn - get_jdn(year, 1, 1) + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | if jdn > 2299160 { [INFO] [stderr] | ^^^^^^^ help: consider: `2_299_160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let n = 4 * l / 146097; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | l = l - (146097 * n + 3) / 4; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | let i = 4000 * (l + 1) / 1461001; [INFO] [stderr] | ^^^^^^^ help: consider: `1_461_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:334:87 [INFO] [stderr] | [INFO] [stderr] 334 | 367 * gy - ((7 * (gy + 5001 + ((gm - 9) / 7))) / 4) + ((275 * gm) / 9) + gd + 1729777 [INFO] [stderr] | ^^^^^^^ help: consider: `1_729_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:338:21 [INFO] [stderr] | [INFO] [stderr] 338 | let cyc = dep / 1029983; [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | let rem = dep % 1029983; [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:340:26 [INFO] [stderr] | [INFO] [stderr] 340 | let ycyc = if rem == 1029982 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_982` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:344:50 [INFO] [stderr] | [INFO] [stderr] 344 | (2134 * a + 2816 * (rem % 366) + 2815) / 1028522 + a + 1 [INFO] [stderr] | ^^^^^^^ help: consider: `1_028_522` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:474:75 [INFO] [stderr] | [INFO] [stderr] 474 | day + md + (epy * 682 - 110) / 2816 + (epy - 1) * 365 + base / 2820 * 1029983 + 1948320 [INFO] [stderr] | ^^^^^^^ help: consider: `1_029_983` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:474:85 [INFO] [stderr] | [INFO] [stderr] 474 | day + md + (epy * 682 - 110) / 2816 + (epy - 1) * 365 + base / 2820 * 1029983 + 1948320 [INFO] [stderr] | ^^^^^^^ help: consider: `1_948_320` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:588:121 [INFO] [stderr] | [INFO] [stderr] 588 | !(hour < 0 || hour > 23 || minute < 0 || minute > 59 || second < 0 || second > 59 || nanosecond < 0 || nanosecond > 999999999) [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | l = l - (146097 * n + 3) / 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `l -= (146097 * n + 3) / 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:352:19 [INFO] [stderr] | [INFO] [stderr] 352 | let dy: f64 = (jdn - get_jdn(year, 1, 1) + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(jdn - get_jdn(year, 1, 1) + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.75s [INFO] running `"docker" "inspect" "0d249d232be0707fe842814af604bbc204526264cb66d5064fee4acc7223fcc1"` [INFO] running `"docker" "rm" "-f" "0d249d232be0707fe842814af604bbc204526264cb66d5064fee4acc7223fcc1"` [INFO] [stdout] 0d249d232be0707fe842814af604bbc204526264cb66d5064fee4acc7223fcc1