[INFO] crate psutil 1.1.1 is already in cache [INFO] extracting crate psutil 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/psutil/1.1.1 [INFO] extracting crate psutil 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psutil/1.1.1 [INFO] validating manifest of psutil-1.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psutil-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psutil-1.1.1 [INFO] finished frobbing psutil-1.1.1 [INFO] frobbed toml for psutil-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/psutil/1.1.1/Cargo.toml [INFO] started frobbing psutil-1.1.1 [INFO] finished frobbing psutil-1.1.1 [INFO] frobbed toml for psutil-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psutil/1.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psutil-1.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/psutil/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6340791c87acd7316623efab77e529d7b383b4f341d2d27822768cbc0b11e853 [INFO] running `"docker" "start" "-a" "6340791c87acd7316623efab77e529d7b383b4f341d2d27822768cbc0b11e853"` [INFO] [stderr] Checking psutil v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/process.rs:504:9 [INFO] [stderr] | [INFO] [stderr] 504 | /// [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/process.rs:504:9 [INFO] [stderr] | [INFO] [stderr] 504 | /// [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/process.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | / pub fn new(pid: PID) -> Result { [INFO] [stderr] 367 | | let path = procfs_path(pid, "stat"); [INFO] [stderr] 368 | | let stat = try!(read_file(&path)); [INFO] [stderr] 369 | | let meta = try!(fs::metadata(procfs_path(pid, ""))); [INFO] [stderr] ... | [INFO] [stderr] 449 | | }) [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:510:56 [INFO] [stderr] | [INFO] [stderr] 510 | let fd_number = try!(path.file_name().ok_or(parse_error("Could not read /proc entry", &path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parse_error("Could not read /proc entry", &path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:561:42 [INFO] [stderr] | [INFO] [stderr] 561 | let name = try!(path.file_name().ok_or(parse_error("Could not read /proc entry", &path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parse_error("Could not read /proc entry", &path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/process.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | / pub fn new(pid: PID) -> Result { [INFO] [stderr] 367 | | let path = procfs_path(pid, "stat"); [INFO] [stderr] 368 | | let stat = try!(read_file(&path)); [INFO] [stderr] 369 | | let meta = try!(fs::metadata(procfs_path(pid, ""))); [INFO] [stderr] ... | [INFO] [stderr] 449 | | }) [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> tests/pidfile.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | write!(&mut File::create(&pidfile).unwrap(), "{}", "beans").unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:510:56 [INFO] [stderr] | [INFO] [stderr] 510 | let fd_number = try!(path.file_name().ok_or(parse_error("Could not read /proc entry", &path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parse_error("Could not read /proc entry", &path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:561:42 [INFO] [stderr] | [INFO] [stderr] 561 | let name = try!(path.file_name().ok_or(parse_error("Could not read /proc entry", &path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parse_error("Could not read /proc entry", &path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/ps.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | p.cmdline().unwrap().unwrap_or(format!("[{}]", p.comm))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("[{}]", p.comm))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.84s [INFO] running `"docker" "inspect" "6340791c87acd7316623efab77e529d7b383b4f341d2d27822768cbc0b11e853"` [INFO] running `"docker" "rm" "-f" "6340791c87acd7316623efab77e529d7b383b4f341d2d27822768cbc0b11e853"` [INFO] [stdout] 6340791c87acd7316623efab77e529d7b383b4f341d2d27822768cbc0b11e853