[INFO] crate psl-codegen 0.4.2 is already in cache [INFO] extracting crate psl-codegen 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/psl-codegen/0.4.2 [INFO] extracting crate psl-codegen 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psl-codegen/0.4.2 [INFO] validating manifest of psl-codegen-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psl-codegen-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psl-codegen-0.4.2 [INFO] finished frobbing psl-codegen-0.4.2 [INFO] frobbed toml for psl-codegen-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/psl-codegen/0.4.2/Cargo.toml [INFO] started frobbing psl-codegen-0.4.2 [INFO] finished frobbing psl-codegen-0.4.2 [INFO] frobbed toml for psl-codegen-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psl-codegen/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psl-codegen-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/psl-codegen/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fa43f28d5fed74be3271df6cf363fb607646ac65289815afa453d4df4050b69 [INFO] running `"docker" "start" "-a" "0fa43f28d5fed74be3271df6cf363fb607646ac65289815afa453d4df4050b69"` [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking psl-lexer v0.2.0 [INFO] [stderr] Checking psl-codegen v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:394:12 [INFO] [stderr] | [INFO] [stderr] 394 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 395 | | if string_match { [INFO] [stderr] 396 | | (quote!(#label), quote!(#len)) [INFO] [stderr] 397 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 394 | } else if string_match { [INFO] [stderr] 395 | (quote!(#label), quote!(#len)) [INFO] [stderr] 396 | } else { [INFO] [stderr] 397 | let pat = array_expr(label); [INFO] [stderr] 398 | (quote!(#pat), quote!(#len)) [INFO] [stderr] 399 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:424:5 [INFO] [stderr] | [INFO] [stderr] 424 | / if list.is_empty() { [INFO] [stderr] 425 | | if depth == 0 && !cfg!(test) { [INFO] [stderr] 426 | | panic!(" [INFO] [stderr] 427 | | Found empty list. This implementation doesn't support empty lists. [INFO] [stderr] ... | [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 424 | if list.is_empty() && depth == 0 && !cfg!(test) { [INFO] [stderr] 425 | panic!(" [INFO] [stderr] 426 | Found empty list. This implementation doesn't support empty lists. [INFO] [stderr] 427 | If you do want one, you can easily implement the trait `psl::Psl` [INFO] [stderr] 428 | by merely putting `None` in the body. [INFO] [stderr] 429 | "); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:533:14 [INFO] [stderr] | [INFO] [stderr] 533 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 534 | | if depth == 0 { [INFO] [stderr] 535 | | if children.is_empty() { [INFO] [stderr] 536 | | if typ.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 585 | | } [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 533 | else if depth == 0 { [INFO] [stderr] 534 | if children.is_empty() { [INFO] [stderr] 535 | if typ.is_empty() { [INFO] [stderr] 536 | funcs.append_all(func.root()); [INFO] [stderr] 537 | body.append_all(quote!{ [INFO] [stderr] 538 | #pat => #fident(info), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:507:18 [INFO] [stderr] | [INFO] [stderr] 507 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 508 | | if children.is_empty() { [INFO] [stderr] 509 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 510 | | funcs.append_all(func.leaf(typ)); [INFO] [stderr] ... | [INFO] [stderr] 528 | | } [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 507 | else if children.is_empty() { [INFO] [stderr] 508 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 509 | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 510 | footer.append_all(quote!{ [INFO] [stderr] 511 | wild => #fident(wild, acc), [INFO] [stderr] 512 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:490:24 [INFO] [stderr] | [INFO] [stderr] 490 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 491 | | if typ.is_empty() { [INFO] [stderr] 492 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 493 | | funcs.append_all(func.nested_root(children)); [INFO] [stderr] ... | [INFO] [stderr] 503 | | } [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 490 | } else if typ.is_empty() { [INFO] [stderr] 491 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 492 | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 493 | footer.append_all(quote!{ [INFO] [stderr] 494 | wild => #fident(info, wild, labels), [INFO] [stderr] 495 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:514:24 [INFO] [stderr] | [INFO] [stderr] 514 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 515 | | if typ.is_empty() { [INFO] [stderr] 516 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 517 | | funcs.append_all(func.inner(children)); [INFO] [stderr] ... | [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 514 | } else if typ.is_empty() { [INFO] [stderr] 515 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 516 | funcs.append_all(func.inner(children)); [INFO] [stderr] 517 | footer.append_all(quote!{ [INFO] [stderr] 518 | wild => #fident(info, wild, labels, acc), [INFO] [stderr] 519 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:564:18 [INFO] [stderr] | [INFO] [stderr] 564 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 565 | | if children.is_empty() { [INFO] [stderr] 566 | | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 567 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 564 | else if children.is_empty() { [INFO] [stderr] 565 | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 566 | body.append_all(quote!{ [INFO] [stderr] 567 | #pat => #fident(acc), [INFO] [stderr] 568 | }); [INFO] [stderr] 569 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:549:22 [INFO] [stderr] | [INFO] [stderr] 549 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 550 | | if typ.is_empty() { [INFO] [stderr] 551 | | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 552 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 560 | | } [INFO] [stderr] 561 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 549 | else if typ.is_empty() { [INFO] [stderr] 550 | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 551 | body.append_all(quote!{ [INFO] [stderr] 552 | #pat => #fident(info, labels), [INFO] [stderr] 553 | }); [INFO] [stderr] 554 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:572:22 [INFO] [stderr] | [INFO] [stderr] 572 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 573 | | if typ.is_empty() { [INFO] [stderr] 574 | | funcs.append_all(func.inner(children)); [INFO] [stderr] 575 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 572 | else if typ.is_empty() { [INFO] [stderr] 573 | funcs.append_all(func.inner(children)); [INFO] [stderr] 574 | body.append_all(quote!{ [INFO] [stderr] 575 | #pat => #fident(info, labels, acc), [INFO] [stderr] 576 | }); [INFO] [stderr] 577 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:394:12 [INFO] [stderr] | [INFO] [stderr] 394 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 395 | | if string_match { [INFO] [stderr] 396 | | (quote!(#label), quote!(#len)) [INFO] [stderr] 397 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 394 | } else if string_match { [INFO] [stderr] 395 | (quote!(#label), quote!(#len)) [INFO] [stderr] 396 | } else { [INFO] [stderr] 397 | let pat = array_expr(label); [INFO] [stderr] 398 | (quote!(#pat), quote!(#len)) [INFO] [stderr] 399 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:424:5 [INFO] [stderr] | [INFO] [stderr] 424 | / if list.is_empty() { [INFO] [stderr] 425 | | if depth == 0 && !cfg!(test) { [INFO] [stderr] 426 | | panic!(" [INFO] [stderr] 427 | | Found empty list. This implementation doesn't support empty lists. [INFO] [stderr] ... | [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 424 | if list.is_empty() && depth == 0 && !cfg!(test) { [INFO] [stderr] 425 | panic!(" [INFO] [stderr] 426 | Found empty list. This implementation doesn't support empty lists. [INFO] [stderr] 427 | If you do want one, you can easily implement the trait `psl::Psl` [INFO] [stderr] 428 | by merely putting `None` in the body. [INFO] [stderr] 429 | "); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:533:14 [INFO] [stderr] | [INFO] [stderr] 533 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 534 | | if depth == 0 { [INFO] [stderr] 535 | | if children.is_empty() { [INFO] [stderr] 536 | | if typ.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 585 | | } [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 533 | else if depth == 0 { [INFO] [stderr] 534 | if children.is_empty() { [INFO] [stderr] 535 | if typ.is_empty() { [INFO] [stderr] 536 | funcs.append_all(func.root()); [INFO] [stderr] 537 | body.append_all(quote!{ [INFO] [stderr] 538 | #pat => #fident(info), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:507:18 [INFO] [stderr] | [INFO] [stderr] 507 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 508 | | if children.is_empty() { [INFO] [stderr] 509 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 510 | | funcs.append_all(func.leaf(typ)); [INFO] [stderr] ... | [INFO] [stderr] 528 | | } [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 507 | else if children.is_empty() { [INFO] [stderr] 508 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 509 | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 510 | footer.append_all(quote!{ [INFO] [stderr] 511 | wild => #fident(wild, acc), [INFO] [stderr] 512 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:490:24 [INFO] [stderr] | [INFO] [stderr] 490 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 491 | | if typ.is_empty() { [INFO] [stderr] 492 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 493 | | funcs.append_all(func.nested_root(children)); [INFO] [stderr] ... | [INFO] [stderr] 503 | | } [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 490 | } else if typ.is_empty() { [INFO] [stderr] 491 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 492 | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 493 | footer.append_all(quote!{ [INFO] [stderr] 494 | wild => #fident(info, wild, labels), [INFO] [stderr] 495 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:514:24 [INFO] [stderr] | [INFO] [stderr] 514 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 515 | | if typ.is_empty() { [INFO] [stderr] 516 | | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 517 | | funcs.append_all(func.inner(children)); [INFO] [stderr] ... | [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 514 | } else if typ.is_empty() { [INFO] [stderr] 515 | func.wild = quote!(wild: &#iter,); [INFO] [stderr] 516 | funcs.append_all(func.inner(children)); [INFO] [stderr] 517 | footer.append_all(quote!{ [INFO] [stderr] 518 | wild => #fident(info, wild, labels, acc), [INFO] [stderr] 519 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:564:18 [INFO] [stderr] | [INFO] [stderr] 564 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 565 | | if children.is_empty() { [INFO] [stderr] 566 | | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 567 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 564 | else if children.is_empty() { [INFO] [stderr] 565 | funcs.append_all(func.leaf(typ)); [INFO] [stderr] 566 | body.append_all(quote!{ [INFO] [stderr] 567 | #pat => #fident(acc), [INFO] [stderr] 568 | }); [INFO] [stderr] 569 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:549:22 [INFO] [stderr] | [INFO] [stderr] 549 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 550 | | if typ.is_empty() { [INFO] [stderr] 551 | | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 552 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 560 | | } [INFO] [stderr] 561 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 549 | else if typ.is_empty() { [INFO] [stderr] 550 | funcs.append_all(func.nested_root(children)); [INFO] [stderr] 551 | body.append_all(quote!{ [INFO] [stderr] 552 | #pat => #fident(info, labels), [INFO] [stderr] 553 | }); [INFO] [stderr] 554 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:572:22 [INFO] [stderr] | [INFO] [stderr] 572 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 573 | | if typ.is_empty() { [INFO] [stderr] 574 | | funcs.append_all(func.inner(children)); [INFO] [stderr] 575 | | body.append_all(quote!{ [INFO] [stderr] ... | [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 572 | else if typ.is_empty() { [INFO] [stderr] 573 | funcs.append_all(func.inner(children)); [INFO] [stderr] 574 | body.append_all(quote!{ [INFO] [stderr] 575 | #pat => #fident(info, labels, acc), [INFO] [stderr] 576 | }); [INFO] [stderr] 577 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | if val == "1" { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `val == "1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | .expect(&format!("expected: a label that can be converted to ascii, found: {}", label)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("expected: a label that can be converted to ascii, found: {}", label))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:417:1 [INFO] [stderr] | [INFO] [stderr] 417 | / fn build( [INFO] [stderr] 418 | | fname: &str, [INFO] [stderr] 419 | | list: Vec<(&String, &SequenceTrie)>, [INFO] [stderr] 420 | | StringMatch(string_match): StringMatch, [INFO] [stderr] ... | [INFO] [stderr] 610 | | } [INFO] [stderr] 611 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | if val == "1" { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `val == "1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | .expect(&format!("expected: a label that can be converted to ascii, found: {}", label)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("expected: a label that can be converted to ascii, found: {}", label))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:417:1 [INFO] [stderr] | [INFO] [stderr] 417 | / fn build( [INFO] [stderr] 418 | | fname: &str, [INFO] [stderr] 419 | | list: Vec<(&String, &SequenceTrie)>, [INFO] [stderr] 420 | | StringMatch(string_match): StringMatch, [INFO] [stderr] ... | [INFO] [stderr] 610 | | } [INFO] [stderr] 611 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.15s [INFO] running `"docker" "inspect" "0fa43f28d5fed74be3271df6cf363fb607646ac65289815afa453d4df4050b69"` [INFO] running `"docker" "rm" "-f" "0fa43f28d5fed74be3271df6cf363fb607646ac65289815afa453d4df4050b69"` [INFO] [stdout] 0fa43f28d5fed74be3271df6cf363fb607646ac65289815afa453d4df4050b69