[INFO] crate psk_std 0.1.0 is already in cache [INFO] extracting crate psk_std 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/psk_std/0.1.0 [INFO] extracting crate psk_std 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psk_std/0.1.0 [INFO] validating manifest of psk_std-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psk_std-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psk_std-0.1.0 [INFO] finished frobbing psk_std-0.1.0 [INFO] frobbed toml for psk_std-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/psk_std/0.1.0/Cargo.toml [INFO] started frobbing psk_std-0.1.0 [INFO] finished frobbing psk_std-0.1.0 [INFO] frobbed toml for psk_std-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/psk_std/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psk_std-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/psk_std/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff8bd5529caa1367d5825661ee6d08c15c151391e8aa8a4af272f60bc807ec37 [INFO] running `"docker" "start" "-a" "ff8bd5529caa1367d5825661ee6d08c15c151391e8aa8a4af272f60bc807ec37"` [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking psk_std v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:15:27 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/complex.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | end_inclusive: end_inclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_inclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 15 | Complex { re: re, im: im } [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | end_inclusive: end_inclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_inclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/step_range.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/extrema.rs:75:69 [INFO] [stderr] | [INFO] [stderr] 75 | self.values.iter().fold(ExtremeValues::default(), |mut acc, &ref value| { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/stdlib.rs:41:50 [INFO] [stderr] | [INFO] [stderr] 41 | let value = env.image_data.get(Dims::new(x as i64, y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/stdlib.rs:41:60 [INFO] [stderr] | [INFO] [stderr] 41 | let value = env.image_data.get(Dims::new(x as i64, y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/extrema.rs:75:69 [INFO] [stderr] | [INFO] [stderr] 75 | self.values.iter().fold(ExtremeValues::default(), |mut acc, &ref value| { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/stdlib.rs:41:50 [INFO] [stderr] | [INFO] [stderr] 41 | let value = env.image_data.get(Dims::new(x as i64, y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/stdlib.rs:41:60 [INFO] [stderr] | [INFO] [stderr] 41 | let value = env.image_data.get(Dims::new(x as i64, y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.40s [INFO] running `"docker" "inspect" "ff8bd5529caa1367d5825661ee6d08c15c151391e8aa8a4af272f60bc807ec37"` [INFO] running `"docker" "rm" "-f" "ff8bd5529caa1367d5825661ee6d08c15c151391e8aa8a4af272f60bc807ec37"` [INFO] [stdout] ff8bd5529caa1367d5825661ee6d08c15c151391e8aa8a4af272f60bc807ec37