[INFO] crate pshbullet_client 0.2.1 is already in cache [INFO] extracting crate pshbullet_client 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/pshbullet_client/0.2.1 [INFO] extracting crate pshbullet_client 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pshbullet_client/0.2.1 [INFO] validating manifest of pshbullet_client-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pshbullet_client-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pshbullet_client-0.2.1 [INFO] finished frobbing pshbullet_client-0.2.1 [INFO] frobbed toml for pshbullet_client-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/pshbullet_client/0.2.1/Cargo.toml [INFO] started frobbing pshbullet_client-0.2.1 [INFO] finished frobbing pshbullet_client-0.2.1 [INFO] frobbed toml for pshbullet_client-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pshbullet_client/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pshbullet_client-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pshbullet_client/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c882b779921760ce33813ab2d8b1098c57f6fce248ff4c89ef6dc4d58460d91 [INFO] running `"docker" "start" "-a" "8c882b779921760ce33813ab2d8b1098c57f6fce248ff4c89ef6dc4d58460d91"` [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking pshbullet_client v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/push.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Compiling derive-error-chain v0.11.2 [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/push.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | condition.modified_after.map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 188 | || params.push(("modified_after", format!("{:e}", t))) [INFO] [stderr] 189 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = condition.modified_after { params.push(("modified_after", format!("{:e}", t))) }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/push.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | condition.cursor.as_ref().map(|s| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 191 | || params.push(("cursor", s.to_string())) [INFO] [stderr] 192 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(s) = condition.cursor.as_ref() { params.push(("cursor", s.to_string())) }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unix_time + (t.timestamp_subsec_nanos() as f64 / 1_000_000_000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Checking dotenv v0.12.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/push.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/push.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.412_047_948_579_031e+09` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/push.rs:224:31 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.412_047_948_579_029e+09` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.412_047_948_579_031e+09` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.412_047_948_579_029e+09` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | ratelimit_reset: Some(1496856653) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_496_856_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/push.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | condition.modified_after.map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 188 | || params.push(("modified_after", format!("{:e}", t))) [INFO] [stderr] 189 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = condition.modified_after { params.push(("modified_after", format!("{:e}", t))) }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/push.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | condition.cursor.as_ref().map(|s| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 191 | || params.push(("cursor", s.to_string())) [INFO] [stderr] 192 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(s) = condition.cursor.as_ref() { params.push(("cursor", s.to_string())) }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/push.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.412_047_948_579_031e9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/push.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/push.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/push.rs:224:31 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.412_047_948_579_029e9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/push.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/push.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/device.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.412_047_948_579_031e9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/device.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/device.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(r.modified, 1.412047948579031e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/device.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.412_047_948_579_029e9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/device.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/device.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(r.created, 1.412047948579029e+09); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unix_time + (t.timestamp_subsec_nanos() as f64 / 1_000_000_000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pshbullet_client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8c882b779921760ce33813ab2d8b1098c57f6fce248ff4c89ef6dc4d58460d91"` [INFO] running `"docker" "rm" "-f" "8c882b779921760ce33813ab2d8b1098c57f6fce248ff4c89ef6dc4d58460d91"` [INFO] [stdout] 8c882b779921760ce33813ab2d8b1098c57f6fce248ff4c89ef6dc4d58460d91