[INFO] crate prototty_wasm 0.20.0 is already in cache [INFO] extracting crate prototty_wasm 0.20.0 into work/ex/clippy-test-run/sources/stable/reg/prototty_wasm/0.20.0 [INFO] extracting crate prototty_wasm 0.20.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_wasm/0.20.0 [INFO] validating manifest of prototty_wasm-0.20.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prototty_wasm-0.20.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prototty_wasm-0.20.0 [INFO] finished frobbing prototty_wasm-0.20.0 [INFO] frobbed toml for prototty_wasm-0.20.0 written to work/ex/clippy-test-run/sources/stable/reg/prototty_wasm/0.20.0/Cargo.toml [INFO] started frobbing prototty_wasm-0.20.0 [INFO] finished frobbing prototty_wasm-0.20.0 [INFO] frobbed toml for prototty_wasm-0.20.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_wasm/0.20.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prototty_wasm-0.20.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prototty_wasm/0.20.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae97744e7dc4ad7096d934b02dceba16d11857f3c3c829f13db1b40ab6ddc34b [INFO] running `"docker" "start" "-a" "ae97744e7dc4ad7096d934b02dceba16d11857f3c3c829f13db1b40ab6ddc34b"` [INFO] [stderr] Checking grid_2d v0.8.0 [INFO] [stderr] Checking prototty v0.20.0 [INFO] [stderr] Checking prototty_grid v0.20.0 [INFO] [stderr] Checking prototty_wasm v0.20.0 (/opt/crater/workdir) [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/terminal.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const BOLD_BIT: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 29 | let mut chars = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 30 | let mut style = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 31 | let mut fg_colour = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 32 | let mut bg_colour = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `context::Context` [INFO] [stderr] --> src/context.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | let terminal = Terminal::new(); [INFO] [stderr] 14 | | let grid = Grid::new(terminal.size()); [INFO] [stderr] 15 | | Self { terminal, grid } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for context::Context { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::WasmStorage` [INFO] [stderr] --> src/storage.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Self { [INFO] [stderr] 14 | | table: BTreeMap::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/input.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const MOD_SHIFT: u8 = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | Coord::new(x as i32, y as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | Coord::new(x as i32, y as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/input.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / fn from_js_event_key_press(event: u64) -> Option { [INFO] [stderr] 76 | | let event_key_code = event as u8; [INFO] [stderr] 77 | | let event_key_modifiers = (event >> 8) as u8; [INFO] [stderr] 78 | | [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/terminal.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const BOLD_BIT: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 29 | let mut chars = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 30 | let mut style = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 31 | let mut fg_colour = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/terminal.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut buf = Vec::with_capacity($size); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; size]` [INFO] [stderr] 19 | buf.resize($size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 32 | let mut bg_colour = create_buf!(size); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `context::Context` [INFO] [stderr] --> src/context.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | let terminal = Terminal::new(); [INFO] [stderr] 14 | | let grid = Grid::new(terminal.size()); [INFO] [stderr] 15 | | Self { terminal, grid } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for context::Context { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::WasmStorage` [INFO] [stderr] --> src/storage.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Self { [INFO] [stderr] 14 | | table: BTreeMap::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/input.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const MOD_SHIFT: u8 = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | Coord::new(x as i32, y as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | Coord::new(x as i32, y as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/input.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / fn from_js_event_key_press(event: u64) -> Option { [INFO] [stderr] 76 | | let event_key_code = event as u8; [INFO] [stderr] 77 | | let event_key_modifiers = (event >> 8) as u8; [INFO] [stderr] 78 | | [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.16s [INFO] running `"docker" "inspect" "ae97744e7dc4ad7096d934b02dceba16d11857f3c3c829f13db1b40ab6ddc34b"` [INFO] running `"docker" "rm" "-f" "ae97744e7dc4ad7096d934b02dceba16d11857f3c3c829f13db1b40ab6ddc34b"` [INFO] [stdout] ae97744e7dc4ad7096d934b02dceba16d11857f3c3c829f13db1b40ab6ddc34b