[INFO] crate prototty_glutin 0.20.1 is already in cache [INFO] extracting crate prototty_glutin 0.20.1 into work/ex/clippy-test-run/sources/stable/reg/prototty_glutin/0.20.1 [INFO] extracting crate prototty_glutin 0.20.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_glutin/0.20.1 [INFO] validating manifest of prototty_glutin-0.20.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prototty_glutin-0.20.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prototty_glutin-0.20.1 [INFO] finished frobbing prototty_glutin-0.20.1 [INFO] frobbed toml for prototty_glutin-0.20.1 written to work/ex/clippy-test-run/sources/stable/reg/prototty_glutin/0.20.1/Cargo.toml [INFO] started frobbing prototty_glutin-0.20.1 [INFO] finished frobbing prototty_glutin-0.20.1 [INFO] frobbed toml for prototty_glutin-0.20.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_glutin/0.20.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prototty_glutin-0.20.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prototty_glutin/0.20.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 920a50fcaa189b5e86f667cbc98cfca7f7dfe820c8e1eaa7fadd899ddac3f590 [INFO] running `"docker" "start" "-a" "920a50fcaa189b5e86f667cbc98cfca7f7dfe820c8e1eaa7fadd899ddac3f590"` [INFO] [stderr] Compiling glutin v0.13.1 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking grid_2d v0.8.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking winit v0.11.3 [INFO] [stderr] Checking prototty v0.20.0 [INFO] [stderr] Checking prototty_grid v0.20.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx_window_glutin v0.21.0 [INFO] [stderr] Checking gfx_glyph v0.9.1 [INFO] [stderr] Checking prototty_glutin v0.20.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return Some(InputEvent::Quit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(InputEvent::Quit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(InputEvent::Resize(width, height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(InputEvent::Resize(width, height))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return Some(InputEvent::Quit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(InputEvent::Quit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(InputEvent::Resize(width, height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(InputEvent::Resize(width, height))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/background.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new( [INFO] [stderr] 45 | | window_width: u32, [INFO] [stderr] 46 | | window_height: u32, [INFO] [stderr] 47 | | cell_width: f32, [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | rgb24.red as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | rgb24.green as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | rgb24.blue as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:158:28 [INFO] [stderr] | [INFO] [stderr] 158 | let window_width = window_width as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let window_height = window_height as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/context.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | .unwrap_or(Size::new(MAX_WIDTH_IN_CELLS, MAX_HEIGHT_IN_CELLS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Size::new(MAX_WIDTH_IN_CELLS, MAX_HEIGHT_IN_CELLS))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / match event { [INFO] [stderr] 285 | | Event::WindowEvent { event, .. } => { [INFO] [stderr] 286 | | if let Some(event) = convert_event(event, cell_dimensions, &mut last_mouse_coord) { [INFO] [stderr] 287 | | match event { [INFO] [stderr] ... | [INFO] [stderr] 294 | | _ => (), [INFO] [stderr] 295 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 284 | if let Event::WindowEvent { event, .. } = event { [INFO] [stderr] 285 | if let Some(event) = convert_event(event, cell_dimensions, &mut last_mouse_coord) { [INFO] [stderr] 286 | match event { [INFO] [stderr] 287 | InputEvent::Input(input) => callback(input), [INFO] [stderr] 288 | InputEvent::Quit => closing = true, [INFO] [stderr] 289 | InputEvent::Resize(width, height) => resize = Some((width, height)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/input.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn convert_keycode(code: VirtualKeyCode, keymod: ModifiersState) -> Option { [INFO] [stderr] 21 | | let shift = keymod.shift; [INFO] [stderr] 22 | | let input = match code { [INFO] [stderr] 23 | | VirtualKeyCode::Space => Input::Char(' '), [INFO] [stderr] ... | [INFO] [stderr] 94 | | Some(input) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | let x = (x / (cell_width as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cell_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | let y = (y / (cell_height as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cell_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/background.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new( [INFO] [stderr] 45 | | window_width: u32, [INFO] [stderr] 46 | | window_height: u32, [INFO] [stderr] 47 | | cell_width: f32, [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | rgb24.red as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | rgb24.green as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/cell.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | rgb24.blue as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb24.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:158:28 [INFO] [stderr] | [INFO] [stderr] 158 | let window_width = window_width as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let window_height = window_height as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/context.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | .unwrap_or(Size::new(MAX_WIDTH_IN_CELLS, MAX_HEIGHT_IN_CELLS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Size::new(MAX_WIDTH_IN_CELLS, MAX_HEIGHT_IN_CELLS))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / match event { [INFO] [stderr] 285 | | Event::WindowEvent { event, .. } => { [INFO] [stderr] 286 | | if let Some(event) = convert_event(event, cell_dimensions, &mut last_mouse_coord) { [INFO] [stderr] 287 | | match event { [INFO] [stderr] ... | [INFO] [stderr] 294 | | _ => (), [INFO] [stderr] 295 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 284 | if let Event::WindowEvent { event, .. } = event { [INFO] [stderr] 285 | if let Some(event) = convert_event(event, cell_dimensions, &mut last_mouse_coord) { [INFO] [stderr] 286 | match event { [INFO] [stderr] 287 | InputEvent::Input(input) => callback(input), [INFO] [stderr] 288 | InputEvent::Quit => closing = true, [INFO] [stderr] 289 | InputEvent::Resize(width, height) => resize = Some((width, height)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/input.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn convert_keycode(code: VirtualKeyCode, keymod: ModifiersState) -> Option { [INFO] [stderr] 21 | | let shift = keymod.shift; [INFO] [stderr] 22 | | let input = match code { [INFO] [stderr] 23 | | VirtualKeyCode::Space => Input::Char(' '), [INFO] [stderr] ... | [INFO] [stderr] 94 | | Some(input) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | let x = (x / (cell_width as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cell_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | let y = (y / (cell_height as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cell_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.46s [INFO] running `"docker" "inspect" "920a50fcaa189b5e86f667cbc98cfca7f7dfe820c8e1eaa7fadd899ddac3f590"` [INFO] running `"docker" "rm" "-f" "920a50fcaa189b5e86f667cbc98cfca7f7dfe820c8e1eaa7fadd899ddac3f590"` [INFO] [stdout] 920a50fcaa189b5e86f667cbc98cfca7f7dfe820c8e1eaa7fadd899ddac3f590