[INFO] crate prototty_elements 0.7.0 is already in cache [INFO] extracting crate prototty_elements 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/prototty_elements/0.7.0 [INFO] extracting crate prototty_elements 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_elements/0.7.0 [INFO] validating manifest of prototty_elements-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prototty_elements-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prototty_elements-0.7.0 [INFO] removed 0 missing examples [INFO] finished frobbing prototty_elements-0.7.0 [INFO] frobbed toml for prototty_elements-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/prototty_elements/0.7.0/Cargo.toml [INFO] started frobbing prototty_elements-0.7.0 [INFO] removed 0 missing examples [INFO] finished frobbing prototty_elements-0.7.0 [INFO] frobbed toml for prototty_elements-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prototty_elements/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prototty_elements-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prototty_elements/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 897d2b2c00fbc7466545f5957e2d0360e2f35faacd269ce1c6776c18b860a049 [INFO] running `"docker" "start" "-a" "897d2b2c00fbc7466545f5957e2d0360e2f35faacd269ce1c6776c18b860a049"` [INFO] [stderr] Checking ansi_colour v0.1.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking prototty v0.4.0 [INFO] [stderr] Checking prototty_elements v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/canvas/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod canvas; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/menu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod menu; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/canvas/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod canvas; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/menu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod menu; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> examples/menu.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | let choice = loop { [INFO] [stderr] | __________________^ [INFO] [stderr] 28 | | match ctx.run_menu(&mut menu_instance, |v| &mut v.child).unwrap() { [INFO] [stderr] 29 | | MenuChoice::Quit => return, [INFO] [stderr] 30 | | MenuChoice::Cancel => break None, [INFO] [stderr] 31 | | MenuChoice::Finalise(x) => break Some(x), [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `prototty_elements`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/tetris.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | self.get_mut(coord).map(|c| c.colour = Some(piece.colour)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = self.get_mut(coord) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "897d2b2c00fbc7466545f5957e2d0360e2f35faacd269ce1c6776c18b860a049"` [INFO] running `"docker" "rm" "-f" "897d2b2c00fbc7466545f5957e2d0360e2f35faacd269ce1c6776c18b860a049"` [INFO] [stdout] 897d2b2c00fbc7466545f5957e2d0360e2f35faacd269ce1c6776c18b860a049