[INFO] crate protocoll 0.3.1 is already in cache [INFO] extracting crate protocoll 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/protocoll/0.3.1 [INFO] extracting crate protocoll 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protocoll/0.3.1 [INFO] validating manifest of protocoll-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of protocoll-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing protocoll-0.3.1 [INFO] finished frobbing protocoll-0.3.1 [INFO] frobbed toml for protocoll-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/protocoll/0.3.1/Cargo.toml [INFO] started frobbing protocoll-0.3.1 [INFO] finished frobbing protocoll-0.3.1 [INFO] frobbed toml for protocoll-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protocoll/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting protocoll-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/protocoll/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5466241baff1415b563bc46112c1e23abaddbdd9ff491c05588d6edd54214ff4 [INFO] running `"docker" "start" "-a" "5466241baff1415b563bc46112c1e23abaddbdd9ff491c05588d6edd54214ff4"` [INFO] [stderr] Checking protocoll v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vec_sorted_map.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | let l = vec.len(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vec_sorted_map.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | let l = vec.len(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/_map.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | impl Map for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 136 | impl Map for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/_map.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | impl MapMut for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 156 | impl MapMut for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/vec_sorted_map.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | {match self.get(k) {Some(_) => true, None => false}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.get(k).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_map.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_map.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | Ok(i) => {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/_set.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | impl Set for HashSet where T:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 33 | impl Set for HashSet where T:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/vec_sorted_set.rs:41:6 [INFO] [stderr] | [INFO] [stderr] 41 | {match self.get(e) {Some(_) => true, None => false}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.get(e).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_set.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/vec_sorted_set.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | {self.extend(iter.into_iter().map(|&e| e));}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/vec_sorted_set.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | / loop { [INFO] [stderr] 247 | | let (e1,e2) = match (opt_e1,opt_e2) { [INFO] [stderr] 248 | | (Some(e1),Some(e2)) => (e1,e2), [INFO] [stderr] 249 | | _ => break [INFO] [stderr] ... | [INFO] [stderr] 255 | | } [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ help: try: `while let (Some(e1),Some(e2)) = (opt_e1,opt_e2) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/vec_sorted_set.rs:388:3 [INFO] [stderr] | [INFO] [stderr] 388 | {loop {match cmp_opt(self.this.peek(),self.that.peek(),Greater,Less) [INFO] [stderr] | ___^ [INFO] [stderr] 389 | | {Less => return self.this.next(), [INFO] [stderr] 390 | | Equal => {self.that.next(); return self.this.next()} [INFO] [stderr] 391 | | Greater => return self.that.next()}}} [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/_seq.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | {Box::new(move |i| self.iter().skip(i).next())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `protocoll`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/_map.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | impl Map for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 136 | impl Map for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/_map.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | impl MapMut for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 156 | impl MapMut for HashMap where K:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/vec_sorted_map.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | {match self.get(k) {Some(_) => true, None => false}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.get(k).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_map.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_map.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | Ok(i) => {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/_set.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | impl Set for HashSet where T:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 33 | impl Set for HashSet where T:Hash+Eq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/vec_sorted_set.rs:41:6 [INFO] [stderr] | [INFO] [stderr] 41 | {match self.get(e) {Some(_) => true, None => false}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.get(e).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vec_sorted_set.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | {let ref mut vec = self.0; [INFO] [stderr] | ----^^^^^^^^^^^---------- help: try: `let vec = &mut self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/vec_sorted_set.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | {self.extend(iter.into_iter().map(|&e| e));}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/vec_sorted_set.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | / loop { [INFO] [stderr] 247 | | let (e1,e2) = match (opt_e1,opt_e2) { [INFO] [stderr] 248 | | (Some(e1),Some(e2)) => (e1,e2), [INFO] [stderr] 249 | | _ => break [INFO] [stderr] ... | [INFO] [stderr] 255 | | } [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ help: try: `while let (Some(e1),Some(e2)) = (opt_e1,opt_e2) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/vec_sorted_set.rs:388:3 [INFO] [stderr] | [INFO] [stderr] 388 | {loop {match cmp_opt(self.this.peek(),self.that.peek(),Greater,Less) [INFO] [stderr] | ___^ [INFO] [stderr] 389 | | {Less => return self.this.next(), [INFO] [stderr] 390 | | Equal => {self.that.next(); return self.this.next()} [INFO] [stderr] 391 | | Greater => return self.that.next()}}} [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/_seq.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | {Box::new(move |i| self.iter().skip(i).next())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `protocoll`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5466241baff1415b563bc46112c1e23abaddbdd9ff491c05588d6edd54214ff4"` [INFO] running `"docker" "rm" "-f" "5466241baff1415b563bc46112c1e23abaddbdd9ff491c05588d6edd54214ff4"` [INFO] [stdout] 5466241baff1415b563bc46112c1e23abaddbdd9ff491c05588d6edd54214ff4