[INFO] crate protoc-rust-copra 0.1.1 is already in cache [INFO] extracting crate protoc-rust-copra 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/protoc-rust-copra/0.1.1 [INFO] extracting crate protoc-rust-copra 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protoc-rust-copra/0.1.1 [INFO] validating manifest of protoc-rust-copra-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of protoc-rust-copra-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing protoc-rust-copra-0.1.1 [INFO] finished frobbing protoc-rust-copra-0.1.1 [INFO] frobbed toml for protoc-rust-copra-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/protoc-rust-copra/0.1.1/Cargo.toml [INFO] started frobbing protoc-rust-copra-0.1.1 [INFO] finished frobbing protoc-rust-copra-0.1.1 [INFO] frobbed toml for protoc-rust-copra-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protoc-rust-copra/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting protoc-rust-copra-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/protoc-rust-copra/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c151bdfcf85f79196d35f89316337467bd891d1e0f644abad4ad4c32d53780a4 [INFO] running `"docker" "start" "-a" "c151bdfcf85f79196d35f89316337467bd891d1e0f644abad4ad4c32d53780a4"` [INFO] [stderr] Compiling protobuf v1.7.4 [INFO] [stderr] Checking protoc v1.7.4 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking protoc-rust v1.7.4 [INFO] [stderr] Checking protoc-rust-copra v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(&path[prefix.len() + 1..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&path[prefix.len() + 1..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(&path[prefix.len() + 1..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&path[prefix.len() + 1..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/provider.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | gen = gen + "}"; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `gen += "}"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/codegen/provider.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | + &format!( [INFO] [stderr] | ____________^ [INFO] [stderr] 148 | | r" [INFO] [stderr] 149 | | entries [INFO] [stderr] 150 | | }} [INFO] [stderr] 151 | | }} [INFO] [stderr] 152 | | " [INFO] [stderr] 153 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 147 | + &r" [INFO] [stderr] 148 | entries [INFO] [stderr] 149 | }} [INFO] [stderr] 150 | }} [INFO] [stderr] 151 | ".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/stub.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / gen = gen [INFO] [stderr] 66 | | + r" } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | "; [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 65 | gen += r" } [INFO] [stderr] 66 | } [INFO] [stderr] 67 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/stub.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | gen = gen + "}\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `gen += "}\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/provider.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | gen = gen + "}"; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `gen += "}"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | if prefix.ends_with("/") || prefix.ends_with("\\") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:161:50 [INFO] [stderr] | [INFO] [stderr] 161 | if prefix.ends_with("/") || prefix.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/codegen/provider.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | + &format!( [INFO] [stderr] | ____________^ [INFO] [stderr] 148 | | r" [INFO] [stderr] 149 | | entries [INFO] [stderr] 150 | | }} [INFO] [stderr] 151 | | }} [INFO] [stderr] 152 | | " [INFO] [stderr] 153 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 147 | + &r" [INFO] [stderr] 148 | entries [INFO] [stderr] 149 | }} [INFO] [stderr] 150 | }} [INFO] [stderr] 151 | ".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/stub.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / gen = gen [INFO] [stderr] 66 | | + r" } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | "; [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 65 | gen += r" } [INFO] [stderr] 66 | } [INFO] [stderr] 67 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen/stub.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | gen = gen + "}\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `gen += "}\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | if prefix.ends_with("/") || prefix.ends_with("\\") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:161:50 [INFO] [stderr] | [INFO] [stderr] 161 | if prefix.ends_with("/") || prefix.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.02s [INFO] running `"docker" "inspect" "c151bdfcf85f79196d35f89316337467bd891d1e0f644abad4ad4c32d53780a4"` [INFO] running `"docker" "rm" "-f" "c151bdfcf85f79196d35f89316337467bd891d1e0f644abad4ad4c32d53780a4"` [INFO] [stdout] c151bdfcf85f79196d35f89316337467bd891d1e0f644abad4ad4c32d53780a4