[INFO] crate protobuf-json 0.3.0 is already in cache [INFO] extracting crate protobuf-json 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/protobuf-json/0.3.0 [INFO] extracting crate protobuf-json 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protobuf-json/0.3.0 [INFO] validating manifest of protobuf-json-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of protobuf-json-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing protobuf-json-0.3.0 [INFO] finished frobbing protobuf-json-0.3.0 [INFO] frobbed toml for protobuf-json-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/protobuf-json/0.3.0/Cargo.toml [INFO] started frobbing protobuf-json-0.3.0 [INFO] finished frobbing protobuf-json-0.3.0 [INFO] frobbed toml for protobuf-json-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/protobuf-json/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting protobuf-json-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/protobuf-json/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9783a7847a19d27ed1d7cca4adc5c1b0d3bb6044f4286fd4d2705c036cc1cefd [INFO] running `"docker" "start" "-a" "9783a7847a19d27ed1d7cca4adc5c1b0d3bb6044f4286fd4d2705c036cc1cefd"` [INFO] [stderr] Checking protobuf-json v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/tests/test_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/tests/test_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | return sub_message; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sub_message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests/mod.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return serde_json::Value::Object(sub_expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::Value::Object(sub_expected)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests/mod.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return serde_json::Value::Array(v.into_iter().map(conv_fn).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::Value::Array(v.into_iter().map(conv_fn).collect())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "9783a7847a19d27ed1d7cca4adc5c1b0d3bb6044f4286fd4d2705c036cc1cefd"` [INFO] running `"docker" "rm" "-f" "9783a7847a19d27ed1d7cca4adc5c1b0d3bb6044f4286fd4d2705c036cc1cefd"` [INFO] [stdout] 9783a7847a19d27ed1d7cca4adc5c1b0d3bb6044f4286fd4d2705c036cc1cefd