[INFO] crate prost-derive 0.4.0 is already in cache [INFO] extracting crate prost-derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/prost-derive/0.4.0 [INFO] extracting crate prost-derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prost-derive/0.4.0 [INFO] validating manifest of prost-derive-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prost-derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prost-derive-0.4.0 [INFO] finished frobbing prost-derive-0.4.0 [INFO] frobbed toml for prost-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/prost-derive/0.4.0/Cargo.toml [INFO] started frobbing prost-derive-0.4.0 [INFO] finished frobbing prost-derive-0.4.0 [INFO] frobbed toml for prost-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prost-derive/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prost-derive-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prost-derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8ac65566914ed2eb27ce1213b6f1107aad88b7aa14a9b0cebb3e05bf72a01b1 [INFO] running `"docker" "start" "-a" "c8ac65566914ed2eb27ce1213b6f1107aad88b7aa14a9b0cebb3e05bf72a01b1"` [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking prost-derive v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | map_ty: map_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `map_ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | key_ty: key_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | tag: tag [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/message.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/oneof.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/oneof.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | map_ty: map_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `map_ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | key_ty: key_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/map.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | tag: tag [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/message.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/oneof.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/oneof.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field/scalar.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/scalar.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/scalar.rs:692:42 [INFO] [stderr] | [INFO] [stderr] 692 | Ty::Enumeration(ref path) => return DefaultValue::Enumeration(quote!(#path::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultValue::Enumeration(quote!(#path::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/field/mod.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | const VARIANTS: &'static [Label] = &[ [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/mod.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | return Ok(Some(tags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(tags))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/scalar.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/scalar.rs:692:42 [INFO] [stderr] | [INFO] [stderr] 692 | Ty::Enumeration(ref path) => return DefaultValue::Enumeration(quote!(#path::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultValue::Enumeration(quote!(#path::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/field/mod.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | const VARIANTS: &'static [Label] = &[ [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field/mod.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | return Ok(Some(tags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(tags))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/field/map.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let k = match &meta_list.nested[0] { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 91 | | &NestedMeta::Meta(Meta::Word(ref k)) => k.to_string(), [INFO] [stderr] 92 | | _ => bail!("invalid map attribute: key must be an identifier"), [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | let k = match meta_list.nested[0] { [INFO] [stderr] 91 | NestedMeta::Meta(Meta::Word(ref k)) => k.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/field/map.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | let v = match &meta_list.nested[1] { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 95 | | &NestedMeta::Meta(Meta::Word(ref v)) => v.to_string(), [INFO] [stderr] 96 | | _ => bail!("invalid map attribute: value must be an identifier"), [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let v = match meta_list.nested[1] { [INFO] [stderr] 95 | NestedMeta::Meta(Meta::Word(ref v)) => v.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/field/scalar.rs:102:62 [INFO] [stderr] | [INFO] [stderr] 102 | (Some(Label::Repeated), packed, false) if packed.unwrap_or(ty.is_numeric()) => Kind::Packed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ty.is_numeric())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/field/scalar.rs:636:20 [INFO] [stderr] | [INFO] [stderr] 636 | if value.chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `value.starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field/mod.rs:184:15 [INFO] [stderr] | [INFO] [stderr] 184 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/field/mod.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | .map(|tags| Some(tags)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/field/map.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let k = match &meta_list.nested[0] { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 91 | | &NestedMeta::Meta(Meta::Word(ref k)) => k.to_string(), [INFO] [stderr] 92 | | _ => bail!("invalid map attribute: key must be an identifier"), [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | let k = match meta_list.nested[0] { [INFO] [stderr] 91 | NestedMeta::Meta(Meta::Word(ref k)) => k.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/field/map.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | let v = match &meta_list.nested[1] { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 95 | | &NestedMeta::Meta(Meta::Word(ref v)) => v.to_string(), [INFO] [stderr] 96 | | _ => bail!("invalid map attribute: value must be an identifier"), [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let v = match meta_list.nested[1] { [INFO] [stderr] 95 | NestedMeta::Meta(Meta::Word(ref v)) => v.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/field/scalar.rs:102:62 [INFO] [stderr] | [INFO] [stderr] 102 | (Some(Label::Repeated), packed, false) if packed.unwrap_or(ty.is_numeric()) => Kind::Packed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ty.is_numeric())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/field/scalar.rs:636:20 [INFO] [stderr] | [INFO] [stderr] 636 | if value.chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `value.starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field/mod.rs:184:15 [INFO] [stderr] | [INFO] [stderr] 184 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/field/mod.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | .map(|tags| Some(tags)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.51s [INFO] running `"docker" "inspect" "c8ac65566914ed2eb27ce1213b6f1107aad88b7aa14a9b0cebb3e05bf72a01b1"` [INFO] running `"docker" "rm" "-f" "c8ac65566914ed2eb27ce1213b6f1107aad88b7aa14a9b0cebb3e05bf72a01b1"` [INFO] [stdout] c8ac65566914ed2eb27ce1213b6f1107aad88b7aa14a9b0cebb3e05bf72a01b1