[INFO] crate prost-build 0.4.0 is already in cache [INFO] extracting crate prost-build 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/prost-build/0.4.0 [INFO] extracting crate prost-build 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prost-build/0.4.0 [INFO] validating manifest of prost-build-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prost-build-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prost-build-0.4.0 [INFO] finished frobbing prost-build-0.4.0 [INFO] frobbed toml for prost-build-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/prost-build/0.4.0/Cargo.toml [INFO] started frobbing prost-build-0.4.0 [INFO] finished frobbing prost-build-0.4.0 [INFO] frobbed toml for prost-build-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prost-build/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prost-build-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prost-build/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc90f3740ae98784b866b9c166f939a539e23817739fdc2c87e2989c37ed876c [INFO] running `"docker" "start" "-a" "cc90f3740ae98784b866b9c166f939a539e23817739fdc2c87e2989c37ed876c"` [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Compiling itertools v0.7.11 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Checking prost v0.4.0 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Compiling prost-build v0.4.0 (/opt/crater/workdir) [INFO] [stderr] Compiling prost-derive v0.4.0 [INFO] [stderr] Checking prost-types v0.4.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | leading_detached: leading_detached, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `leading_detached` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | leading: leading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `leading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | trailing: trailing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trailing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | source_info: source_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | syntax: syntax, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `syntax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | message_graph: message_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | leading_detached: leading_detached, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `leading_detached` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | leading: leading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `leading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | trailing: trailing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trailing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | source_info: source_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | syntax: syntax, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `syntax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | message_graph: message_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/code_generator.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | code_gen.config.service_generator.as_mut().map(|service_generator| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 117 | || service_generator.finalize(buf); [INFO] [stderr] 118 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(service_generator) = code_gen.config.service_generator.as_mut() { service_generator.finalize(buf); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/code_generator.rs:475:41 [INFO] [stderr] | [INFO] [stderr] 475 | for (idx, value) in enum_values.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/code_generator.rs:570:9 [INFO] [stderr] | [INFO] [stderr] 570 | self.config.service_generator.as_mut().map(move |service_generator| service_generator.generate(service, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(service_generator) = self.config.service_generator.as_mut() { service_generator.generate(service, buf) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/code_generator.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | code_gen.config.service_generator.as_mut().map(|service_generator| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 117 | || service_generator.finalize(buf); [INFO] [stderr] 118 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(service_generator) = code_gen.config.service_generator.as_mut() { service_generator.finalize(buf); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/code_generator.rs:475:41 [INFO] [stderr] | [INFO] [stderr] 475 | for (idx, value) in enum_values.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/code_generator.rs:570:9 [INFO] [stderr] | [INFO] [stderr] 570 | self.config.service_generator.as_mut().map(move |service_generator| service_generator.generate(service, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(service_generator) = self.config.service_generator.as_mut() { service_generator.generate(service, buf) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/ident.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / fn test_to_snake() { [INFO] [stderr] 80 | | assert_eq!("foo_bar", &to_snake("FooBar")); [INFO] [stderr] 81 | | assert_eq!("foo_bar_baz", &to_snake("FooBarBAZ")); [INFO] [stderr] 82 | | assert_eq!("foo_bar_baz", &to_snake("FooBarBAZ")); [INFO] [stderr] ... | [INFO] [stderr] 116 | | assert_eq!("field_name18", &to_snake("Field_name18__")); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:563:9 [INFO] [stderr] | [INFO] [stderr] 563 | let _ = env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.09s [INFO] running `"docker" "inspect" "cc90f3740ae98784b866b9c166f939a539e23817739fdc2c87e2989c37ed876c"` [INFO] running `"docker" "rm" "-f" "cc90f3740ae98784b866b9c166f939a539e23817739fdc2c87e2989c37ed876c"` [INFO] [stdout] cc90f3740ae98784b866b9c166f939a539e23817739fdc2c87e2989c37ed876c