[INFO] crate prosafe_exporter 0.2.1 is already in cache [INFO] extracting crate prosafe_exporter 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/prosafe_exporter/0.2.1 [INFO] extracting crate prosafe_exporter 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prosafe_exporter/0.2.1 [INFO] validating manifest of prosafe_exporter-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prosafe_exporter-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prosafe_exporter-0.2.1 [INFO] finished frobbing prosafe_exporter-0.2.1 [INFO] frobbed toml for prosafe_exporter-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/prosafe_exporter/0.2.1/Cargo.toml [INFO] started frobbing prosafe_exporter-0.2.1 [INFO] finished frobbing prosafe_exporter-0.2.1 [INFO] frobbed toml for prosafe_exporter-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prosafe_exporter/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prosafe_exporter-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prosafe_exporter/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8af75cebbcceb34fada86509d4d31ef4b6a7b56b0e9343db885954ed44db46c [INFO] running `"docker" "start" "-a" "e8af75cebbcceb34fada86509d4d31ef4b6a7b56b0e9343db885954ed44db46c"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Compiling handlebars v0.29.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling interfaces2 v0.0.5 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking prosafe_exporter v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | Ok(PortStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | Ok(SpeedStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | Ok(PortStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | Ok(SpeedStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | PortStat = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | SpeedStat = 0x0c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | End = 0xffff0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | PortStat = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | SpeedStat = 0x0c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | End = 0xffff0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:118:48 [INFO] [stderr] | [INFO] [stderr] 118 | if k == "target" && v.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:123:54 [INFO] [stderr] | [INFO] [stderr] 123 | let target: Vec<&str> = target.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/exporter.rs:166:38 [INFO] [stderr] | [INFO] [stderr] 166 | .set(speed as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(speed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:35:55 [INFO] [stderr] | [INFO] [stderr] 35 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prosafe_switch.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | while buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:215:60 [INFO] [stderr] | [INFO] [stderr] 215 | let iface = Interface::get_by_name(&self.if_name)?.ok_or(format_err!( [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 216 | | "failed to get network interface '{}'", [INFO] [stderr] 217 | | self.if_name [INFO] [stderr] 218 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | let iface = Interface::get_by_name(&self.if_name)?.ok_or_else(|| format_err!( [INFO] [stderr] 216 | "failed to get network interface '{}'", [INFO] [stderr] 217 | self.if_name [INFO] [stderr] 218 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prosafe_switch.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | / match address.kind { [INFO] [stderr] 222 | | Kind::Ipv4 => iface_addr = Some(address.addr.unwrap().ip()), [INFO] [stderr] 223 | | _ => (), [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Kind::Ipv4 = address.kind { iface_addr = Some(address.addr.unwrap().ip()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:226:37 [INFO] [stderr] | [INFO] [stderr] 226 | let iface_addr = iface_addr.ok_or(format_err!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 227 | | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 228 | | self.if_name [INFO] [stderr] 229 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 226 | let iface_addr = iface_addr.ok_or_else(|| format_err!( [INFO] [stderr] 227 | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 228 | self.if_name [INFO] [stderr] 229 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match run() { [INFO] [stderr] 58 | | Err(x) => { [INFO] [stderr] 59 | | println!("{}", x); [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(x) = run() { [INFO] [stderr] 58 | println!("{}", x); [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:118:48 [INFO] [stderr] | [INFO] [stderr] 118 | if k == "target" && v.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:123:54 [INFO] [stderr] | [INFO] [stderr] 123 | let target: Vec<&str> = target.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/exporter.rs:166:38 [INFO] [stderr] | [INFO] [stderr] 166 | .set(speed as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(speed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:35:55 [INFO] [stderr] | [INFO] [stderr] 35 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prosafe_switch.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | while buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:215:60 [INFO] [stderr] | [INFO] [stderr] 215 | let iface = Interface::get_by_name(&self.if_name)?.ok_or(format_err!( [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 216 | | "failed to get network interface '{}'", [INFO] [stderr] 217 | | self.if_name [INFO] [stderr] 218 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | let iface = Interface::get_by_name(&self.if_name)?.ok_or_else(|| format_err!( [INFO] [stderr] 216 | "failed to get network interface '{}'", [INFO] [stderr] 217 | self.if_name [INFO] [stderr] 218 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prosafe_switch.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | / match address.kind { [INFO] [stderr] 222 | | Kind::Ipv4 => iface_addr = Some(address.addr.unwrap().ip()), [INFO] [stderr] 223 | | _ => (), [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Kind::Ipv4 = address.kind { iface_addr = Some(address.addr.unwrap().ip()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:226:37 [INFO] [stderr] | [INFO] [stderr] 226 | let iface_addr = iface_addr.ok_or(format_err!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 227 | | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 228 | | self.if_name [INFO] [stderr] 229 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 226 | let iface_addr = iface_addr.ok_or_else(|| format_err!( [INFO] [stderr] 227 | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 228 | self.if_name [INFO] [stderr] 229 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match run() { [INFO] [stderr] 58 | | Err(x) => { [INFO] [stderr] 59 | | println!("{}", x); [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(x) = run() { [INFO] [stderr] 58 | println!("{}", x); [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.57s [INFO] running `"docker" "inspect" "e8af75cebbcceb34fada86509d4d31ef4b6a7b56b0e9343db885954ed44db46c"` [INFO] running `"docker" "rm" "-f" "e8af75cebbcceb34fada86509d4d31ef4b6a7b56b0e9343db885954ed44db46c"` [INFO] [stdout] e8af75cebbcceb34fada86509d4d31ef4b6a7b56b0e9343db885954ed44db46c