[INFO] crate proptest 0.8.7 is already in cache [INFO] extracting crate proptest 0.8.7 into work/ex/clippy-test-run/sources/stable/reg/proptest/0.8.7 [INFO] extracting crate proptest 0.8.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proptest/0.8.7 [INFO] validating manifest of proptest-0.8.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of proptest-0.8.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing proptest-0.8.7 [INFO] finished frobbing proptest-0.8.7 [INFO] frobbed toml for proptest-0.8.7 written to work/ex/clippy-test-run/sources/stable/reg/proptest/0.8.7/Cargo.toml [INFO] started frobbing proptest-0.8.7 [INFO] finished frobbing proptest-0.8.7 [INFO] frobbed toml for proptest-0.8.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proptest/0.8.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting proptest-0.8.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/proptest/0.8.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b9aa2de2729553e059bbcb5da8a8aa55a9239c3ac06d2d9cc0d5f86c83c3c555 [INFO] running `"docker" "start" "-a" "b9aa2de2729553e059bbcb5da8a8aa55a9239c3ac06d2d9cc0d5f86c83c3c555"` [INFO] [stderr] Checking proptest v0.8.7 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1651:5 [INFO] [stderr] | [INFO] [stderr] 1651 | doc_markdown, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1653:5 [INFO] [stderr] | [INFO] [stderr] 1653 | type_complexity [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_runner/runner.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1651:5 [INFO] [stderr] | [INFO] [stderr] 1651 | doc_markdown, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1653:5 [INFO] [stderr] | [INFO] [stderr] 1653 | type_complexity [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_runner/runner.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1651:5 [INFO] [stderr] | [INFO] [stderr] 1651 | doc_markdown, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_runner/replay.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | const SENTINEL: &'static str = "proptest-forkfile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_runner/runner.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | const ENV_FORK_FILE: &'static str = "_PROPTEST_FORKFILE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sample.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sample.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let ret = inner.iter().map(|ix| self.values[ix].clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/sample.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | ((size as u128) * (self.0 as u128) >> (mem::size_of::() * 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((size as u128) * (self.0 as u128)) >> (mem::size_of::() * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1651:5 [INFO] [stderr] | [INFO] [stderr] 1651 | doc_markdown, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/arbitrary/_core/iter.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | const DUMMY: &'static [u8] = &[0, 1, 2, 3, 4]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/array.rs:271:24 [INFO] [stderr] | [INFO] [stderr] 271 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 272 | | if !case.simplify() { break; } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________________^ help: try: `if !case.simplify() { break; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits.rs:521:33 [INFO] [stderr] | [INFO] [stderr] 521 | let input = u32::masked(0xdeadbeef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits.rs:526:20 [INFO] [stderr] | [INFO] [stderr] 526 | assert_eq!(0xdeadbeef, accum); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits.rs:652:43 [INFO] [stderr] | [INFO] [stderr] 652 | check_strategy_sanity(u32::masked(0xdeadbeef), None); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/num.rs:867:24 [INFO] [stderr] | [INFO] [stderr] 867 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 868 | | if !state.complicate() { [INFO] [stderr] 869 | | break; [INFO] [stderr] 870 | | } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 867 | } else if !state.complicate() { [INFO] [stderr] 868 | break; [INFO] [stderr] 869 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/num.rs:901:24 [INFO] [stderr] | [INFO] [stderr] 901 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 902 | | if !state.complicate() { [INFO] [stderr] 903 | | break; [INFO] [stderr] 904 | | } [INFO] [stderr] 905 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 901 | } else if !state.complicate() { [INFO] [stderr] 902 | break; [INFO] [stderr] 903 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_runner/replay.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | const SENTINEL: &'static str = "proptest-forkfile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_runner/runner.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | const ENV_FORK_FILE: &'static str = "_PROPTEST_FORKFILE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_runner/runner.rs:884:22 [INFO] [stderr] | [INFO] [stderr] 884 | const FILE: &'static str = "persistence-test.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tuple.rs:127:24 [INFO] [stderr] | [INFO] [stderr] 127 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 128 | | if !case.simplify() { break; } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________________^ help: try: `if !case.simplify() { break; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sample.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sample.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | let ret = inner.iter().map(|ix| self.values[ix].clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/sample.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | ((size as u128) * (self.0 as u128) >> (mem::size_of::() * 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((size as u128) * (self.0 as u128)) >> (mem::size_of::() * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `A` [INFO] [stderr] --> src/arbitrary/_core/mem.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | args => static_map(any_with::(args), |x| discriminant(&x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mem_discriminant_non_enum)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `A` [INFO] [stderr] --> src/arbitrary/_core/mem.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | base => static_map(base, |x| discriminant(&x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary/_alloc/collections.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 148 | impl functor::ArbitraryF2 [INFO] [stderr] 149 | for HashMap { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/arbitrary/_std/io.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | ].into_iter().cloned().map(Just)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/arbitrary/_std/time.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | UNIX_EPOCH - Duration::new((-(sec as i64)) as u64, ns) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(sec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | self.0.clone().into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.0.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.curr - self.lo).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.curr - self.lo).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strategy/unions.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | for option in &self.options[0..pick+1] { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=pick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | / fn absolutize_source_file<'a>(source: &'a Path) -> Option> { [INFO] [stderr] 183 | | absolutize_source_file_with_cwd(env::current_dir, source) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:186:1 [INFO] [stderr] | [INFO] [stderr] 186 | / fn absolutize_source_file_with_cwd<'a>( [INFO] [stderr] 187 | | getcwd: impl FnOnce () -> io::Result, [INFO] [stderr] 188 | | source: &'a Path, [INFO] [stderr] 189 | | ) -> Option> { [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:244:8 [INFO] [stderr] | [INFO] [stderr] 244 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `core::result::Result` that must be used [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | write!(buf, "{}", format_basic_seed_line(seed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/test_runner/runner.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | elapsed.subsec_nanos() / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_runner/runner.rs:428:69 [INFO] [stderr] | [INFO] [stderr] 428 | if last_fork_file_len.map_or(true, |last_fork_file_len| { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 429 | | last_fork_file_len == curr_forkfile_size [INFO] [stderr] 430 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/test_runner/runner.rs:431:45 [INFO] [stderr] | [INFO] [stderr] 431 | let error = Err(child_error.unwrap_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 432 | | TestCaseError::fail("Child process was terminated abruptly \ [INFO] [stderr] 433 | | but with successful status"))); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 431 | let error = Err(child_error.unwrap_or_else(|| TestCaseError::fail("Child process was terminated abruptly \ [INFO] [stderr] 432 | but with successful status"))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_runner/runner.rs:512:28 [INFO] [stderr] | [INFO] [stderr] 512 | return Err(e.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test_runner/runner.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | if elapsed_ms > self.config.max_shrink_time as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.config.max_shrink_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/test_runner/runner.rs:803:46 [INFO] [stderr] | [INFO] [stderr] 803 | return (Some(TestCaseError::fail(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 804 | | "Timed out waiting for child process"))), Some(current_len)); [INFO] [stderr] | |______________________________________________________^ help: consider using .to_string(): `"Timed out waiting for child process".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sample.rs:222:18 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn index(&self, size: usize) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/string.rs:268:28 [INFO] [stderr] | [INFO] [stderr] 268 | size_range((min as usize)..(max as usize + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min as usize)..=max as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `proptest`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sugar.rs:1367:34 [INFO] [stderr] | [INFO] [stderr] 1367 | fn assert_string(_s: &String) {} [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/sugar.rs:1414:13 [INFO] [stderr] | [INFO] [stderr] 1414 | let foo = Foo; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/sugar.rs:1420:13 [INFO] [stderr] | [INFO] [stderr] 1420 | let foo = Foo; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: ==-comparison of unit values detected. This will always be true [INFO] [stderr] --> src/sugar.rs:1422:21 [INFO] [stderr] | [INFO] [stderr] 1422 | assert!(x == y, "foo: {:?}", foo); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unit_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sugar.rs:938:38 [INFO] [stderr] | [INFO] [stderr] 938 | proptest_helper!(@$cmd [$s] [ref $p]) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1492 | let proptest_helper!(@_EXT _PAT( ref _x : u8 )) = 1; [INFO] [stderr] | ---------------------------------------------------- [INFO] [stderr] | | | [INFO] [stderr] | | in this macro invocation [INFO] [stderr] | help: try: `let _x = &1;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sugar.rs:935:38 [INFO] [stderr] | [INFO] [stderr] 935 | proptest_helper!(@$cmd [$s] [ref mut $p]) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1493 | let proptest_helper!(@_EXT _PAT( ref mut _x : u8 )) = 1; [INFO] [stderr] | -------------------------------------------------------- [INFO] [stderr] | | | [INFO] [stderr] | | in this macro invocation [INFO] [stderr] | help: try: `let _x = &mut 1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `A` [INFO] [stderr] --> src/arbitrary/_core/mem.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | args => static_map(any_with::(args), |x| discriminant(&x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mem_discriminant_non_enum)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `A` [INFO] [stderr] --> src/arbitrary/_core/mem.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | base => static_map(base, |x| discriminant(&x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary/_alloc/collections.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 148 | impl functor::ArbitraryF2 [INFO] [stderr] 149 | for HashMap { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/arbitrary/_std/env.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | assert!(buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/arbitrary/_std/io.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | ].into_iter().cloned().map(Just)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/arbitrary/_std/time.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | UNIX_EPOCH - Duration::new((-(sec as i64)) as u64, ns) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(sec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bit` is used to index `seen_bits` [INFO] [stderr] --> src/bits.rs:618:24 [INFO] [stderr] | [INFO] [stderr] 618 | for bit in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 618 | for (bit, ) in seen_bits.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `seen_counts`. [INFO] [stderr] --> src/bits.rs:626:18 [INFO] [stderr] | [INFO] [stderr] 626 | for i in 4..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 626 | for in seen_counts.iter().take(8).skip(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bool.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | assert!(!tree.clone().simplify()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bool.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | assert!(!tree.clone().complicate()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bool.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | assert!(!tree.clone().simplify()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bool.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | assert!(!tree.clone().complicate()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | self.0.clone().into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.0.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/collection.rs:652:21 [INFO] [stderr] | [INFO] [stderr] 652 | assert!(start.iter().map(|&v| v).collect::().len() >= 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `start.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/collection.rs:655:30 [INFO] [stderr] | [INFO] [stderr] 655 | prop_assert!(v.iter().map(|&v| v).sum::() < 9, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/collection.rs:667:29 [INFO] [stderr] | [INFO] [stderr] 667 | value.iter().map(|&v| v).sum::() == 9, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `value.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.curr - self.lo).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 814 | float_bin_search!(f32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:746:38 [INFO] [stderr] | [INFO] [stderr] 746 | let new_mid = if new_mid == self.curr || 0.0 == interval { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_mid - self.curr).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:752:24 [INFO] [stderr] | [INFO] [stderr] 752 | if new_mid == self.curr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.curr - self.lo).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:769:34 [INFO] [stderr] | [INFO] [stderr] 769 | self.lo = if self.curr == self.lo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 815 | float_bin_search!(f64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:863:26 [INFO] [stderr] | [INFO] [stderr] 863 | if !pass(state.current() as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:874:27 [INFO] [stderr] | [INFO] [stderr] 874 | assert!(!pass(state.current() as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:875:26 [INFO] [stderr] | [INFO] [stderr] 875 | assert!(pass(state.current() as i32 - 1) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:876:26 [INFO] [stderr] | [INFO] [stderr] 876 | pass(state.current() as i32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:897:26 [INFO] [stderr] | [INFO] [stderr] 897 | if !pass(state.current() as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:908:27 [INFO] [stderr] | [INFO] [stderr] 908 | assert!(!pass(state.current() as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/num.rs:909:26 [INFO] [stderr] | [INFO] [stderr] 909 | assert!(pass(state.current() as u32 - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.current())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1056:9 [INFO] [stderr] | [INFO] [stderr] 1056 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1056:9 [INFO] [stderr] | [INFO] [stderr] 1056 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1066:9 [INFO] [stderr] | [INFO] [stderr] 1066 | assert_eq!(1.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1066:9 [INFO] [stderr] | [INFO] [stderr] 1066 | assert_eq!(1.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1076:9 [INFO] [stderr] | [INFO] [stderr] 1076 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1076:9 [INFO] [stderr] | [INFO] [stderr] 1076 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1088:9 [INFO] [stderr] | [INFO] [stderr] 1088 | assert_eq!(orig, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1088:9 [INFO] [stderr] | [INFO] [stderr] 1088 | assert_eq!(orig, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1096:9 [INFO] [stderr] | [INFO] [stderr] 1096 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1096:9 [INFO] [stderr] | [INFO] [stderr] 1096 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1098:9 [INFO] [stderr] | [INFO] [stderr] 1098 | assert_eq!(::std::f64::INFINITY, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1098:9 [INFO] [stderr] | [INFO] [stderr] 1098 | assert_eq!(::std::f64::INFINITY, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1099:18 [INFO] [stderr] | [INFO] [stderr] 1099 | assert!(!value.clone().complicate()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1100:18 [INFO] [stderr] | [INFO] [stderr] 1100 | assert!(!value.clone().simplify()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1108:9 [INFO] [stderr] | [INFO] [stderr] 1108 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1108:9 [INFO] [stderr] | [INFO] [stderr] 1108 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1110:9 [INFO] [stderr] | [INFO] [stderr] 1110 | assert_eq!(::std::f64::NEG_INFINITY, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1110:9 [INFO] [stderr] | [INFO] [stderr] 1110 | assert_eq!(::std::f64::NEG_INFINITY, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1111:18 [INFO] [stderr] | [INFO] [stderr] 1111 | assert!(!value.clone().complicate()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1112:18 [INFO] [stderr] | [INFO] [stderr] 1112 | assert!(!value.clone().simplify()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1120:9 [INFO] [stderr] | [INFO] [stderr] 1120 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1120:9 [INFO] [stderr] | [INFO] [stderr] 1120 | assert_eq!(0.0, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1123:18 [INFO] [stderr] | [INFO] [stderr] 1123 | assert!(!value.clone().complicate()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/num.rs:1124:18 [INFO] [stderr] | [INFO] [stderr] 1124 | assert!(!value.clone().simplify()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/num.rs:1135:9 [INFO] [stderr] | [INFO] [stderr] 1135 | assert_eq!(::std::f64::MIN_POSITIVE, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/num.rs:1135:9 [INFO] [stderr] | [INFO] [stderr] 1135 | assert_eq!(::std::f64::MIN_POSITIVE, value.current()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strategy/unions.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | for option in &self.options[0..pick+1] { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=pick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/strategy/unions.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / fn test_tuple_union_all_sizes() { [INFO] [stderr] 471 | | let mut runner = TestRunner::default(); [INFO] [stderr] 472 | | let r = 1i32..10; [INFO] [stderr] 473 | | [INFO] [stderr] ... | [INFO] [stderr] 501 | | test!(r, r, r, r, r, r, r, r, r); // 10 [INFO] [stderr] 502 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | / fn absolutize_source_file<'a>(source: &'a Path) -> Option> { [INFO] [stderr] 183 | | absolutize_source_file_with_cwd(env::current_dir, source) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:186:1 [INFO] [stderr] | [INFO] [stderr] 186 | / fn absolutize_source_file_with_cwd<'a>( [INFO] [stderr] 187 | | getcwd: impl FnOnce () -> io::Result, [INFO] [stderr] 188 | | source: &'a Path, [INFO] [stderr] 189 | | ) -> Option> { [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:244:8 [INFO] [stderr] | [INFO] [stderr] 244 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `core::result::Result` that must be used [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | write!(buf, "{}", format_basic_seed_line(seed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/test_runner/failure_persistence/file.rs:533:20 [INFO] [stderr] | [INFO] [stderr] 533 | .chain(TEST_RUNNER_PATH.iter().map(|s| *s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `TEST_RUNNER_PATH.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/test_runner/runner.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | elapsed.subsec_nanos() / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_runner/runner.rs:428:69 [INFO] [stderr] | [INFO] [stderr] 428 | if last_fork_file_len.map_or(true, |last_fork_file_len| { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 429 | | last_fork_file_len == curr_forkfile_size [INFO] [stderr] 430 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/test_runner/runner.rs:431:45 [INFO] [stderr] | [INFO] [stderr] 431 | let error = Err(child_error.unwrap_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 432 | | TestCaseError::fail("Child process was terminated abruptly \ [INFO] [stderr] 433 | | but with successful status"))); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 431 | let error = Err(child_error.unwrap_or_else(|| TestCaseError::fail("Child process was terminated abruptly \ [INFO] [stderr] 432 | but with successful status"))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_runner/runner.rs:512:28 [INFO] [stderr] | [INFO] [stderr] 512 | return Err(e.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test_runner/runner.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | if elapsed_ms > self.config.max_shrink_time as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.config.max_shrink_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/test_runner/runner.rs:803:46 [INFO] [stderr] | [INFO] [stderr] 803 | return (Some(TestCaseError::fail(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 804 | | "Timed out waiting for child process"))), Some(current_len)); [INFO] [stderr] | |______________________________________________________^ help: consider using .to_string(): `"Timed out waiting for child process".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test_runner/runner.rs:1186:31 [INFO] [stderr] | [INFO] [stderr] 1186 | prop_assert!(v <= u32::MAX as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test_runner/runner.rs:1192:29 [INFO] [stderr] | [INFO] [stderr] 1192 | assert!(value > u32::MAX as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sample.rs:222:18 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn index(&self, size: usize) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `size_counts` [INFO] [stderr] --> src/sample.rs:449:18 [INFO] [stderr] | [INFO] [stderr] 449 | for i in 3..7 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 449 | for (i, ) in size_counts.iter().enumerate().take(7).skip(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/string.rs:268:28 [INFO] [stderr] | [INFO] [stderr] 268 | size_range((min as usize)..(max as usize + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min as usize)..=max as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 20 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `proptest`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b9aa2de2729553e059bbcb5da8a8aa55a9239c3ac06d2d9cc0d5f86c83c3c555"` [INFO] running `"docker" "rm" "-f" "b9aa2de2729553e059bbcb5da8a8aa55a9239c3ac06d2d9cc0d5f86c83c3c555"` [INFO] [stdout] b9aa2de2729553e059bbcb5da8a8aa55a9239c3ac06d2d9cc0d5f86c83c3c555