[INFO] crate promql 0.3.0 is already in cache [INFO] extracting crate promql 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/promql/0.3.0 [INFO] extracting crate promql 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promql/0.3.0 [INFO] validating manifest of promql-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of promql-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing promql-0.3.0 [INFO] finished frobbing promql-0.3.0 [INFO] frobbed toml for promql-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/promql/0.3.0/Cargo.toml [INFO] started frobbing promql-0.3.0 [INFO] finished frobbing promql-0.3.0 [INFO] frobbed toml for promql-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promql/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting promql-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/promql/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 066483c42149bfebee77be5fbce83db784de9311775d870bed1738f7b22eef3c [INFO] running `"docker" "start" "-a" "066483c42149bfebee77be5fbce83db784de9311775d870bed1738f7b22eef3c"` [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking promql v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | map!(preceded!(char!('-'), atom), |a| Node::negation(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Node::negation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | |labels| labels.unwrap_or(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Pow` [INFO] [stderr] ... [INFO] [stderr] 229 | / named!(power , ws!(do_parse!( [INFO] [stderr] 230 | | x: atom >> [INFO] [stderr] 231 | | y: opt!(tuple!( [INFO] [stderr] 232 | | with_modifier!("^", Op::Pow), [INFO] [stderr] ... | [INFO] [stderr] 238 | | } ) [INFO] [stderr] 239 | | ))); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Mul` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Div` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Mod` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Plus` [INFO] [stderr] ... [INFO] [stderr] 283 | / left_op!(plus_minus, mul_div_mod, alt!( [INFO] [stderr] 284 | | with_modifier!("+", Op::Plus) [INFO] [stderr] 285 | | | with_modifier!("-", Op::Minus) [INFO] [stderr] 286 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Minus` [INFO] [stderr] ... [INFO] [stderr] 283 | / left_op!(plus_minus, mul_div_mod, alt!( [INFO] [stderr] 284 | | with_modifier!("+", Op::Plus) [INFO] [stderr] 285 | | | with_modifier!("-", Op::Minus) [INFO] [stderr] 286 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::And` [INFO] [stderr] ... [INFO] [stderr] 299 | / left_op!(and_unless, comparison, alt!( [INFO] [stderr] 300 | | with_modifier!("and", Op::And) [INFO] [stderr] 301 | | | with_modifier!("unless", Op::Unless) [INFO] [stderr] 302 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Unless` [INFO] [stderr] ... [INFO] [stderr] 299 | / left_op!(and_unless, comparison, alt!( [INFO] [stderr] 300 | | with_modifier!("and", Op::And) [INFO] [stderr] 301 | | | with_modifier!("unless", Op::Unless) [INFO] [stderr] 302 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Or` [INFO] [stderr] ... [INFO] [stderr] 304 | left_op!(or_op, and_unless, with_modifier!("or", Op::Or)); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | map!(preceded!(char!('-'), atom), |a| Node::negation(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Node::negation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | |labels| labels.unwrap_or(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Pow` [INFO] [stderr] ... [INFO] [stderr] 229 | / named!(power , ws!(do_parse!( [INFO] [stderr] 230 | | x: atom >> [INFO] [stderr] 231 | | y: opt!(tuple!( [INFO] [stderr] 232 | | with_modifier!("^", Op::Pow), [INFO] [stderr] ... | [INFO] [stderr] 238 | | } ) [INFO] [stderr] 239 | | ))); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Mul` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Div` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Mod` [INFO] [stderr] ... [INFO] [stderr] 277 | / left_op!(mul_div_mod, power, alt!( [INFO] [stderr] 278 | | with_modifier!("*", Op::Mul) [INFO] [stderr] 279 | | | with_modifier!("/", Op::Div) [INFO] [stderr] 280 | | | with_modifier!("%", Op::Mod) [INFO] [stderr] 281 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Plus` [INFO] [stderr] ... [INFO] [stderr] 283 | / left_op!(plus_minus, mul_div_mod, alt!( [INFO] [stderr] 284 | | with_modifier!("+", Op::Plus) [INFO] [stderr] 285 | | | with_modifier!("-", Op::Minus) [INFO] [stderr] 286 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Minus` [INFO] [stderr] ... [INFO] [stderr] 283 | / left_op!(plus_minus, mul_div_mod, alt!( [INFO] [stderr] 284 | | with_modifier!("+", Op::Plus) [INFO] [stderr] 285 | | | with_modifier!("-", Op::Minus) [INFO] [stderr] 286 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::And` [INFO] [stderr] ... [INFO] [stderr] 299 | / left_op!(and_unless, comparison, alt!( [INFO] [stderr] 300 | | with_modifier!("and", Op::And) [INFO] [stderr] 301 | | | with_modifier!("unless", Op::Unless) [INFO] [stderr] 302 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Unless` [INFO] [stderr] ... [INFO] [stderr] 299 | / left_op!(and_unless, comparison, alt!( [INFO] [stderr] 300 | | with_modifier!("and", Op::And) [INFO] [stderr] 301 | | | with_modifier!("unless", Op::Unless) [INFO] [stderr] 302 | | )); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/expr.rs:191:4 [INFO] [stderr] | [INFO] [stderr] 191 | |op_mod| $op(op_mod) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Op::Or` [INFO] [stderr] ... [INFO] [stderr] 304 | left_op!(or_op, and_unless, with_modifier!("or", Op::Or)); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.26s [INFO] running `"docker" "inspect" "066483c42149bfebee77be5fbce83db784de9311775d870bed1738f7b22eef3c"` [INFO] running `"docker" "rm" "-f" "066483c42149bfebee77be5fbce83db784de9311775d870bed1738f7b22eef3c"` [INFO] [stdout] 066483c42149bfebee77be5fbce83db784de9311775d870bed1738f7b22eef3c