[INFO] crate prompto 0.0.3 is already in cache [INFO] extracting crate prompto 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/prompto/0.0.3 [INFO] extracting crate prompto 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prompto/0.0.3 [INFO] validating manifest of prompto-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prompto-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prompto-0.0.3 [INFO] finished frobbing prompto-0.0.3 [INFO] frobbed toml for prompto-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/prompto/0.0.3/Cargo.toml [INFO] started frobbing prompto-0.0.3 [INFO] finished frobbing prompto-0.0.3 [INFO] frobbed toml for prompto-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prompto/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prompto-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prompto/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e03e47a33a619dabbaddd9f25f1d97c071c68fd0cd059b91efeaa58ea49d28b1 [INFO] running `"docker" "start" "-a" "e03e47a33a619dabbaddd9f25f1d97c071c68fd0cd059b91efeaa58ea49d28b1"` [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking prompto v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:32:61 [INFO] [stderr] | [INFO] [stderr] 32 | ImageError::IoError(cause) => PromptoError::IoError { cause: cause }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:32:61 [INFO] [stderr] | [INFO] [stderr] 32 | ImageError::IoError(cause) => PromptoError::IoError { cause: cause }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | let _r = add_selfie_to_image(&mut source)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | let _r = add_selfie_to_image(&mut source)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | let _r = add_selfie_to_image(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | let _r = mask(&mut image, &prompto, x, y)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/selfie.rs:91:50 [INFO] [stderr] | [INFO] [stderr] 91 | } else if source.height() < other.height() + y { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 92 | | return Err(PromptoError::MaskingError); [INFO] [stderr] 93 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/selfie.rs:89:41 [INFO] [stderr] | [INFO] [stderr] 89 | if source.width() < other.width() + x { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 90 | | return Err(PromptoError::MaskingError); [INFO] [stderr] 91 | | } else if source.height() < other.height() + y { [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `prompto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | let _r = add_selfie_to_image(&mut source)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | let _r = add_selfie_to_image(&mut source)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | let _r = add_selfie_to_image(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _r =` [INFO] [stderr] --> src/selfie.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | let _r = mask(&mut image, &prompto, x, y)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/selfie.rs:91:50 [INFO] [stderr] | [INFO] [stderr] 91 | } else if source.height() < other.height() + y { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 92 | | return Err(PromptoError::MaskingError); [INFO] [stderr] 93 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/selfie.rs:89:41 [INFO] [stderr] | [INFO] [stderr] 89 | if source.width() < other.width() + x { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 90 | | return Err(PromptoError::MaskingError); [INFO] [stderr] 91 | | } else if source.height() < other.height() + y { [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _selfie =` [INFO] [stderr] --> src/selfie.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | let _selfie = add_selfie_to_image(&mut image).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/selfie.rs:254:5 [INFO] [stderr] | [INFO] [stderr] 254 | let _ = image.save(&mut buf, format).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `prompto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e03e47a33a619dabbaddd9f25f1d97c071c68fd0cd059b91efeaa58ea49d28b1"` [INFO] running `"docker" "rm" "-f" "e03e47a33a619dabbaddd9f25f1d97c071c68fd0cd059b91efeaa58ea49d28b1"` [INFO] [stdout] e03e47a33a619dabbaddd9f25f1d97c071c68fd0cd059b91efeaa58ea49d28b1