[INFO] crate promptly 0.1.5 is already in cache [INFO] extracting crate promptly 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/promptly/0.1.5 [INFO] extracting crate promptly 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promptly/0.1.5 [INFO] validating manifest of promptly-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of promptly-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing promptly-0.1.5 [INFO] finished frobbing promptly-0.1.5 [INFO] frobbed toml for promptly-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/promptly/0.1.5/Cargo.toml [INFO] started frobbing promptly-0.1.5 [INFO] finished frobbing promptly-0.1.5 [INFO] frobbed toml for promptly-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promptly/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting promptly-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/promptly/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63df359e39653638a6402bb262224fd8e62170b8e9a72fd834b6d5a36efd33d8 [INFO] running `"docker" "start" "-a" "63df359e39653638a6402bb262224fd8e62170b8e9a72fd834b6d5a36efd33d8"` [INFO] [stderr] Checking promptly v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | let msg = match default { [INFO] [stderr] | ___________________^ [INFO] [stderr] 207 | | true => format!("{} (Y/n)", msg.as_ref()), [INFO] [stderr] 208 | | false => format!("{} (y/N)", msg.as_ref()), [INFO] [stderr] 209 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if default { format!("{} (Y/n)", msg.as_ref()) } else { format!("{} (y/N)", msg.as_ref()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Prompter<()>` [INFO] [stderr] --> src/lib.rs:311:5 [INFO] [stderr] | [INFO] [stderr] 311 | / pub fn new() -> Prompter<()> { [INFO] [stderr] 312 | | Prompter { [INFO] [stderr] 313 | | editor: Editor::new(), [INFO] [stderr] 314 | | err_handler: Box::new(default_err_handler) [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | impl Default for Prompter<()> { [INFO] [stderr] 311 | fn default() -> Self { [INFO] [stderr] 312 | Self::new() [INFO] [stderr] 313 | } [INFO] [stderr] 314 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:449:22 [INFO] [stderr] | [INFO] [stderr] 449 | if s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | let msg = match default { [INFO] [stderr] | ___________________^ [INFO] [stderr] 207 | | true => format!("{} (Y/n)", msg.as_ref()), [INFO] [stderr] 208 | | false => format!("{} (y/N)", msg.as_ref()), [INFO] [stderr] 209 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if default { format!("{} (Y/n)", msg.as_ref()) } else { format!("{} (y/N)", msg.as_ref()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Prompter<()>` [INFO] [stderr] --> src/lib.rs:311:5 [INFO] [stderr] | [INFO] [stderr] 311 | / pub fn new() -> Prompter<()> { [INFO] [stderr] 312 | | Prompter { [INFO] [stderr] 313 | | editor: Editor::new(), [INFO] [stderr] 314 | | err_handler: Box::new(default_err_handler) [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | impl Default for Prompter<()> { [INFO] [stderr] 311 | fn default() -> Self { [INFO] [stderr] 312 | Self::new() [INFO] [stderr] 313 | } [INFO] [stderr] 314 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:449:22 [INFO] [stderr] | [INFO] [stderr] 449 | if s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "63df359e39653638a6402bb262224fd8e62170b8e9a72fd834b6d5a36efd33d8"` [INFO] running `"docker" "rm" "-f" "63df359e39653638a6402bb262224fd8e62170b8e9a72fd834b6d5a36efd33d8"` [INFO] [stdout] 63df359e39653638a6402bb262224fd8e62170b8e9a72fd834b6d5a36efd33d8