[INFO] crate promising-future 0.2.4 is already in cache [INFO] extracting crate promising-future 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/promising-future/0.2.4 [INFO] extracting crate promising-future 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promising-future/0.2.4 [INFO] validating manifest of promising-future-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of promising-future-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing promising-future-0.2.4 [INFO] finished frobbing promising-future-0.2.4 [INFO] frobbed toml for promising-future-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/promising-future/0.2.4/Cargo.toml [INFO] started frobbing promising-future-0.2.4 [INFO] finished frobbing promising-future-0.2.4 [INFO] frobbed toml for promising-future-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promising-future/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting promising-future-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/promising-future/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93901ba04755aadae886356b588a3b821b9b27694e45386fcd44289dcbd0f43c [INFO] running `"docker" "start" "-a" "93901ba04755aadae886356b588a3b821b9b27694e45386fcd44289dcbd0f43c"` [INFO] [stderr] Checking promising-future v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futurestream.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futurestream.rs:142:30 [INFO] [stderr] | [INFO] [stderr] 142 | FutureStreamWaiter { fs: fs, rx: Some(rx) } [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futurestream.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futurestream.rs:142:30 [INFO] [stderr] | [INFO] [stderr] 142 | FutureStreamWaiter { fs: fs, rx: Some(rx) } [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `inner::Inner` [INFO] [stderr] --> src/inner.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new() -> Inner { Inner::Empty } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for inner::Inner { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inner.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | if let &Inner::Gone = self { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | if let Inner::Gone = *self { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inner.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let state = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 25 | | &Empty => "Empty".into(), [INFO] [stderr] 26 | | &Val(ref v) => format!("Val({:?})", v), [INFO] [stderr] 27 | | &Gone => "Gone".into(), [INFO] [stderr] 28 | | &Callback(_) => "Callback(_)".into(), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | let state = match *self { [INFO] [stderr] 25 | Empty => "Empty".into(), [INFO] [stderr] 26 | Val(ref v) => format!("Val({:?})", v), [INFO] [stderr] 27 | Gone => "Gone".into(), [INFO] [stderr] 28 | Callback(_) => "Callback(_)".into(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/future.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | let v = mem::replace(v, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `v.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/future.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / if let &mut Future::Prom(ref mut inner) = self { [INFO] [stderr] 293 | | let mut lk = inner.mx.lock().expect("lock"); [INFO] [stderr] 294 | | [INFO] [stderr] 295 | | if let &Inner::Empty = &*lk { [INFO] [stderr] 296 | | *lk = Inner::Gone; [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 292 | if let Future::Prom(ref mut inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/future.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | / if let &Inner::Empty = &*lk { [INFO] [stderr] 296 | | *lk = Inner::Gone; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 295 | if let Inner::Empty = *lk { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/future.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | let state = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 307 | | &Const(ref v) => format!("Const({:?})", v), [INFO] [stderr] 308 | | &Prom(ref inner) => { [INFO] [stderr] 309 | | let lk = inner.mx.lock().unwrap(); [INFO] [stderr] 310 | | format!("Prom({:?})", *lk) [INFO] [stderr] 311 | | }, [INFO] [stderr] 312 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 306 | let state = match *self { [INFO] [stderr] 307 | Const(ref v) => format!("Const({:?})", v), [INFO] [stderr] 308 | Prom(ref inner) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `futurestream::FutureStream` [INFO] [stderr] --> src/futurestream.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> FutureStream { [INFO] [stderr] 71 | | let (tx, rx) = channel(); [INFO] [stderr] 72 | | let inner = FutureStreamInner { [INFO] [stderr] 73 | | rx: Some(rx), [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | impl Default for futurestream::FutureStream { [INFO] [stderr] 70 | fn default() -> Self { [INFO] [stderr] 71 | Self::new() [INFO] [stderr] 72 | } [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/futurestream.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn waiter<'fs>(&'fs self) -> FutureStreamWaiter<'fs, T> { [INFO] [stderr] 100 | | let mut inner = self.inner.mx.lock().unwrap(); [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/futurestream.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn try_waiter<'fs>(&'fs self) -> Option> { [INFO] [stderr] 112 | | let mut inner = self.inner.mx.lock().unwrap(); [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | match inner.rx.take() { [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/futurestream.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if { let l = self.fs.inner.mx.lock().unwrap(); l.pending == 0 } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { let l = self.fs.inner.mx.lock().unwrap(); l.pending == 0 }; [INFO] [stderr] if res { [INFO] [stderr] // Nothing left [INFO] [stderr] None [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `inner::Inner` [INFO] [stderr] --> src/inner.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new() -> Inner { Inner::Empty } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for inner::Inner { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inner.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | if let &Inner::Gone = self { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | if let Inner::Gone = *self { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inner.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let state = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 25 | | &Empty => "Empty".into(), [INFO] [stderr] 26 | | &Val(ref v) => format!("Val({:?})", v), [INFO] [stderr] 27 | | &Gone => "Gone".into(), [INFO] [stderr] 28 | | &Callback(_) => "Callback(_)".into(), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | let state = match *self { [INFO] [stderr] 25 | Empty => "Empty".into(), [INFO] [stderr] 26 | Val(ref v) => format!("Val({:?})", v), [INFO] [stderr] 27 | Gone => "Gone".into(), [INFO] [stderr] 28 | Callback(_) => "Callback(_)".into(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/future.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | let v = mem::replace(v, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `v.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/future.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / if let &mut Future::Prom(ref mut inner) = self { [INFO] [stderr] 293 | | let mut lk = inner.mx.lock().expect("lock"); [INFO] [stderr] 294 | | [INFO] [stderr] 295 | | if let &Inner::Empty = &*lk { [INFO] [stderr] 296 | | *lk = Inner::Gone; [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 292 | if let Future::Prom(ref mut inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/future.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | / if let &Inner::Empty = &*lk { [INFO] [stderr] 296 | | *lk = Inner::Gone; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 295 | if let Inner::Empty = *lk { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/future.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | let state = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 307 | | &Const(ref v) => format!("Const({:?})", v), [INFO] [stderr] 308 | | &Prom(ref inner) => { [INFO] [stderr] 309 | | let lk = inner.mx.lock().unwrap(); [INFO] [stderr] 310 | | format!("Prom({:?})", *lk) [INFO] [stderr] 311 | | }, [INFO] [stderr] 312 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 306 | let state = match *self { [INFO] [stderr] 307 | Const(ref v) => format!("Const({:?})", v), [INFO] [stderr] 308 | Prom(ref inner) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `futurestream::FutureStream` [INFO] [stderr] --> src/futurestream.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> FutureStream { [INFO] [stderr] 71 | | let (tx, rx) = channel(); [INFO] [stderr] 72 | | let inner = FutureStreamInner { [INFO] [stderr] 73 | | rx: Some(rx), [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | impl Default for futurestream::FutureStream { [INFO] [stderr] 70 | fn default() -> Self { [INFO] [stderr] 71 | Self::new() [INFO] [stderr] 72 | } [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/futurestream.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn waiter<'fs>(&'fs self) -> FutureStreamWaiter<'fs, T> { [INFO] [stderr] 100 | | let mut inner = self.inner.mx.lock().unwrap(); [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/futurestream.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn try_waiter<'fs>(&'fs self) -> Option> { [INFO] [stderr] 112 | | let mut inner = self.inner.mx.lock().unwrap(); [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | match inner.rx.take() { [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/futurestream.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if { let l = self.fs.inner.mx.lock().unwrap(); l.pending == 0 } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { let l = self.fs.inner.mx.lock().unwrap(); l.pending == 0 }; [INFO] [stderr] if res { [INFO] [stderr] // Nothing left [INFO] [stderr] None [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `promising-future`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> tests/tests.rs:15:65 [INFO] [stderr] | [INFO] [stderr] 15 | thread::sleep(Duration::new(ms as u64 / 1000, ((ms as u64 * 1000_000) % 1000_000_000) as u32)) [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> tests/tests.rs:15:77 [INFO] [stderr] | [INFO] [stderr] 15 | thread::sleep(Duration::new(ms as u64 / 1000, ((ms as u64 * 1000_000) % 1000_000_000) as u32)) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:481:24 [INFO] [stderr] | [INFO] [stderr] 481 | const ITERS: u32 = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:517:24 [INFO] [stderr] | [INFO] [stderr] 517 | const ITERS: u32 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/tests.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | thread::sleep(Duration::new(ms as u64 / 1000, ((ms as u64 * 1000_000) % 1000_000_000) as u32)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/tests.rs:15:53 [INFO] [stderr] | [INFO] [stderr] 15 | thread::sleep(Duration::new(ms as u64 / 1000, ((ms as u64 * 1000_000) % 1000_000_000) as u32)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/tests.rs:482:43 [INFO] [stderr] | [INFO] [stderr] 482 | let (futs, proms): (Vec<_>, Vec<_>) = (0..ITERS).into_iter().map(|i| { let (f, p) = future_promise(); ((i, f), (i, p)) }).unzip(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..ITERS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> tests/tests.rs:504:9 [INFO] [stderr] | [INFO] [stderr] 504 | Err(_) => panic!("futurer failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> tests/tests.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | Err(_) => panic!("promiser failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> tests/tests.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | Err(_) => panic!("promiser failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/tests.rs:562:43 [INFO] [stderr] | [INFO] [stderr] 562 | let (futs, proms): (Vec<_>, Vec<_>) = (0..ITERS).into_iter().map(|i| { let (f, p) = future_promise(); (f, (i, p)) }).unzip(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..ITERS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> tests/tests.rs:589:9 [INFO] [stderr] | [INFO] [stderr] 589 | Err(_) => panic!("promiser failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "93901ba04755aadae886356b588a3b821b9b27694e45386fcd44289dcbd0f43c"` [INFO] running `"docker" "rm" "-f" "93901ba04755aadae886356b588a3b821b9b27694e45386fcd44289dcbd0f43c"` [INFO] [stdout] 93901ba04755aadae886356b588a3b821b9b27694e45386fcd44289dcbd0f43c