[INFO] crate promiser 0.0.5 is already in cache
[INFO] extracting crate promiser 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/promiser/0.0.5
[INFO] extracting crate promiser 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promiser/0.0.5
[INFO] validating manifest of promiser-0.0.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of promiser-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing promiser-0.0.5
[INFO] finished frobbing promiser-0.0.5
[INFO] frobbed toml for promiser-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/promiser/0.0.5/Cargo.toml
[INFO] started frobbing promiser-0.0.5
[INFO] finished frobbing promiser-0.0.5
[INFO] frobbed toml for promiser-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promiser/0.0.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting promiser-0.0.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/promiser/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e81b73609a6d4f900267c25303e8240f14f8330db3523a01ebc75e362615268b
[INFO] running `"docker" "start" "-a" "e81b73609a6d4f900267c25303e8240f14f8330db3523a01ebc75e362615268b"`
[INFO] [stderr]     Checking promiser v0.0.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/promise.rs:41:29
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let pt = Promiser { p: p,
[INFO] [stderr]    |                             ^^^^ help: replace it with: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/promise.rs:41:29
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let pt = Promiser { p: p,
[INFO] [stderr]    |                             ^^^^ help: replace it with: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/promise.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return false
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/promise.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 return Err("safety hatch, promise not capable".to_string());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("safety hatch, promise not capable".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `latch::Latch`
[INFO] [stderr]   --> src/latch.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new () -> Latch {
[INFO] [stderr] 11 | |         Latch { latch: Arc::new(AtomicBool::new(false)) }
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/latch.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         if !self.latch.compare_and_swap(false,true,Ordering::Release) {true}
[INFO] [stderr] 17 | |         else {false}
[INFO] [stderr]    | |____________________^ help: you can reduce it to: `!self.latch.compare_and_swap(false,true,Ordering::Release)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/promise.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new () -> (Promiser<T>,Promisee<T>) {
[INFO] [stderr] 33 | |         let (t,r) = channel();
[INFO] [stderr] 34 | |         let d: Option<T> = None;
[INFO] [stderr] 35 | | 
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         (pt,pr)
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/promise.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn clone (&self) -> Promise<T> {
[INFO] [stderr] 50 | |         Promise { data: self.data.clone(),
[INFO] [stderr] 51 | |                   init: self.init.clone(),
[INFO] [stderr] 52 | |                   commit: self.commit.clone(),}
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/promise.rs:169:29
[INFO] [stderr]     |
[INFO] [stderr] 169 |                       let r = match *d {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 170 | |                         Some(_) => true,
[INFO] [stderr] 171 | |                         None => false,
[INFO] [stderr] 172 | |                     };
[INFO] [stderr]     | |_____________________^ help: try this: `*d.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/promise.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 | /     pub fn clone(&self) -> Promisee<T> {
[INFO] [stderr] 182 | |         Promisee { p: self.p.clone(),
[INFO] [stderr] 183 | |                    sink: self.sink.clone(), }
[INFO] [stderr] 184 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/promise.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return false
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/promise.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 return Err("safety hatch, promise not capable".to_string());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("safety hatch, promise not capable".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `latch::Latch`
[INFO] [stderr]   --> src/latch.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new () -> Latch {
[INFO] [stderr] 11 | |         Latch { latch: Arc::new(AtomicBool::new(false)) }
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/latch.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         if !self.latch.compare_and_swap(false,true,Ordering::Release) {true}
[INFO] [stderr] 17 | |         else {false}
[INFO] [stderr]    | |____________________^ help: you can reduce it to: `!self.latch.compare_and_swap(false,true,Ordering::Release)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/promise.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new () -> (Promiser<T>,Promisee<T>) {
[INFO] [stderr] 33 | |         let (t,r) = channel();
[INFO] [stderr] 34 | |         let d: Option<T> = None;
[INFO] [stderr] 35 | | 
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         (pt,pr)
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/promise.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn clone (&self) -> Promise<T> {
[INFO] [stderr] 50 | |         Promise { data: self.data.clone(),
[INFO] [stderr] 51 | |                   init: self.init.clone(),
[INFO] [stderr] 52 | |                   commit: self.commit.clone(),}
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/promise.rs:169:29
[INFO] [stderr]     |
[INFO] [stderr] 169 |                       let r = match *d {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 170 | |                         Some(_) => true,
[INFO] [stderr] 171 | |                         None => false,
[INFO] [stderr] 172 | |                     };
[INFO] [stderr]     | |_____________________^ help: try this: `*d.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/promise.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 | /     pub fn clone(&self) -> Promisee<T> {
[INFO] [stderr] 182 | |         Promisee { p: self.p.clone(),
[INFO] [stderr] 183 | |                    sink: self.sink.clone(), }
[INFO] [stderr] 184 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.99s
[INFO] running `"docker" "inspect" "e81b73609a6d4f900267c25303e8240f14f8330db3523a01ebc75e362615268b"`
[INFO] running `"docker" "rm" "-f" "e81b73609a6d4f900267c25303e8240f14f8330db3523a01ebc75e362615268b"`
[INFO] [stdout] e81b73609a6d4f900267c25303e8240f14f8330db3523a01ebc75e362615268b