[INFO] crate promise-rs 0.3.0 is already in cache
[INFO] extracting crate promise-rs 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/promise-rs/0.3.0
[INFO] extracting crate promise-rs 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promise-rs/0.3.0
[INFO] validating manifest of promise-rs-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of promise-rs-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing promise-rs-0.3.0
[INFO] finished frobbing promise-rs-0.3.0
[INFO] frobbed toml for promise-rs-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/promise-rs/0.3.0/Cargo.toml
[INFO] started frobbing promise-rs-0.3.0
[INFO] finished frobbing promise-rs-0.3.0
[INFO] frobbed toml for promise-rs-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promise-rs/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting promise-rs-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/promise-rs/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 12120280c44a682b93a031830418226a8a35998815b71397f5a623f435cd0acc
[INFO] running `"docker" "start" "-a" "12120280c44a682b93a031830418226a8a35998815b71397f5a623f435cd0acc"`
[INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other binary targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a binary target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/src/main.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autobins = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `promise`,
[INFO] [stderr] please set bin.path in Cargo.toml
[INFO] [stderr]     Checking promise-rs v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:19
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:39
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:68
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:19
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:39
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:68
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Promise { handlers: handlers, state: state, value: result, thread:thread }
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             return Promise::reject(Some(first_reject_reason));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise::reject(Some(first_reject_reason))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             return Promise::resolve(Some(resoved_results.join(delimeter)));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise::resolve(Some(resoved_results.join(delimeter)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let mut state = state_guard.as_mut().unwrap();
[INFO] [stderr]    |                     ----^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 let mut state = state_guard.as_mut().unwrap();
[INFO] [stderr]    |                     ----^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             return Promise::reject(Some(first_reject_reason));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise::reject(Some(first_reject_reason))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             return Promise::resolve(Some(resoved_results.join(delimeter)));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise::resolve(Some(resoved_results.join(delimeter)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/lib.rs:44:24
[INFO] [stderr]    |
[INFO] [stderr] 44 |                     if handler.resolve == true {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `handler.resolve`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/lib.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if handler.resolve == false {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!handler.resolve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: unused attribute
[INFO] [stderr]    --> src/lib.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 |         #[derive(Debug)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_attributes)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:199:25
[INFO] [stderr]     |
[INFO] [stderr] 199 |             let value = promise.value.lock().unwrap().clone().unwrap_or(String::new());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `promise.value.lock().unwrap().clone().unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let mut state = state_guard.as_mut().unwrap();
[INFO] [stderr]    |                     ----^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/lib.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 let mut state = state_guard.as_mut().unwrap();
[INFO] [stderr]    |                     ----^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/lib.rs:44:24
[INFO] [stderr]    |
[INFO] [stderr] 44 |                     if handler.resolve == true {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `handler.resolve`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/lib.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if handler.resolve == false {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!handler.resolve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: unused attribute
[INFO] [stderr]    --> src/lib.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 |         #[derive(Debug)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_attributes)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:199:25
[INFO] [stderr]     |
[INFO] [stderr] 199 |             let value = promise.value.lock().unwrap().clone().unwrap_or(String::new());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `promise.value.lock().unwrap().clone().unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.50s
[INFO] running `"docker" "inspect" "12120280c44a682b93a031830418226a8a35998815b71397f5a623f435cd0acc"`
[INFO] running `"docker" "rm" "-f" "12120280c44a682b93a031830418226a8a35998815b71397f5a623f435cd0acc"`
[INFO] [stdout] 12120280c44a682b93a031830418226a8a35998815b71397f5a623f435cd0acc