[INFO] crate prometheus-scrape 0.1.1 is already in cache
[INFO] extracting crate prometheus-scrape 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/prometheus-scrape/0.1.1
[INFO] extracting crate prometheus-scrape 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prometheus-scrape/0.1.1
[INFO] validating manifest of prometheus-scrape-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of prometheus-scrape-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing prometheus-scrape-0.1.1
[INFO] finished frobbing prometheus-scrape-0.1.1
[INFO] frobbed toml for prometheus-scrape-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/prometheus-scrape/0.1.1/Cargo.toml
[INFO] started frobbing prometheus-scrape-0.1.1
[INFO] finished frobbing prometheus-scrape-0.1.1
[INFO] frobbed toml for prometheus-scrape-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prometheus-scrape/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting prometheus-scrape-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prometheus-scrape/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5ae4d42ab6d3102c1ca0a93c88cb826f477ee48f15210d5eaa7b99ab2f1fdd9c
[INFO] running `"docker" "start" "-a" "5ae4d42ab6d3102c1ca0a93c88cb826f477ee48f15210d5eaa7b99ab2f1fdd9c"`
[INFO] [stderr]     Checking prometheus-scrape v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:91:29
[INFO] [stderr]    |
[INFO] [stderr] 91 |                             sample_type: sample_type,
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:279:41
[INFO] [stderr]     |
[INFO] [stderr] 279 |                                         timestamp: timestamp,
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:294:41
[INFO] [stderr]     |
[INFO] [stderr] 294 |                                         timestamp: timestamp,
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:310:29
[INFO] [stderr]     |
[INFO] [stderr] 310 |                             timestamp: timestamp,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:319:13
[INFO] [stderr]     |
[INFO] [stderr] 319 |             docs: docs,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `docs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:320:13
[INFO] [stderr]     |
[INFO] [stderr] 320 |             samples: samples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `samples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:91:29
[INFO] [stderr]    |
[INFO] [stderr] 91 |                             sample_type: sample_type,
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:279:41
[INFO] [stderr]     |
[INFO] [stderr] 279 |                                         timestamp: timestamp,
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:294:41
[INFO] [stderr]     |
[INFO] [stderr] 294 |                                         timestamp: timestamp,
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:310:29
[INFO] [stderr]     |
[INFO] [stderr] 310 |                             timestamp: timestamp,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:319:13
[INFO] [stderr]     |
[INFO] [stderr] 319 |             docs: docs,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `docs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:320:13
[INFO] [stderr]     |
[INFO] [stderr] 320 |             samples: samples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `samples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 | /                 return match (
[INFO] [stderr] 102 | |                     caps.name("name"),
[INFO] [stderr] 103 | |                     caps.name("labels"),
[INFO] [stderr] 104 | |                     caps.name("value"),
[INFO] [stderr] ...   |
[INFO] [stderr] 113 | |                     _ => LineInfo::Ignored,
[INFO] [stderr] 114 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 match (
[INFO] [stderr] 102 |                     caps.name("name"),
[INFO] [stderr] 103 |                     caps.name("labels"),
[INFO] [stderr] 104 |                     caps.name("value"),
[INFO] [stderr] 105 |                     caps.name("timestamp"),
[INFO] [stderr] 106 |                 ) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 | /                 return match (
[INFO] [stderr] 102 | |                     caps.name("name"),
[INFO] [stderr] 103 | |                     caps.name("labels"),
[INFO] [stderr] 104 | |                     caps.name("value"),
[INFO] [stderr] ...   |
[INFO] [stderr] 113 | |                     _ => LineInfo::Ignored,
[INFO] [stderr] 114 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 match (
[INFO] [stderr] 102 |                     caps.name("name"),
[INFO] [stderr] 103 |                     caps.name("labels"),
[INFO] [stderr] 104 |                     caps.name("value"),
[INFO] [stderr] 105 |                     caps.name("timestamp"),
[INFO] [stderr] 106 |                 ) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:513:49
[INFO] [stderr]     |
[INFO] [stderr] 513 |                 timestamp: Utc.timestamp_millis(1395066363000),
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: consider: `1_395_066_363_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:528:49
[INFO] [stderr]     |
[INFO] [stderr] 528 |                 timestamp: Utc.timestamp_millis(1395066363000),
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: consider: `1_395_066_363_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:66:12
[INFO] [stderr]    |
[INFO] [stderr] 66 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 | /         match HELP_RE.captures(line) {
[INFO] [stderr] 70 | |             Some(ref caps) => {
[INFO] [stderr] 71 | |                 return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 72 | |                     (Some(ref metric_name), Some(ref doc)) => LineInfo::Doc {
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |             None => {}
[INFO] [stderr] 80 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if let Some(ref caps) = HELP_RE.captures(line) {
[INFO] [stderr] 70 |     return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 71 |         (Some(ref metric_name), Some(ref doc)) => LineInfo::Doc {
[INFO] [stderr] 72 |             metric_name: metric_name.as_str(),
[INFO] [stderr] 73 |             doc: doc.as_str(),
[INFO] [stderr] 74 |         },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match TYPE_RE.captures(line) {
[INFO] [stderr] 82 | |             Some(ref caps) => {
[INFO] [stderr] 83 | |                 return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 84 | |                     (Some(ref metric_name), Some(ref sample_type)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             None => {}
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 |         if let Some(ref caps) = TYPE_RE.captures(line) {
[INFO] [stderr] 82 |     return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 83 |         (Some(ref metric_name), Some(ref sample_type)) => {
[INFO] [stderr] 84 |             let sample_type = SampleType::parse(sample_type.as_str());
[INFO] [stderr] 85 |             LineInfo::Type {
[INFO] [stderr] 86 |                 metric_name: match sample_type {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/lib.rs:109:33
[INFO] [stderr]     |
[INFO] [stderr] 109 |                         labels: labels.map_or(None, |c| Some(c.as_str())),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `labels.and_then(|c| Some(c.as_str()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/lib.rs:111:36
[INFO] [stderr]     |
[INFO] [stderr] 111 |                         timestamp: timestamp.map_or(None, |c| Some(c.as_str())),
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `timestamp.and_then(|c| Some(c.as_str()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:130:31
[INFO] [stderr]     |
[INFO] [stderr] 130 |     if let Some(kv) = s.split(",").next() {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:131:31
[INFO] [stderr]     |
[INFO] [stderr] 131 |         let kvpair = kv.split("=").collect::<Vec<_>>();
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:167:27
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for kv in s.split(",") {
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:168:35
[INFO] [stderr]     |
[INFO] [stderr] 168 |             let kvpair = kv.split("=").collect::<Vec<_>>();
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:169:37
[INFO] [stderr]     |
[INFO] [stderr] 169 |             if kvpair.len() != 2 || kvpair[0].len() == 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `kvpair[0].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:195:9
[INFO] [stderr]     |
[INFO] [stderr] 195 | /         match self {
[INFO] [stderr] 196 | |             &mut Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr] 197 | |             _ => {}
[INFO] [stderr] 198 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let &mut Value::Histogram(ref mut hs) = self { hs.push(h) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:195:9
[INFO] [stderr]     |
[INFO] [stderr] 195 | /         match self {
[INFO] [stderr] 196 | |             &mut Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr] 197 | |             _ => {}
[INFO] [stderr] 198 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 195 |         match *self {
[INFO] [stderr] 196 |             Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         match self {
[INFO] [stderr] 202 | |             &mut Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr] 203 | |             _ => {}
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let &mut Value::Summary(ref mut ss) = self { ss.push(s) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         match self {
[INFO] [stderr] 202 | |             &mut Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr] 203 | |             _ => {}
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 201 |         match *self {
[INFO] [stderr] 202 |             Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:66:12
[INFO] [stderr]    |
[INFO] [stderr] 66 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 | /         match HELP_RE.captures(line) {
[INFO] [stderr] 70 | |             Some(ref caps) => {
[INFO] [stderr] 71 | |                 return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 72 | |                     (Some(ref metric_name), Some(ref doc)) => LineInfo::Doc {
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |             None => {}
[INFO] [stderr] 80 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if let Some(ref caps) = HELP_RE.captures(line) {
[INFO] [stderr] 70 |     return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 71 |         (Some(ref metric_name), Some(ref doc)) => LineInfo::Doc {
[INFO] [stderr] 72 |             metric_name: metric_name.as_str(),
[INFO] [stderr] 73 |             doc: doc.as_str(),
[INFO] [stderr] 74 |         },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match TYPE_RE.captures(line) {
[INFO] [stderr] 82 | |             Some(ref caps) => {
[INFO] [stderr] 83 | |                 return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 84 | |                     (Some(ref metric_name), Some(ref sample_type)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             None => {}
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 |         if let Some(ref caps) = TYPE_RE.captures(line) {
[INFO] [stderr] 82 |     return match (caps.get(1), caps.get(2)) {
[INFO] [stderr] 83 |         (Some(ref metric_name), Some(ref sample_type)) => {
[INFO] [stderr] 84 |             let sample_type = SampleType::parse(sample_type.as_str());
[INFO] [stderr] 85 |             LineInfo::Type {
[INFO] [stderr] 86 |                 metric_name: match sample_type {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/lib.rs:109:33
[INFO] [stderr]     |
[INFO] [stderr] 109 |                         labels: labels.map_or(None, |c| Some(c.as_str())),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `labels.and_then(|c| Some(c.as_str()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/lib.rs:111:36
[INFO] [stderr]     |
[INFO] [stderr] 111 |                         timestamp: timestamp.map_or(None, |c| Some(c.as_str())),
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `timestamp.and_then(|c| Some(c.as_str()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:130:31
[INFO] [stderr]     |
[INFO] [stderr] 130 |     if let Some(kv) = s.split(",").next() {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:131:31
[INFO] [stderr]     |
[INFO] [stderr] 131 |         let kvpair = kv.split("=").collect::<Vec<_>>();
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:167:27
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for kv in s.split(",") {
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:168:35
[INFO] [stderr]     |
[INFO] [stderr] 168 |             let kvpair = kv.split("=").collect::<Vec<_>>();
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:169:37
[INFO] [stderr]     |
[INFO] [stderr] 169 |             if kvpair.len() != 2 || kvpair[0].len() == 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `kvpair[0].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:195:9
[INFO] [stderr]     |
[INFO] [stderr] 195 | /         match self {
[INFO] [stderr] 196 | |             &mut Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr] 197 | |             _ => {}
[INFO] [stderr] 198 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let &mut Value::Histogram(ref mut hs) = self { hs.push(h) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:195:9
[INFO] [stderr]     |
[INFO] [stderr] 195 | /         match self {
[INFO] [stderr] 196 | |             &mut Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr] 197 | |             _ => {}
[INFO] [stderr] 198 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 195 |         match *self {
[INFO] [stderr] 196 |             Value::Histogram(ref mut hs) => hs.push(h),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         match self {
[INFO] [stderr] 202 | |             &mut Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr] 203 | |             _ => {}
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let &mut Value::Summary(ref mut ss) = self { ss.push(s) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         match self {
[INFO] [stderr] 202 | |             &mut Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr] 203 | |             _ => {}
[INFO] [stderr] 204 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 201 |         match *self {
[INFO] [stderr] 202 |             Value::Summary(ref mut ss) => ss.push(s),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:495:48
[INFO] [stderr]     |
[INFO] [stderr] 495 |         fn assert_match_sample<'a, F>(samples: &'a Vec<Sample>, f: F) -> &'a Sample
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^ help: change this to: `&[Sample]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/lib.rs:499:13
[INFO] [stderr]     |
[INFO] [stderr] 499 |             samples.iter().filter(f).next().as_ref().unwrap()
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(f).next()` with `find(f)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.90s
[INFO] running `"docker" "inspect" "5ae4d42ab6d3102c1ca0a93c88cb826f477ee48f15210d5eaa7b99ab2f1fdd9c"`
[INFO] running `"docker" "rm" "-f" "5ae4d42ab6d3102c1ca0a93c88cb826f477ee48f15210d5eaa7b99ab2f1fdd9c"`
[INFO] [stdout] 5ae4d42ab6d3102c1ca0a93c88cb826f477ee48f15210d5eaa7b99ab2f1fdd9c