[INFO] crate projekt 0.1.0 is already in cache [INFO] extracting crate projekt 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/projekt/0.1.0 [INFO] extracting crate projekt 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/projekt/0.1.0 [INFO] validating manifest of projekt-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of projekt-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing projekt-0.1.0 [INFO] finished frobbing projekt-0.1.0 [INFO] frobbed toml for projekt-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/projekt/0.1.0/Cargo.toml [INFO] started frobbing projekt-0.1.0 [INFO] finished frobbing projekt-0.1.0 [INFO] frobbed toml for projekt-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/projekt/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting projekt-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/projekt/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5145ae690d1247b0126b1894b088b9b6320bcfe3f7f4b29b466023455fa52f4 [INFO] running `"docker" "start" "-a" "e5145ae690d1247b0126b1894b088b9b6320bcfe3f7f4b29b466023455fa52f4"` [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking projekt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | ips: ips, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ips` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | scantype: scantype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `scantype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp_scans.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp_scan.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | ips: ips, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ips` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | scantype: scantype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `scantype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp_scans.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp_scan.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | ipv4 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | let ipv4 = Ipv4Addr::new(vals[0].to_string().parse::().unwrap(), [INFO] [stderr] | ________________^ [INFO] [stderr] 64 | | vals[1].to_string().parse::().unwrap(), [INFO] [stderr] 65 | | vals[2].to_string().parse::().unwrap(), [INFO] [stderr] 66 | | vals[3].to_string().parse::().unwrap()); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | matches [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | let matches = App::new("Rust Network Scanner") [INFO] [stderr] | ___________________^ [INFO] [stderr] 138 | | .version("1.0") [INFO] [stderr] 139 | | .author("Vincent G. ") [INFO] [stderr] 140 | | .about(" [INFO] [stderr] ... | [INFO] [stderr] 191 | | .takes_value(true)) [INFO] [stderr] 192 | | .get_matches(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | let addr = ip.to_string() + ":" + &port.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | return scantype [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `scantype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | clone [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | let clone = ScanResult { [INFO] [stderr] | _____________________^ [INFO] [stderr] 28 | | ports: self.ports.clone(), [INFO] [stderr] 29 | | scantype: self.scantype.clone(), [INFO] [stderr] 30 | | ip: self.ip.clone(), [INFO] [stderr] 31 | | is_up: self.is_up.clone(), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | clone [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let clone = ScanConfig { [INFO] [stderr] | _____________________^ [INFO] [stderr] 46 | | ips: self.ips.clone(), [INFO] [stderr] 47 | | start_port: self.start_port.clone(), [INFO] [stderr] 48 | | end_port: self.end_port.clone(), [INFO] [stderr] 49 | | scantype: self.scantype, [INFO] [stderr] 50 | | to_file: self.to_file.clone(), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | ipv4 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | let ipv4 = Ipv4Addr::new(vals[0].to_string().parse::().unwrap(), [INFO] [stderr] | ________________^ [INFO] [stderr] 64 | | vals[1].to_string().parse::().unwrap(), [INFO] [stderr] 65 | | vals[2].to_string().parse::().unwrap(), [INFO] [stderr] 66 | | vals[3].to_string().parse::().unwrap()); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | matches [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | let matches = App::new("Rust Network Scanner") [INFO] [stderr] | ___________________^ [INFO] [stderr] 138 | | .version("1.0") [INFO] [stderr] 139 | | .author("Vincent G. ") [INFO] [stderr] 140 | | .about(" [INFO] [stderr] ... | [INFO] [stderr] 191 | | .takes_value(true)) [INFO] [stderr] 192 | | .get_matches(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utility.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utility.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | let addr = ip.to_string() + ":" + &port.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | return scantype [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `scantype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | clone [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | let clone = ScanResult { [INFO] [stderr] | _____________________^ [INFO] [stderr] 28 | | ports: self.ports.clone(), [INFO] [stderr] 29 | | scantype: self.scantype.clone(), [INFO] [stderr] 30 | | ip: self.ip.clone(), [INFO] [stderr] 31 | | is_up: self.is_up.clone(), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | clone [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let clone = ScanConfig { [INFO] [stderr] | _____________________^ [INFO] [stderr] 46 | | ips: self.ips.clone(), [INFO] [stderr] 47 | | start_port: self.start_port.clone(), [INFO] [stderr] 48 | | end_port: self.end_port.clone(), [INFO] [stderr] 49 | | scantype: self.scantype, [INFO] [stderr] 50 | | to_file: self.to_file.clone(), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `port_beginn` is never read [INFO] [stderr] --> src/utility.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let mut port_beginn: u16 = 999; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `port_end` is never read [INFO] [stderr] --> src/utility.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let mut port_end: u16 = 999; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `path` is never read [INFO] [stderr] --> src/utility.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let mut path = "".to_string(); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut output = "".to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let mut vals = ip.split(".").collect::>(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let mut ipv4 = string_to_ipv4(ip); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/icmp_scan.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let mut req_packet = MutableEchoRequestPacket::new(&mut req_buffer).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/icmp_scan.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let mut req_packet = configure_icmp_packet(req_packet); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `port_beginn` is never read [INFO] [stderr] --> src/utility.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let mut port_beginn: u16 = 999; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `port_end` is never read [INFO] [stderr] --> src/utility.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let mut port_end: u16 = 999; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `path` is never read [INFO] [stderr] --> src/utility.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let mut path = "".to_string(); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut output = "".to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let mut vals = ip.split(".").collect::>(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let mut ipv4 = string_to_ipv4(ip); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/icmp_scan.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let mut req_packet = MutableEchoRequestPacket::new(&mut req_buffer).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/icmp_scan.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let mut req_packet = configure_icmp_packet(req_packet); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utility.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if portmap.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `portmap.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utility.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | output += &format!("Host is up!\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Host is up!\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utility.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | output += &format!("Host is down!\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Host is down!\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/utility.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | output += &format!("Port {} | {:?} open.\n",port.to_string(),portmap.get(&(port as u64)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&portmap[&(port as u64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utility.rs:37:91 [INFO] [stderr] | [INFO] [stderr] 37 | output += &format!("Port {} | {:?} open.\n",port.to_string(),portmap.get(&(port as u64)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(port)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let mut vals = ip.split(".").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/utility.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | file.write( data.as_bytes()).expect("error while writing to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utility.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | if arguments.is_present("IP") == false && arguments.is_present("IP_FILE") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!arguments.is_present("IP")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utility.rs:86:47 [INFO] [stderr] | [INFO] [stderr] 86 | if arguments.is_present("IP") == false && arguments.is_present("IP_FILE") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!arguments.is_present("IP_FILE")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | if !ports.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:206:40 [INFO] [stderr] | [INFO] [stderr] 206 | let res: Vec = ports.split("-").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/icmp_scan.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | fn icmp_scan(dest_ip: &Ipv4Addr) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/icmp_scan.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / loop { [INFO] [stderr] 40 | | let (rx_packet, addr) = iter.next().unwrap(); [INFO] [stderr] 41 | | //println!("{:?}",rx_packet); [INFO] [stderr] 42 | | if addr == *dest_ip && rx_packet.get_icmp_type() == icmp::IcmpType(0) { [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/iana_mapping.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | let http = map.get(&port).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&port]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utility.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if portmap.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `portmap.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utility.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | output += &format!("Host is up!\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Host is up!\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utility.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | output += &format!("Host is down!\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Host is down!\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/utility.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | output += &format!("Port {} | {:?} open.\n",port.to_string(),portmap.get(&(port as u64)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&portmap[&(port as u64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utility.rs:37:91 [INFO] [stderr] | [INFO] [stderr] 37 | output += &format!("Port {} | {:?} open.\n",port.to_string(),portmap.get(&(port as u64)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(port)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let mut vals = ip.split(".").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/utility.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | file.write( data.as_bytes()).expect("error while writing to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utility.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | if arguments.is_present("IP") == false && arguments.is_present("IP_FILE") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!arguments.is_present("IP")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utility.rs:86:47 [INFO] [stderr] | [INFO] [stderr] 86 | if arguments.is_present("IP") == false && arguments.is_present("IP_FILE") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!arguments.is_present("IP_FILE")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | if !ports.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utility.rs:206:40 [INFO] [stderr] | [INFO] [stderr] 206 | let res: Vec = ports.split("-").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/icmp_scan.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | fn icmp_scan(dest_ip: &Ipv4Addr) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/icmp_scan.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / loop { [INFO] [stderr] 40 | | let (rx_packet, addr) = iter.next().unwrap(); [INFO] [stderr] 41 | | //println!("{:?}",rx_packet); [INFO] [stderr] 42 | | if addr == *dest_ip && rx_packet.get_icmp_type() == icmp::IcmpType(0) { [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | scantype: self.scantype.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scantype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | ip: self.ip.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | is_up: self.is_up.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | start_port: self.start_port.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | end_port: self.end_port.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.end_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `projekt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | scantype: self.scantype.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scantype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | ip: self.ip.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | is_up: self.is_up.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.is_up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | start_port: self.start_port.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | end_port: self.end_port.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.end_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `projekt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e5145ae690d1247b0126b1894b088b9b6320bcfe3f7f4b29b466023455fa52f4"` [INFO] running `"docker" "rm" "-f" "e5145ae690d1247b0126b1894b088b9b6320bcfe3f7f4b29b466023455fa52f4"` [INFO] [stdout] e5145ae690d1247b0126b1894b088b9b6320bcfe3f7f4b29b466023455fa52f4