[INFO] crate projector 0.3.0 is already in cache [INFO] extracting crate projector 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/projector/0.3.0 [INFO] extracting crate projector 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/projector/0.3.0 [INFO] validating manifest of projector-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of projector-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing projector-0.3.0 [INFO] finished frobbing projector-0.3.0 [INFO] frobbed toml for projector-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/projector/0.3.0/Cargo.toml [INFO] started frobbing projector-0.3.0 [INFO] finished frobbing projector-0.3.0 [INFO] frobbed toml for projector-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/projector/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting projector-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/projector/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01436f5697c8597456b492c47c673fd10d50c80ea99d4eb236992dbce9d2b809 [INFO] running `"docker" "start" "-a" "01436f5697c8597456b492c47c673fd10d50c80ea99d4eb236992dbce9d2b809"` [INFO] [stderr] Checking projector v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projects.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | code_dirs: code_dirs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_dirs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projects.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | code_dirs: code_dirs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_dirs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/projects.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/projects.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/projects.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | exclude = Regex::new("^$").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::is_empty` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/projects.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | include = Regex::new("^$").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::is_empty` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/projects.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | exclude = Regex::new("^$").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::is_empty` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/projects.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | include = Regex::new("^$").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::is_empty` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | } else if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let homedir = home_dir().unwrap_or(PathBuf::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `home_dir().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(_) = matches.subcommand_matches("list") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 132 | | list(config); [INFO] [stderr] 133 | | } else if let Some(args) = matches.subcommand_matches("run") { [INFO] [stderr] 134 | | let argv: Vec<&str> = args.values_of("ARGV").unwrap().collect(); [INFO] [stderr] ... | [INFO] [stderr] 138 | | println!("ERROR: Unknown command."); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("list").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | } else if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let homedir = home_dir().unwrap_or(PathBuf::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `home_dir().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(_) = matches.subcommand_matches("list") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 132 | | list(config); [INFO] [stderr] 133 | | } else if let Some(args) = matches.subcommand_matches("run") { [INFO] [stderr] 134 | | let argv: Vec<&str> = args.values_of("ARGV").unwrap().collect(); [INFO] [stderr] ... | [INFO] [stderr] 138 | | println!("ERROR: Unknown command."); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("list").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.45s [INFO] running `"docker" "inspect" "01436f5697c8597456b492c47c673fd10d50c80ea99d4eb236992dbce9d2b809"` [INFO] running `"docker" "rm" "-f" "01436f5697c8597456b492c47c673fd10d50c80ea99d4eb236992dbce9d2b809"` [INFO] [stdout] 01436f5697c8597456b492c47c673fd10d50c80ea99d4eb236992dbce9d2b809