[INFO] crate proguard 1.1.0 is already in cache [INFO] extracting crate proguard 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/proguard/1.1.0 [INFO] extracting crate proguard 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proguard/1.1.0 [INFO] validating manifest of proguard-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of proguard-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing proguard-1.1.0 [INFO] finished frobbing proguard-1.1.0 [INFO] frobbed toml for proguard-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/proguard/1.1.0/Cargo.toml [INFO] started frobbing proguard-1.1.0 [INFO] finished frobbing proguard-1.1.0 [INFO] frobbed toml for proguard-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proguard/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting proguard-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/proguard/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f24a9fa8020c80da90cf2828f569755e53b040086db6bd2f9d86ff88453a1c66 [INFO] running `"docker" "start" "-a" "f24a9fa8020c80da90cf2828f569755e53b040086db6bd2f9d86ff88453a1c66"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking proguard v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/parser.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / self.members() [INFO] [stderr] 129 | | .filter(|x| !x.is_method() && x.alias() == alias) [INFO] [stderr] 130 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| !x.is_method() && x.alias() == alias).next()` with `find(|x| !x.is_method() && x.alias() == alias)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn members<'this>(&'this self) -> MemberIter<'this> { [INFO] [stderr] 149 | | let iter = MEMBER_RE.captures_iter(self.buf).peekable(); [INFO] [stderr] 150 | | MemberIter { [INFO] [stderr] 151 | | iter: iter, [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn classes<'this>(&'this self) -> ClassIter<'this> { [INFO] [stderr] 310 | | let buf = self.buffer(); [INFO] [stderr] 311 | | let iter = CLASS_LINE_RE.captures_iter(buf).peekable(); [INFO] [stderr] 312 | | ClassIter { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | (min(self.first_line() as i64, self.last_line() as i64) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.first_line())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:364:40 [INFO] [stderr] | [INFO] [stderr] 364 | (min(self.first_line() as i64, self.last_line() as i64) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.last_line())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:365:10 [INFO] [stderr] | [INFO] [stderr] 365 | (lineno.unwrap_or(0) as i64)).abs() as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(lineno.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/parser.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / self.members() [INFO] [stderr] 129 | | .filter(|x| !x.is_method() && x.alias() == alias) [INFO] [stderr] 130 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| !x.is_method() && x.alias() == alias).next()` with `find(|x| !x.is_method() && x.alias() == alias)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn members<'this>(&'this self) -> MemberIter<'this> { [INFO] [stderr] 149 | | let iter = MEMBER_RE.captures_iter(self.buf).peekable(); [INFO] [stderr] 150 | | MemberIter { [INFO] [stderr] 151 | | iter: iter, [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn classes<'this>(&'this self) -> ClassIter<'this> { [INFO] [stderr] 310 | | let buf = self.buffer(); [INFO] [stderr] 311 | | let iter = CLASS_LINE_RE.captures_iter(buf).peekable(); [INFO] [stderr] 312 | | ClassIter { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | (min(self.first_line() as i64, self.last_line() as i64) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.first_line())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:364:40 [INFO] [stderr] | [INFO] [stderr] 364 | (min(self.first_line() as i64, self.last_line() as i64) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.last_line())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:365:10 [INFO] [stderr] | [INFO] [stderr] 365 | (lineno.unwrap_or(0) as i64)).abs() as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(lineno.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/basic.rs:153:15 [INFO] [stderr] | [INFO] [stderr] 153 | let mem = (&mut mem_iter).filter(|x| x.args().is_some()).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.args().is_some()).next()` with `find(|x| x.args().is_some())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.89s [INFO] running `"docker" "inspect" "f24a9fa8020c80da90cf2828f569755e53b040086db6bd2f9d86ff88453a1c66"` [INFO] running `"docker" "rm" "-f" "f24a9fa8020c80da90cf2828f569755e53b040086db6bd2f9d86ff88453a1c66"` [INFO] [stdout] f24a9fa8020c80da90cf2828f569755e53b040086db6bd2f9d86ff88453a1c66