[INFO] crate procset 0.1.2 is already in cache [INFO] extracting crate procset 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/procset/0.1.2 [INFO] extracting crate procset 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/procset/0.1.2 [INFO] validating manifest of procset-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of procset-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing procset-0.1.2 [INFO] finished frobbing procset-0.1.2 [INFO] frobbed toml for procset-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/procset/0.1.2/Cargo.toml [INFO] started frobbing procset-0.1.2 [INFO] finished frobbing procset-0.1.2 [INFO] frobbed toml for procset-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/procset/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting procset-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/procset/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 763ba70984ed27e9a9c59e0daecb0eaaefe4b6510858ab0a225a77a0fff726e4 [INFO] running `"docker" "start" "-a" "763ba70984ed27e9a9c59e0daecb0eaaefe4b6510858ab0a225a77a0fff726e4"` [INFO] [stderr] Checking procset v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/libinterval_set/interval_set.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let mut iter = self.split_whitespace(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libinterval_set/interval_set.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | if interval.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libinterval_set/interval_set.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | / pub fn iter<'a>(&'a self) -> IntervalSetIterator<'a> { [INFO] [stderr] 358 | | IntervalSetIterator { [INFO] [stderr] 359 | | inner: self, [INFO] [stderr] 360 | | pos: 0, [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/libinterval_set/interval_set.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let mut iter = self.split_whitespace(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libinterval_set/interval_set.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | if interval.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libinterval_set/interval_set.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | / pub fn iter<'a>(&'a self) -> IntervalSetIterator<'a> { [INFO] [stderr] 358 | | IntervalSetIterator { [INFO] [stderr] 359 | | inner: self, [INFO] [stderr] 360 | | pos: 0, [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "763ba70984ed27e9a9c59e0daecb0eaaefe4b6510858ab0a225a77a0fff726e4"` [INFO] running `"docker" "rm" "-f" "763ba70984ed27e9a9c59e0daecb0eaaefe4b6510858ab0a225a77a0fff726e4"` [INFO] [stdout] 763ba70984ed27e9a9c59e0daecb0eaaefe4b6510858ab0a225a77a0fff726e4