[INFO] crate processors 0.2.1 is already in cache [INFO] extracting crate processors 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/processors/0.2.1 [INFO] extracting crate processors 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/processors/0.2.1 [INFO] validating manifest of processors-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of processors-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing processors-0.2.1 [INFO] finished frobbing processors-0.2.1 [INFO] frobbed toml for processors-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/processors/0.2.1/Cargo.toml [INFO] started frobbing processors-0.2.1 [INFO] finished frobbing processors-0.2.1 [INFO] frobbed toml for processors-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/processors/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting processors-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/processors/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b1761bb4c0487d85914f6d8474e7ffe8bc7874dd28f051ef8730646aa19f297 [INFO] running `"docker" "start" "-a" "6b1761bb4c0487d85914f6d8474e7ffe8bc7874dd28f051ef8730646aa19f297"` [INFO] [stderr] Checking sample v0.9.1 [INFO] [stderr] Checking pcm-flow v0.5.0 [INFO] [stderr] Checking processors v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inputs: inputs [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/oscillators.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | table: table [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inputs: inputs [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/oscillators.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | table: table [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::AnalogClip` [INFO] [stderr] --> src/distortion.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | AnalogClip { } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::DigitalClip` [INFO] [stderr] --> src/distortion.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Self { [INFO] [stderr] 56 | | DigitalClip { } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::HardCurve` [INFO] [stderr] --> src/distortion.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Self { [INFO] [stderr] 81 | | HardCurve { } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::SawWave` [INFO] [stderr] --> src/distortion.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | SawWave { } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::TriangleWave` [INFO] [stderr] --> src/distortion.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> Self { [INFO] [stderr] 150 | | TriangleWave { } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::PulseWave` [INFO] [stderr] --> src/distortion.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new() -> Self { [INFO] [stderr] 176 | | PulseWave { } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `inputs`. [INFO] [stderr] --> src/utils.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 1..self.inputs { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in inputs.iter().take(self.inputs).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::Invert` [INFO] [stderr] --> src/utils.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Invert { } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Saw` [INFO] [stderr] --> src/oscillators.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> Self { [INFO] [stderr] 85 | | Saw { [INFO] [stderr] 86 | | phase: 0.0, [INFO] [stderr] 87 | | samplerate: 1 [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Tri` [INFO] [stderr] --> src/oscillators.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn new() -> Self { [INFO] [stderr] 128 | | Tri { [INFO] [stderr] 129 | | phase: 0.0, [INFO] [stderr] 130 | | samplerate: 1 [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Square` [INFO] [stderr] --> src/oscillators.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / pub fn new() -> Self { [INFO] [stderr] 171 | | Square { [INFO] [stderr] 172 | | phase: 0.0, [INFO] [stderr] 173 | | samplerate: 1 [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / mod tests { [INFO] [stderr] 3 | | extern crate pcm_flow; [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | use super::super::oscillators::Sine; [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::AnalogClip` [INFO] [stderr] --> src/distortion.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | AnalogClip { } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::DigitalClip` [INFO] [stderr] --> src/distortion.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Self { [INFO] [stderr] 56 | | DigitalClip { } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::HardCurve` [INFO] [stderr] --> src/distortion.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Self { [INFO] [stderr] 81 | | HardCurve { } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::SawWave` [INFO] [stderr] --> src/distortion.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | SawWave { } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::TriangleWave` [INFO] [stderr] --> src/distortion.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> Self { [INFO] [stderr] 150 | | TriangleWave { } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `distortion::PulseWave` [INFO] [stderr] --> src/distortion.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new() -> Self { [INFO] [stderr] 176 | | PulseWave { } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `inputs`. [INFO] [stderr] --> src/utils.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 1..self.inputs { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in inputs.iter().take(self.inputs).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::Invert` [INFO] [stderr] --> src/utils.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Invert { } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Saw` [INFO] [stderr] --> src/oscillators.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> Self { [INFO] [stderr] 85 | | Saw { [INFO] [stderr] 86 | | phase: 0.0, [INFO] [stderr] 87 | | samplerate: 1 [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Tri` [INFO] [stderr] --> src/oscillators.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn new() -> Self { [INFO] [stderr] 128 | | Tri { [INFO] [stderr] 129 | | phase: 0.0, [INFO] [stderr] 130 | | samplerate: 1 [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `oscillators::Square` [INFO] [stderr] --> src/oscillators.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / pub fn new() -> Self { [INFO] [stderr] 171 | | Square { [INFO] [stderr] 172 | | phase: 0.0, [INFO] [stderr] 173 | | samplerate: 1 [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.24s [INFO] running `"docker" "inspect" "6b1761bb4c0487d85914f6d8474e7ffe8bc7874dd28f051ef8730646aa19f297"` [INFO] running `"docker" "rm" "-f" "6b1761bb4c0487d85914f6d8474e7ffe8bc7874dd28f051ef8730646aa19f297"` [INFO] [stdout] 6b1761bb4c0487d85914f6d8474e7ffe8bc7874dd28f051ef8730646aa19f297