[INFO] crate process_lock 0.1.0 is already in cache [INFO] extracting crate process_lock 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/process_lock/0.1.0 [INFO] extracting crate process_lock 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/process_lock/0.1.0 [INFO] validating manifest of process_lock-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of process_lock-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing process_lock-0.1.0 [INFO] finished frobbing process_lock-0.1.0 [INFO] frobbed toml for process_lock-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/process_lock/0.1.0/Cargo.toml [INFO] started frobbing process_lock-0.1.0 [INFO] finished frobbing process_lock-0.1.0 [INFO] frobbed toml for process_lock-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/process_lock/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting process_lock-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/process_lock/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e204892e5937341d1b02a40bd39ffe548a9638cc7f7dd7b39b9c7a28f9bcc4e2 [INFO] running `"docker" "start" "-a" "e204892e5937341d1b02a40bd39ffe548a9638cc7f7dd7b39b9c7a28f9bcc4e2"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking process_lock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / return Ok(ProcessLock { [INFO] [stderr] 102 | | id: id, [INFO] [stderr] 103 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 101 | Ok(ProcessLock { [INFO] [stderr] 102 | id: id, [INFO] [stderr] 103 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / return Ok(ProcessLock { [INFO] [stderr] 102 | | id: id, [INFO] [stderr] 103 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 101 | Ok(ProcessLock { [INFO] [stderr] 102 | id: id, [INFO] [stderr] 103 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sys/unix/mod.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | fn hash_code(name: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | h = h.wrapping_mul(31).wrapping_add(*byte as i32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sys/unix/mod.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let path = path_name.clone().unwrap_or(String::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | cvt(libc::semctl(id, SEM_NUM as i32, Sem::SETVAL as libc::c_int, 1))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(SEM_NUM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:160:39 [INFO] [stderr] | [INFO] [stderr] 160 | cvt(libc::semctl(self.id, SEM_NUM as i32, libc::IPC_RMID))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(SEM_NUM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sys/unix/mod.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | fn hash_code(name: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | h = h.wrapping_mul(31).wrapping_add(*byte as i32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sys/unix/mod.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let path = path_name.clone().unwrap_or(String::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | cvt(libc::semctl(id, SEM_NUM as i32, Sem::SETVAL as libc::c_int, 1))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(SEM_NUM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:160:39 [INFO] [stderr] | [INFO] [stderr] 160 | cvt(libc::semctl(self.id, SEM_NUM as i32, libc::IPC_RMID))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(SEM_NUM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> examples/lock1.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> examples/lock.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/lock1.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let mut lock = ProcessLock::new(String::from(".xxx1"), None).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.06s [INFO] running `"docker" "inspect" "e204892e5937341d1b02a40bd39ffe548a9638cc7f7dd7b39b9c7a28f9bcc4e2"` [INFO] running `"docker" "rm" "-f" "e204892e5937341d1b02a40bd39ffe548a9638cc7f7dd7b39b9c7a28f9bcc4e2"` [INFO] [stdout] e204892e5937341d1b02a40bd39ffe548a9638cc7f7dd7b39b9c7a28f9bcc4e2