[INFO] crate process-iterator 0.2.0 is already in cache
[INFO] extracting crate process-iterator 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/process-iterator/0.2.0
[INFO] extracting crate process-iterator 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/process-iterator/0.2.0
[INFO] validating manifest of process-iterator-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of process-iterator-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing process-iterator-0.2.0
[INFO] finished frobbing process-iterator-0.2.0
[INFO] frobbed toml for process-iterator-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/process-iterator/0.2.0/Cargo.toml
[INFO] started frobbing process-iterator-0.2.0
[INFO] finished frobbing process-iterator-0.2.0
[INFO] frobbed toml for process-iterator-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/process-iterator/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting process-iterator-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/process-iterator/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b569f0056a6476aca8f4a213c4197022bd8b2e9dab5185958bd864f7ded89d23
[INFO] running `"docker" "start" "-a" "b569f0056a6476aca8f4a213c4197022bd8b2e9dab5185958bd864f7ded89d23"`
[INFO] [stderr]     Checking process-iterator v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:306:5
[INFO] [stderr]     |
[INFO] [stderr] 306 |     return cmd
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `cmd`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |       if let Some(_) = stdin_opt {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 116 | |         cmd.stdin(Stdio::piped());
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____- help: try this: `if stdin_opt.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:252:5
[INFO] [stderr]     |
[INFO] [stderr] 252 | /     match deal_with_stderr {
[INFO] [stderr] 253 | |       &Output::Parent => {}
[INFO] [stderr] 254 | |       &Output::Ignore => {
[INFO] [stderr] 255 | |           cmd.stderr(Stdio::null());
[INFO] [stderr] ...   |
[INFO] [stderr] 269 | |       */
[INFO] [stderr] 270 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 252 |     match *deal_with_stderr {
[INFO] [stderr] 253 |       Output::Parent => {}
[INFO] [stderr] 254 |       Output::Ignore => {
[INFO] [stderr] 255 |           cmd.stderr(Stdio::null());
[INFO] [stderr] 256 |       }
[INFO] [stderr] 257 |       Output::ToFd(ref file) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:277:5
[INFO] [stderr]     |
[INFO] [stderr] 277 | /     match deal_with_stdout {
[INFO] [stderr] 278 | |       &Output::Parent => {}
[INFO] [stderr] 279 | |       &Output::Ignore => {
[INFO] [stderr] 280 | |           cmd.stdout(Stdio::null());
[INFO] [stderr] ...   |
[INFO] [stderr] 294 | |       */
[INFO] [stderr] 295 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 277 |     match *deal_with_stdout {
[INFO] [stderr] 278 |       Output::Parent => {}
[INFO] [stderr] 279 |       Output::Ignore => {
[INFO] [stderr] 280 |           cmd.stdout(Stdio::null());
[INFO] [stderr] 281 |       }
[INFO] [stderr] 282 |       Output::ToFd(ref file) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:306:5
[INFO] [stderr]     |
[INFO] [stderr] 306 |     return cmd
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `cmd`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |       if let Some(_) = stdin_opt {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 116 | |         cmd.stdin(Stdio::piped());
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____- help: try this: `if stdin_opt.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:252:5
[INFO] [stderr]     |
[INFO] [stderr] 252 | /     match deal_with_stderr {
[INFO] [stderr] 253 | |       &Output::Parent => {}
[INFO] [stderr] 254 | |       &Output::Ignore => {
[INFO] [stderr] 255 | |           cmd.stderr(Stdio::null());
[INFO] [stderr] ...   |
[INFO] [stderr] 269 | |       */
[INFO] [stderr] 270 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 252 |     match *deal_with_stderr {
[INFO] [stderr] 253 |       Output::Parent => {}
[INFO] [stderr] 254 |       Output::Ignore => {
[INFO] [stderr] 255 |           cmd.stderr(Stdio::null());
[INFO] [stderr] 256 |       }
[INFO] [stderr] 257 |       Output::ToFd(ref file) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:277:5
[INFO] [stderr]     |
[INFO] [stderr] 277 | /     match deal_with_stdout {
[INFO] [stderr] 278 | |       &Output::Parent => {}
[INFO] [stderr] 279 | |       &Output::Ignore => {
[INFO] [stderr] 280 | |           cmd.stdout(Stdio::null());
[INFO] [stderr] ...   |
[INFO] [stderr] 294 | |       */
[INFO] [stderr] 295 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 277 |     match *deal_with_stdout {
[INFO] [stderr] 278 |       Output::Parent => {}
[INFO] [stderr] 279 |       Output::Ignore => {
[INFO] [stderr] 280 |           cmd.stdout(Stdio::null());
[INFO] [stderr] 281 |       }
[INFO] [stderr] 282 |       Output::ToFd(ref file) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> tests/integration.rs:44:30
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn sort_cmd(columns: &Vec<(i32, &str)>) -> (String, Vec<String>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, &str)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.33s
[INFO] running `"docker" "inspect" "b569f0056a6476aca8f4a213c4197022bd8b2e9dab5185958bd864f7ded89d23"`
[INFO] running `"docker" "rm" "-f" "b569f0056a6476aca8f4a213c4197022bd8b2e9dab5185958bd864f7ded89d23"`
[INFO] [stdout] b569f0056a6476aca8f4a213c4197022bd8b2e9dab5185958bd864f7ded89d23