[INFO] crate proc-reader 0.4.0 is already in cache [INFO] extracting crate proc-reader 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/proc-reader/0.4.0 [INFO] extracting crate proc-reader 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proc-reader/0.4.0 [INFO] validating manifest of proc-reader-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of proc-reader-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing proc-reader-0.4.0 [INFO] finished frobbing proc-reader-0.4.0 [INFO] frobbed toml for proc-reader-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/proc-reader/0.4.0/Cargo.toml [INFO] started frobbing proc-reader-0.4.0 [INFO] finished frobbing proc-reader-0.4.0 [INFO] frobbed toml for proc-reader-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/proc-reader/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting proc-reader-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/proc-reader/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7be48534d73515afe0bef69d799dbb0bb103cfb897763b44f205077b72b17c37 [INFO] running `"docker" "start" "-a" "7be48534d73515afe0bef69d799dbb0bb103cfb897763b44f205077b72b17c37"` [INFO] [stderr] Compiling proc-reader v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:443:9 [INFO] [stderr] | [INFO] [stderr] 443 | / if regs.syscall() == libc::SYS_fcntl as Word { [INFO] [stderr] 444 | | if regs.arg2() == libc::F_DUPFD as Word { [INFO] [stderr] 445 | | let src = regs.arg1(); [INFO] [stderr] 446 | | let dst = regs.ret(); [INFO] [stderr] 447 | | fd[dst as usize] = fd[src as usize]; [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | if regs.syscall() == libc::SYS_fcntl as Word && regs.arg2() == libc::F_DUPFD as Word { [INFO] [stderr] 444 | let src = regs.arg1(); [INFO] [stderr] 445 | let dst = regs.ret(); [INFO] [stderr] 446 | fd[dst as usize] = fd[src as usize]; [INFO] [stderr] 447 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | move || match ProcReader::collect(pid, typ, ctl_rx, buf_tx) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 266 | | Err(x) => { [INFO] [stderr] 267 | | let _ = err_tx.send(x); [INFO] [stderr] 268 | | } [INFO] [stderr] 269 | | _ => (), [INFO] [stderr] 270 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 265 | move || if let Err(x) = ProcReader::collect(pid, typ, ctl_rx, buf_tx) { [INFO] [stderr] 266 | let _ = err_tx.send(x); [INFO] [stderr] 267 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | fds.push(fd.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | fds.push(fd.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | / loop { [INFO] [stderr] 462 | | match self.buf.try_recv() { [INFO] [stderr] 463 | | Ok(mut x) => self.rest.append(&mut x), [INFO] [stderr] 464 | | Err(_) => break, [INFO] [stderr] 465 | | } [INFO] [stderr] 466 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(mut x) = self.buf.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:443:9 [INFO] [stderr] | [INFO] [stderr] 443 | / if regs.syscall() == libc::SYS_fcntl as Word { [INFO] [stderr] 444 | | if regs.arg2() == libc::F_DUPFD as Word { [INFO] [stderr] 445 | | let src = regs.arg1(); [INFO] [stderr] 446 | | let dst = regs.ret(); [INFO] [stderr] 447 | | fd[dst as usize] = fd[src as usize]; [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | if regs.syscall() == libc::SYS_fcntl as Word && regs.arg2() == libc::F_DUPFD as Word { [INFO] [stderr] 444 | let src = regs.arg1(); [INFO] [stderr] 445 | let dst = regs.ret(); [INFO] [stderr] 446 | fd[dst as usize] = fd[src as usize]; [INFO] [stderr] 447 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | move || match ProcReader::collect(pid, typ, ctl_rx, buf_tx) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 266 | | Err(x) => { [INFO] [stderr] 267 | | let _ = err_tx.send(x); [INFO] [stderr] 268 | | } [INFO] [stderr] 269 | | _ => (), [INFO] [stderr] 270 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 265 | move || if let Err(x) = ProcReader::collect(pid, typ, ctl_rx, buf_tx) { [INFO] [stderr] 266 | let _ = err_tx.send(x); [INFO] [stderr] 267 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | fds.push(fd.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | fds.push(fd.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | / loop { [INFO] [stderr] 462 | | match self.buf.try_recv() { [INFO] [stderr] 463 | | Ok(mut x) => self.rest.append(&mut x), [INFO] [stderr] 464 | | Err(_) => break, [INFO] [stderr] 465 | | } [INFO] [stderr] 466 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(mut x) = self.buf.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.07s [INFO] running `"docker" "inspect" "7be48534d73515afe0bef69d799dbb0bb103cfb897763b44f205077b72b17c37"` [INFO] running `"docker" "rm" "-f" "7be48534d73515afe0bef69d799dbb0bb103cfb897763b44f205077b72b17c37"` [INFO] [stdout] 7be48534d73515afe0bef69d799dbb0bb103cfb897763b44f205077b72b17c37