[INFO] crate probor 0.3.1 is already in cache [INFO] extracting crate probor 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/probor/0.3.1 [INFO] extracting crate probor 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/probor/0.3.1 [INFO] validating manifest of probor-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of probor-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing probor-0.3.1 [INFO] finished frobbing probor-0.3.1 [INFO] frobbed toml for probor-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/probor/0.3.1/Cargo.toml [INFO] started frobbing probor-0.3.1 [INFO] finished frobbing probor-0.3.1 [INFO] frobbed toml for probor-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/probor/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting probor-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/probor/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ab17891c6bd4a8d7ae6a2a6a8b90f6506103d133bfb24da85ee89adf295f09b [INFO] running `"docker" "start" "-a" "9ab17891c6bd4a8d7ae6a2a6a8b90f6506103d133bfb24da85ee89adf295f09b"` [INFO] [stderr] Checking cbor-codec v0.7.1 [INFO] [stderr] Checking probor v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return enc.into_writer(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `enc.into_writer()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/util.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / if val.is_ok() { [INFO] [stderr] 19 | | if dec.into_reader().position() != src.len() as u64 { [INFO] [stderr] 20 | | return Err(DecodeError::WrongValue("trailing data")); [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | if val.is_ok() && dec.into_reader().position() != src.len() as u64 { [INFO] [stderr] 19 | return Err(DecodeError::WrongValue("trailing data")); [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return enc.into_writer(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `enc.into_writer()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/util.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / if val.is_ok() { [INFO] [stderr] 19 | | if dec.into_reader().position() != src.len() as u64 { [INFO] [stderr] 20 | | return Err(DecodeError::WrongValue("trailing data")); [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | if val.is_ok() && dec.into_reader().position() != src.len() as u64 { [INFO] [stderr] 19 | return Err(DecodeError::WrongValue("trailing data")); [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/impls.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Some(ref x) => x.encode(e), [INFO] [stderr] 21 | | &None => e.null(), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Some(ref x) => x.encode(e), [INFO] [stderr] 21 | None => e.null(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/maps.rs:10:54 [INFO] [stderr] | [INFO] [stderr] 10 | impl Decodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 10 | impl Decodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 17 | let mut res = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/maps.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | / match res.insert(k, v) { [INFO] [stderr] 23 | | Some(_) => return Err(DecodeError::DuplicateKey), [INFO] [stderr] 24 | | None => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = res.insert(k, v) { return Err(DecodeError::DuplicateKey) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/maps.rs:34:54 [INFO] [stderr] | [INFO] [stderr] 34 | impl Encodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 34 | impl Encodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 23 | | &WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 24 | | &DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] ... | [INFO] [stderr] 33 | | => write!(fmt, "Error when skipping value: {}", err), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 23 | WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 24 | DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] 25 | UnexpectedNull => write!(fmt, "null is not expected"), [INFO] [stderr] 26 | WrongType(exp, ref err) => write!(fmt, "{}: {}", exp, err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 43 | | &WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 44 | | &DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] ... | [INFO] [stderr] 53 | | => write!(fmt, "Error when skipping value: {}", err), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 43 | WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 44 | DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] 45 | UnexpectedNull => write!(fmt, "null is not expected"), [INFO] [stderr] 46 | WrongType(exp, ref err) => write!(fmt, "{}: {}", exp, err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &AbsentField(_) => "absent field", [INFO] [stderr] 63 | | &WrongArrayLength(_) => "wrong array length", [INFO] [stderr] 64 | | &DuplicateKey => "some key is duplicated", [INFO] [stderr] ... | [INFO] [stderr] 70 | | &SkippingError(_) => "error when skipping value", [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | AbsentField(_) => "absent field", [INFO] [stderr] 63 | WrongArrayLength(_) => "wrong array length", [INFO] [stderr] 64 | DuplicateKey => "some key is duplicated", [INFO] [stderr] 65 | UnexpectedNull => "unexpected null", [INFO] [stderr] 66 | WrongType(exp, _) => exp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self { [INFO] [stderr] 76 | | &AbsentField(_) => None, [INFO] [stderr] 77 | | &WrongArrayLength(_) => None, [INFO] [stderr] 78 | | &DuplicateKey => None, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &SkippingError(ref err) => Some(err), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *self { [INFO] [stderr] 76 | AbsentField(_) => None, [INFO] [stderr] 77 | WrongArrayLength(_) => None, [INFO] [stderr] 78 | DuplicateKey => None, [INFO] [stderr] 79 | UnexpectedNull => None, [INFO] [stderr] 80 | WrongType(_, ref err) => Some(err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tuples.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | let mut d = &mut Decoder::new(Config::default(), Cursor::new(&v[..])); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sequences.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let mut d = &mut Decoder::new(Config::default(), Cursor::new(&v[..])); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/maps.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut d = &mut Decoder::new(Config::default(), Cursor::new(&v[..])); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/enums.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | let mut d = &mut Decoder::new(Config::default(), Cursor::new(&v[..])); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/macros.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | let mut d = &mut Decoder::new(Config::default(), Cursor::new(vec)); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/impls.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Some(ref x) => x.encode(e), [INFO] [stderr] 21 | | &None => e.null(), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Some(ref x) => x.encode(e), [INFO] [stderr] 21 | None => e.null(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> examples/search.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / probor_struct!( [INFO] [stderr] 8 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 9 | | struct Page { [INFO] [stderr] 10 | | url: String => (#0), [INFO] [stderr] 11 | | title: String => (#1), [INFO] [stderr] 12 | | snippet: Option => (#2 optional), [INFO] [stderr] 13 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / probor_struct!( [INFO] [stderr] 8 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 9 | | struct Page { [INFO] [stderr] 10 | | url: String => (#0), [INFO] [stderr] 11 | | title: String => (#1), [INFO] [stderr] 12 | | snippet: Option => (#2 optional), [INFO] [stderr] 13 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / probor_struct!( [INFO] [stderr] 8 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 9 | | struct Page { [INFO] [stderr] 10 | | url: String => (#0), [INFO] [stderr] 11 | | title: String => (#1), [INFO] [stderr] 12 | | snippet: Option => (#2 optional), [INFO] [stderr] 13 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> examples/search.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / probor_struct!( [INFO] [stderr] 8 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 9 | | struct Page { [INFO] [stderr] 10 | | url: String => (#0), [INFO] [stderr] 11 | | title: String => (#1), [INFO] [stderr] 12 | | snippet: Option => (#2 optional), [INFO] [stderr] 13 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / probor_struct!( [INFO] [stderr] 8 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 9 | | struct Page { [INFO] [stderr] 10 | | url: String => (#0), [INFO] [stderr] 11 | | title: String => (#1), [INFO] [stderr] 12 | | snippet: Option => (#2 optional), [INFO] [stderr] 13 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> examples/search.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / probor_struct!( [INFO] [stderr] 16 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 17 | | struct SearchResults { [INFO] [stderr] 18 | | total_results: u64 => (#0), [INFO] [stderr] 19 | | results: Vec => (#1), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / probor_struct!( [INFO] [stderr] 16 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 17 | | struct SearchResults { [INFO] [stderr] 18 | | total_results: u64 => (#0), [INFO] [stderr] 19 | | results: Vec => (#1), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / probor_struct!( [INFO] [stderr] 16 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 17 | | struct SearchResults { [INFO] [stderr] 18 | | total_results: u64 => (#0), [INFO] [stderr] 19 | | results: Vec => (#1), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> examples/search.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / probor_struct!( [INFO] [stderr] 16 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 17 | | struct SearchResults { [INFO] [stderr] 18 | | total_results: u64 => (#0), [INFO] [stderr] 19 | | results: Vec => (#1), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/search.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / probor_struct!( [INFO] [stderr] 16 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 17 | | struct SearchResults { [INFO] [stderr] 18 | | total_results: u64 => (#0), [INFO] [stderr] 19 | | results: Vec => (#1), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/maps.rs:10:54 [INFO] [stderr] | [INFO] [stderr] 10 | impl Decodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 10 | impl Decodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 17 | let mut res = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/maps.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | / match res.insert(k, v) { [INFO] [stderr] 23 | | Some(_) => return Err(DecodeError::DuplicateKey), [INFO] [stderr] 24 | | None => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = res.insert(k, v) { return Err(DecodeError::DuplicateKey) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/maps.rs:34:54 [INFO] [stderr] | [INFO] [stderr] 34 | impl Encodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 34 | impl Encodable for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 23 | | &WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 24 | | &DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] ... | [INFO] [stderr] 33 | | => write!(fmt, "Error when skipping value: {}", err), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 23 | WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 24 | DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] 25 | UnexpectedNull => write!(fmt, "null is not expected"), [INFO] [stderr] 26 | WrongType(exp, ref err) => write!(fmt, "{}: {}", exp, err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 43 | | &WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 44 | | &DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] ... | [INFO] [stderr] 53 | | => write!(fmt, "Error when skipping value: {}", err), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | AbsentField(field) => write!(fmt, "absent field {:?}", field), [INFO] [stderr] 43 | WrongArrayLength(n) => write!(fmt, "wrong array length {:?}", n), [INFO] [stderr] 44 | DuplicateKey => write!(fmt, "some key is duplicated"), [INFO] [stderr] 45 | UnexpectedNull => write!(fmt, "null is not expected"), [INFO] [stderr] 46 | WrongType(exp, ref err) => write!(fmt, "{}: {}", exp, err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &AbsentField(_) => "absent field", [INFO] [stderr] 63 | | &WrongArrayLength(_) => "wrong array length", [INFO] [stderr] 64 | | &DuplicateKey => "some key is duplicated", [INFO] [stderr] ... | [INFO] [stderr] 70 | | &SkippingError(_) => "error when skipping value", [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | AbsentField(_) => "absent field", [INFO] [stderr] 63 | WrongArrayLength(_) => "wrong array length", [INFO] [stderr] 64 | DuplicateKey => "some key is duplicated", [INFO] [stderr] 65 | UnexpectedNull => "unexpected null", [INFO] [stderr] 66 | WrongType(exp, _) => exp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self { [INFO] [stderr] 76 | | &AbsentField(_) => None, [INFO] [stderr] 77 | | &WrongArrayLength(_) => None, [INFO] [stderr] 78 | | &DuplicateKey => None, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &SkippingError(ref err) => Some(err), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *self { [INFO] [stderr] 76 | AbsentField(_) => None, [INFO] [stderr] 77 | WrongArrayLength(_) => None, [INFO] [stderr] 78 | DuplicateKey => None, [INFO] [stderr] 79 | UnexpectedNull => None, [INFO] [stderr] 80 | WrongType(_, ref err) => Some(err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/enums.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | / match self { [INFO] [stderr] 126 | | $( [INFO] [stderr] 127 | | &_probor_enum_pattern!($name $variant $($fname)* ) => { [INFO] [stderr] 128 | | try!(e.array(_probor_max!( $($fnum,)* ) + 1)); [INFO] [stderr] ... | [INFO] [stderr] 137 | | )* [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/enums.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | (idx += 1, idx); // silence warnings [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/enums.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | (idx += 1, idx); // silence warnings [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/enums.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | (idx += 1, idx); // silence warnings [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/enums.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | (idx += 1, idx); // silence warnings [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/enums.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | try!($dec.skip().map_err(|e| [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 31 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/enums.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | _ => try!($dec.skip().map_err(|e| [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 51 | | $crate::DecodeError::SkippingError(e))), [INFO] [stderr] | |_________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/enums.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | _ => try!($dec.skip().map_err(|e| [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 51 | | $crate::DecodeError::SkippingError(e))), [INFO] [stderr] | |_________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] ... [INFO] [stderr] 189 | / probor_enum_encoder_decoder!(Multi { [INFO] [stderr] 190 | | #0 One(), [INFO] [stderr] 191 | | #1 Two(x #1), [INFO] [stderr] 192 | | #5 Three(x #1, y #2), [INFO] [stderr] 193 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / probor_struct!( [INFO] [stderr] 113 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 114 | | struct Page { [INFO] [stderr] 115 | | url: String => (#0), [INFO] [stderr] 116 | | title: String => (#1), [INFO] [stderr] 117 | | snippet: Option => (#2 optional), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / probor_struct!( [INFO] [stderr] 113 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 114 | | struct Page { [INFO] [stderr] 115 | | url: String => (#0), [INFO] [stderr] 116 | | title: String => (#1), [INFO] [stderr] 117 | | snippet: Option => (#2 optional), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |______________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / probor_struct!( [INFO] [stderr] 113 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 114 | | struct Page { [INFO] [stderr] 115 | | url: String => (#0), [INFO] [stderr] 116 | | title: String => (#1), [INFO] [stderr] 117 | | snippet: Option => (#2 optional), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / probor_struct!( [INFO] [stderr] 113 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 114 | | struct Page { [INFO] [stderr] 115 | | url: String => (#0), [INFO] [stderr] 116 | | title: String => (#1), [INFO] [stderr] 117 | | snippet: Option => (#2 optional), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / probor_struct!( [INFO] [stderr] 113 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 114 | | struct Page { [INFO] [stderr] 115 | | url: String => (#0), [INFO] [stderr] 116 | | title: String => (#1), [INFO] [stderr] 117 | | snippet: Option => (#2 optional), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / probor_struct!( [INFO] [stderr] 121 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 122 | | struct SearchResults { [INFO] [stderr] 123 | | total_results: u64 => (#0), [INFO] [stderr] 124 | | results: Vec => (#1), [INFO] [stderr] 125 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / probor_struct!( [INFO] [stderr] 121 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 122 | | struct SearchResults { [INFO] [stderr] 123 | | total_results: u64 => (#0), [INFO] [stderr] 124 | | results: Vec => (#1), [INFO] [stderr] 125 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / probor_struct!( [INFO] [stderr] 121 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 122 | | struct SearchResults { [INFO] [stderr] 123 | | total_results: u64 => (#0), [INFO] [stderr] 124 | | results: Vec => (#1), [INFO] [stderr] 125 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / probor_struct!( [INFO] [stderr] 121 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 122 | | struct SearchResults { [INFO] [stderr] 123 | | total_results: u64 => (#0), [INFO] [stderr] 124 | | results: Vec => (#1), [INFO] [stderr] 125 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / probor_struct!( [INFO] [stderr] 121 | | #[derive(PartialEq, Eq, Debug)] [INFO] [stderr] 122 | | struct SearchResults { [INFO] [stderr] 123 | | total_results: u64 => (#0), [INFO] [stderr] 124 | | results: Vec => (#1), [INFO] [stderr] 125 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / probor_struct!( [INFO] [stderr] 175 | | pub struct VersionInfo { [INFO] [stderr] 176 | | pub version: u8 => (), [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / probor_struct!( [INFO] [stderr] 175 | | pub struct VersionInfo { [INFO] [stderr] 176 | | pub version: u8 => (), [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / probor_struct!( [INFO] [stderr] 175 | | pub struct VersionInfo { [INFO] [stderr] 176 | | pub version: u8 => (), [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / probor_struct!( [INFO] [stderr] 175 | | pub struct VersionInfo { [INFO] [stderr] 176 | | pub version: u8 => (), [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / probor_struct!( [INFO] [stderr] 175 | | pub struct VersionInfo { [INFO] [stderr] 176 | | pub version: u8 => (), [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / probor_struct!( [INFO] [stderr] 193 | | #[derive(Debug, PartialEq)] [INFO] [stderr] 194 | | struct Three { [INFO] [stderr] 195 | | one: Option => (#0 optional), [INFO] [stderr] 196 | | two: Option => (#1 optional), [INFO] [stderr] 197 | | three: Option => (#2 optional), [INFO] [stderr] 198 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / probor_struct!( [INFO] [stderr] 193 | | #[derive(Debug, PartialEq)] [INFO] [stderr] 194 | | struct Three { [INFO] [stderr] 195 | | one: Option => (#0 optional), [INFO] [stderr] 196 | | two: Option => (#1 optional), [INFO] [stderr] 197 | | three: Option => (#2 optional), [INFO] [stderr] 198 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / probor_struct!( [INFO] [stderr] 193 | | #[derive(Debug, PartialEq)] [INFO] [stderr] 194 | | struct Three { [INFO] [stderr] 195 | | one: Option => (#0 optional), [INFO] [stderr] 196 | | two: Option => (#1 optional), [INFO] [stderr] 197 | | three: Option => (#2 optional), [INFO] [stderr] 198 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / probor_struct!( [INFO] [stderr] 193 | | #[derive(Debug, PartialEq)] [INFO] [stderr] 194 | | struct Three { [INFO] [stderr] 195 | | one: Option => (#0 optional), [INFO] [stderr] 196 | | two: Option => (#1 optional), [INFO] [stderr] 197 | | three: Option => (#2 optional), [INFO] [stderr] 198 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / probor_struct!( [INFO] [stderr] 193 | | #[derive(Debug, PartialEq)] [INFO] [stderr] 194 | | struct Three { [INFO] [stderr] 195 | | one: Option => (#0 optional), [INFO] [stderr] 196 | | two: Option => (#1 optional), [INFO] [stderr] 197 | | three: Option => (#2 optional), [INFO] [stderr] 198 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / probor_struct!( [INFO] [stderr] 201 | | struct TwoThree { [INFO] [stderr] 202 | | two: Option => (#1 optional), [INFO] [stderr] 203 | | three: Option => (#2 optional), [INFO] [stderr] 204 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / probor_struct!( [INFO] [stderr] 201 | | struct TwoThree { [INFO] [stderr] 202 | | two: Option => (#1 optional), [INFO] [stderr] 203 | | three: Option => (#2 optional), [INFO] [stderr] 204 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / probor_struct!( [INFO] [stderr] 201 | | struct TwoThree { [INFO] [stderr] 202 | | two: Option => (#1 optional), [INFO] [stderr] 203 | | three: Option => (#2 optional), [INFO] [stderr] 204 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / probor_struct!( [INFO] [stderr] 201 | | struct TwoThree { [INFO] [stderr] 202 | | two: Option => (#1 optional), [INFO] [stderr] 203 | | three: Option => (#2 optional), [INFO] [stderr] 204 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / probor_struct!( [INFO] [stderr] 201 | | struct TwoThree { [INFO] [stderr] 202 | | two: Option => (#1 optional), [INFO] [stderr] 203 | | three: Option => (#2 optional), [INFO] [stderr] 204 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / probor_struct!( [INFO] [stderr] 207 | | struct OneThree { [INFO] [stderr] 208 | | one: Option => (#0 optional), [INFO] [stderr] 209 | | three: Option => (#2 optional), [INFO] [stderr] 210 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / probor_struct!( [INFO] [stderr] 207 | | struct OneThree { [INFO] [stderr] 208 | | one: Option => (#0 optional), [INFO] [stderr] 209 | | three: Option => (#2 optional), [INFO] [stderr] 210 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / probor_struct!( [INFO] [stderr] 207 | | struct OneThree { [INFO] [stderr] 208 | | one: Option => (#0 optional), [INFO] [stderr] 209 | | three: Option => (#2 optional), [INFO] [stderr] 210 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / probor_struct!( [INFO] [stderr] 207 | | struct OneThree { [INFO] [stderr] 208 | | one: Option => (#0 optional), [INFO] [stderr] 209 | | three: Option => (#2 optional), [INFO] [stderr] 210 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / probor_struct!( [INFO] [stderr] 207 | | struct OneThree { [INFO] [stderr] 208 | | one: Option => (#0 optional), [INFO] [stderr] 209 | | three: Option => (#2 optional), [INFO] [stderr] 210 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / probor_struct!( [INFO] [stderr] 213 | | struct OneTwo { [INFO] [stderr] 214 | | one: Option => (#0 optional), [INFO] [stderr] 215 | | two: Option => (#1 optional), [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / probor_struct!( [INFO] [stderr] 213 | | struct OneTwo { [INFO] [stderr] 214 | | one: Option => (#0 optional), [INFO] [stderr] 215 | | two: Option => (#1 optional), [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / probor_struct!( [INFO] [stderr] 213 | | struct OneTwo { [INFO] [stderr] 214 | | one: Option => (#0 optional), [INFO] [stderr] 215 | | two: Option => (#1 optional), [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / probor_struct!( [INFO] [stderr] 213 | | struct OneTwo { [INFO] [stderr] 214 | | one: Option => (#0 optional), [INFO] [stderr] 215 | | two: Option => (#1 optional), [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / probor_struct!( [INFO] [stderr] 213 | | struct OneTwo { [INFO] [stderr] 214 | | one: Option => (#0 optional), [INFO] [stderr] 215 | | two: Option => (#1 optional), [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / probor_struct!( [INFO] [stderr] 219 | | struct Named { [INFO] [stderr] 220 | | one: u8 => (), [INFO] [stderr] 221 | | two: u8 => (), [INFO] [stderr] 222 | | three: u8 => (), [INFO] [stderr] 223 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / probor_struct!( [INFO] [stderr] 219 | | struct Named { [INFO] [stderr] 220 | | one: u8 => (), [INFO] [stderr] 221 | | two: u8 => (), [INFO] [stderr] 222 | | three: u8 => (), [INFO] [stderr] 223 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | try!($decoder.skip().map_err(|e| [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 118 | | $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | |_____________________________________________________________^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / probor_struct!( [INFO] [stderr] 219 | | struct Named { [INFO] [stderr] 220 | | one: u8 => (), [INFO] [stderr] 221 | | two: u8 => (), [INFO] [stderr] 222 | | three: u8 => (), [INFO] [stderr] 223 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/decode_struct.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (idx+1); // silence warning but expect to be optimized [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / probor_struct!( [INFO] [stderr] 219 | | struct Named { [INFO] [stderr] 220 | | one: u8 => (), [INFO] [stderr] 221 | | two: u8 => (), [INFO] [stderr] 222 | | three: u8 => (), [INFO] [stderr] 223 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode_struct.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | .map_err(|e| $crate::DecodeError::SkippingError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$crate::DecodeError::SkippingError` [INFO] [stderr] | [INFO] [stderr] ::: src/macros.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / probor_struct!( [INFO] [stderr] 219 | | struct Named { [INFO] [stderr] 220 | | one: u8 => (), [INFO] [stderr] 221 | | two: u8 => (), [INFO] [stderr] 222 | | three: u8 => (), [INFO] [stderr] 223 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.65s [INFO] running `"docker" "inspect" "9ab17891c6bd4a8d7ae6a2a6a8b90f6506103d133bfb24da85ee89adf295f09b"` [INFO] running `"docker" "rm" "-f" "9ab17891c6bd4a8d7ae6a2a6a8b90f6506103d133bfb24da85ee89adf295f09b"` [INFO] [stdout] 9ab17891c6bd4a8d7ae6a2a6a8b90f6506103d133bfb24da85ee89adf295f09b