[INFO] crate probes 0.2.1 is already in cache [INFO] extracting crate probes 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/probes/0.2.1 [INFO] extracting crate probes 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/probes/0.2.1 [INFO] validating manifest of probes-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of probes-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing probes-0.2.1 [INFO] finished frobbing probes-0.2.1 [INFO] frobbed toml for probes-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/probes/0.2.1/Cargo.toml [INFO] started frobbing probes-0.2.1 [INFO] finished frobbing probes-0.2.1 [INFO] frobbed toml for probes-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/probes/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting probes-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/probes/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbc844bd8499d6c2618074da48b8a6da1e3154606bb6c11827108d79cded99bc [INFO] running `"docker" "start" "-a" "fbc844bd8499d6c2618074da48b8a6da1e3154606bb6c11827108d79cded99bc"` [INFO] [stderr] Checking probes v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | guest: guest, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | guestnice: guestnice [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `guestnice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_stats.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | stats: stats [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_usage.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | filesystem: filesystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filesystem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_usage.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | filesystem: filesystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filesystem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | interfaces: interfaces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | precise_time_ns: precise_time_ns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precise_time_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | interfaces: interfaces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | guest: guest, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | guestnice: guestnice [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `guestnice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_stats.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | stats: stats [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_usage.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | filesystem: filesystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filesystem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_usage.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | filesystem: filesystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filesystem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | interfaces: interfaces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | precise_time_ns: precise_time_ns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precise_time_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | interfaces: interfaces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_stats.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(403272, sda.sectors_read); [INFO] [stderr] | ^^^^^^ help: consider: `403_272` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_stats.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(206475264, sda.bytes_read()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `206_475_264` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_stats.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(43239424, sda.bytes_written()); [INFO] [stderr] | ^^^^^^^^ help: consider: `43_239_424` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_stats.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(21230592, sda1.bytes_read()); [INFO] [stderr] | ^^^^^^^^ help: consider: `21_230_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | one_k_blocks: 81234688, [INFO] [stderr] | ^^^^^^^^ help: consider: `81_234_688` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:136:36 [INFO] [stderr] | [INFO] [stderr] 136 | one_k_blocks_used: 2344444, [INFO] [stderr] | ^^^^^^^ help: consider: `2_344_444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:137:36 [INFO] [stderr] | [INFO] [stderr] 137 | one_k_blocks_free: 74763732, [INFO] [stderr] | ^^^^^^^^ help: consider: `74_763_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:143:31 [INFO] [stderr] | [INFO] [stderr] 143 | one_k_blocks: 183176, [INFO] [stderr] | ^^^^^^ help: consider: `183_176` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | one_k_blocks_free: 182996, [INFO] [stderr] | ^^^^^^ help: consider: `182_996` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | one_k_blocks: 233191, [INFO] [stderr] | ^^^^^^ help: consider: `233_191` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_usage.rs:153:36 [INFO] [stderr] | [INFO] [stderr] 153 | one_k_blocks_free: 203533, [INFO] [stderr] | ^^^^^^ help: consider: `203_533` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | total: 376072, [INFO] [stderr] | ^^^^^^ help: consider: `376_072` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:243:19 [INFO] [stderr] | [INFO] [stderr] 243 | free: 324248, [INFO] [stderr] | ^^^^^^ help: consider: `324_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | cached: 176324, [INFO] [stderr] | ^^^^^^ help: consider: `176_324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | swap_total: 1101816, [INFO] [stderr] | ^^^^^^^ help: consider: `1_101_816` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:248:24 [INFO] [stderr] | [INFO] [stderr] 248 | swap_free: 1100644, [INFO] [stderr] | ^^^^^^^ help: consider: `1_100_644` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:289:20 [INFO] [stderr] | [INFO] [stderr] 289 | total: 512000, // 500mb [INFO] [stderr] | ^^^^^^ help: consider: `512_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:290:19 [INFO] [stderr] | [INFO] [stderr] 290 | free: 503400, // total - used [INFO] [stderr] | ^^^^^^ help: consider: `503_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | total: 512000, // 500mb [INFO] [stderr] | ^^^^^^ help: consider: `512_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:346:19 [INFO] [stderr] | [INFO] [stderr] 346 | free: 503400, // total - used [INFO] [stderr] | ^^^^^^ help: consider: `503_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/network.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(254972, eth0.received); [INFO] [stderr] | ^^^^^^ help: consider: `254_972` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/network.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | assert_eq!(354972, eth1.received); [INFO] [stderr] | ^^^^^^ help: consider: `354_972` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | usertime = usertime - guest; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `usertime -= guest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | nicetime = nicetime - guestnice; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nicetime -= guestnice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/disk_usage.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | let lines = output.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/network.rs:122:51 [INFO] [stderr] | [INFO] [stderr] 122 | let groups: Vec<&str> = header_line.split("|").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/network.rs:129:81 [INFO] [stderr] | [INFO] [stderr] 129 | let receive_pos = try!(receive_group.iter().position(|&e| e == "bytes").ok_or(ProbeError::UnexpectedContent("bytes field not found for receive".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ProbeError::UnexpectedContent("bytes field not found for receive".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/network.rs:130:83 [INFO] [stderr] | [INFO] [stderr] 130 | let transmit_pos = try!(transmit_group.iter().position(|&e| e == "bytes").ok_or(ProbeError::UnexpectedContent("bytes field not found for transmit".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ProbeError::UnexpectedContent("bytes field not found for transmit".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | usertime = usertime - guest; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `usertime -= guest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | nicetime = nicetime - guestnice; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nicetime -= guestnice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:501:21 [INFO] [stderr] | [INFO] [stderr] 501 | let total = (in_percentages.user + in_percentages.nice + systemalltime + idlealltime + in_percentages.steal + virtualtime) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(in_percentages.user + in_percentages.nice + systemalltime + idlealltime + in_percentages.steal + virtualtime)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/disk_stats.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / fn test_read_and_parse_proc_diskstats() { [INFO] [stderr] 148 | | let measurement = read_and_parse_proc_diskstats(&Path::new("fixtures/linux/disk_stats/proc_diskstats")).unwrap(); [INFO] [stderr] 149 | | [INFO] [stderr] 150 | | assert!(measurement.precise_time_ns > 0); [INFO] [stderr] ... | [INFO] [stderr] 182 | | assert_eq!(1140, sda1.weighted_time_spent_doing_ios_ms); [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/disk_stats.rs:154:19 [INFO] [stderr] | [INFO] [stderr] 154 | let sda = measurement.stats.get("sda").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&measurement.stats["sda"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/disk_stats.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | let sda1 = measurement.stats.get("sda1").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&measurement.stats["sda1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/disk_stats.rs:217:20 [INFO] [stderr] | [INFO] [stderr] 217 | let sda1 = per_minute.stats.get("sda1").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.stats["sda1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/disk_stats.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | let sda1 = per_minute.stats.get("sda1").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.stats["sda1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/disk_usage.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | let lines = output.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/network.rs:122:51 [INFO] [stderr] | [INFO] [stderr] 122 | let groups: Vec<&str> = header_line.split("|").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/network.rs:129:81 [INFO] [stderr] | [INFO] [stderr] 129 | let receive_pos = try!(receive_group.iter().position(|&e| e == "bytes").ok_or(ProbeError::UnexpectedContent("bytes field not found for receive".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ProbeError::UnexpectedContent("bytes field not found for receive".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/network.rs:130:83 [INFO] [stderr] | [INFO] [stderr] 130 | let transmit_pos = try!(transmit_group.iter().position(|&e| e == "bytes").ok_or(ProbeError::UnexpectedContent("bytes field not found for transmit".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ProbeError::UnexpectedContent("bytes field not found for transmit".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | let lo = interfaces.get("lo").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&interfaces["lo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | let eth0 = interfaces.get("eth0").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&interfaces["eth0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | let eth1 = interfaces.get("eth1").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&interfaces["eth1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:256:20 [INFO] [stderr] | [INFO] [stderr] 256 | let eth0 = per_minute.interfaces.get("eth0").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.interfaces["eth0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | let eth1 = per_minute.interfaces.get("eth0").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.interfaces["eth0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:286:20 [INFO] [stderr] | [INFO] [stderr] 286 | let eth0 = per_minute.interfaces.get("eth0").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.interfaces["eth0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | let eth1 = per_minute.interfaces.get("eth0").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&per_minute.interfaces["eth0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.91s [INFO] running `"docker" "inspect" "fbc844bd8499d6c2618074da48b8a6da1e3154606bb6c11827108d79cded99bc"` [INFO] running `"docker" "rm" "-f" "fbc844bd8499d6c2618074da48b8a6da1e3154606bb6c11827108d79cded99bc"` [INFO] [stdout] fbc844bd8499d6c2618074da48b8a6da1e3154606bb6c11827108d79cded99bc