[INFO] crate primal-check 0.2.3 is already in cache [INFO] extracting crate primal-check 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/primal-check/0.2.3 [INFO] extracting crate primal-check 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/primal-check/0.2.3 [INFO] validating manifest of primal-check-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of primal-check-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing primal-check-0.2.3 [INFO] finished frobbing primal-check-0.2.3 [INFO] frobbed toml for primal-check-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/primal-check/0.2.3/Cargo.toml [INFO] started frobbing primal-check-0.2.3 [INFO] finished frobbing primal-check-0.2.3 [INFO] frobbed toml for primal-check-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/primal-check/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting primal-check-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/primal-check/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 685a1763866a73fc3307466c3204f7192e924a9ecc20c2c0c8f9f0068cd33a41 [INFO] running `"docker" "start" "-a" "685a1763866a73fc3307466c3204f7192e924a9ecc20c2c0c8f9f0068cd33a41"` [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking primal-sieve v0.2.9 [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking primal-check v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/is_prime.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let t = (x as i64 >> 63) as u64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | const HINT: &'static [u64] = &[2]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------------------------ help: consider removing `'static`: `&[(u64, &'static [u64])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/is_prime.rs:115:44 [INFO] [stderr] | [INFO] [stderr] 115 | (1_112_004_669_632, &[2, 13, 23, 1662803]), [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perfect_power.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | let factor = x_.powf(1.0/expn as f64).round() as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(expn)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/is_prime.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let t = (x as i64 >> 63) as u64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/perfect_power.rs:121:43 [INFO] [stderr] | [INFO] [stderr] 121 | if is_prime { Some((expected))} else { None }) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/perfect_power.rs:121:43 [INFO] [stderr] | [INFO] [stderr] 121 | if is_prime { Some((expected))} else { None }) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | const HINT: &'static [u64] = &[2]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------------------------ help: consider removing `'static`: `&[(u64, &'static [u64])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/is_prime.rs:115:44 [INFO] [stderr] | [INFO] [stderr] 115 | (1_112_004_669_632, &[2, 13, 23, 1662803]), [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/is_prime.rs:193:69 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(super::mod_mul(1 << 31, 1 << 31, (1 << 32) - 7), 3221225479); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_221_225_479` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perfect_power.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | let factor = x_.powf(1.0/expn as f64).round() as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(expn)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/perfect_power.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / loop { [INFO] [stderr] 129 | | let p = match primes.next() { [INFO] [stderr] 130 | | Some(p) => p as u64, [INFO] [stderr] 131 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(p) = primes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.16s [INFO] running `"docker" "inspect" "685a1763866a73fc3307466c3204f7192e924a9ecc20c2c0c8f9f0068cd33a41"` [INFO] running `"docker" "rm" "-f" "685a1763866a73fc3307466c3204f7192e924a9ecc20c2c0c8f9f0068cd33a41"` [INFO] [stdout] 685a1763866a73fc3307466c3204f7192e924a9ecc20c2c0c8f9f0068cd33a41