[INFO] crate prev-iter 0.1.2 is already in cache [INFO] extracting crate prev-iter 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/prev-iter/0.1.2 [INFO] extracting crate prev-iter 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prev-iter/0.1.2 [INFO] validating manifest of prev-iter-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prev-iter-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prev-iter-0.1.2 [INFO] finished frobbing prev-iter-0.1.2 [INFO] frobbed toml for prev-iter-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/prev-iter/0.1.2/Cargo.toml [INFO] started frobbing prev-iter-0.1.2 [INFO] finished frobbing prev-iter-0.1.2 [INFO] frobbed toml for prev-iter-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prev-iter/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prev-iter-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prev-iter/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75cc76d5544a9f21fef42bee9b0f16c72e562a7f34fd60be6922e6713c9f7147 [INFO] running `"docker" "start" "-a" "75cc76d5544a9f21fef42bee9b0f16c72e562a7f34fd60be6922e6713c9f7147"` [INFO] [stderr] Checking prev-iter v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | if let Some(_) = self.iterator.peek() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 184 | | self.prev = std::mem::replace(&mut self.current, self.iterator.next()); [INFO] [stderr] 185 | | return self.current.clone(); [INFO] [stderr] 186 | | } else if !self.finished { [INFO] [stderr] 187 | | self.prev = std::mem::replace(&mut self.current, self.iterator.next()); [INFO] [stderr] 188 | | self.finished = true; [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________- help: try this: `if self.iterator.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | if let Some(_) = self.iterator.peek() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 184 | | self.prev = std::mem::replace(&mut self.current, self.iterator.next()); [INFO] [stderr] 185 | | return self.current.clone(); [INFO] [stderr] 186 | | } else if !self.finished { [INFO] [stderr] 187 | | self.prev = std::mem::replace(&mut self.current, self.iterator.next()); [INFO] [stderr] 188 | | self.finished = true; [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________- help: try this: `if self.iterator.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "75cc76d5544a9f21fef42bee9b0f16c72e562a7f34fd60be6922e6713c9f7147"` [INFO] running `"docker" "rm" "-f" "75cc76d5544a9f21fef42bee9b0f16c72e562a7f34fd60be6922e6713c9f7147"` [INFO] [stdout] 75cc76d5544a9f21fef42bee9b0f16c72e562a7f34fd60be6922e6713c9f7147