[INFO] crate pretty-trait 0.1.2 is already in cache [INFO] extracting crate pretty-trait 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/pretty-trait/0.1.2 [INFO] extracting crate pretty-trait 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretty-trait/0.1.2 [INFO] validating manifest of pretty-trait-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pretty-trait-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pretty-trait-0.1.2 [INFO] finished frobbing pretty-trait-0.1.2 [INFO] frobbed toml for pretty-trait-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/pretty-trait/0.1.2/Cargo.toml [INFO] started frobbing pretty-trait-0.1.2 [INFO] finished frobbing pretty-trait-0.1.2 [INFO] frobbed toml for pretty-trait-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretty-trait/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pretty-trait-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pretty-trait/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2374e0e52a1f9bdc5247a25052c80f29595c73c484db30d7c2fb852df8dea5b6 [INFO] running `"docker" "start" "-a" "2374e0e52a1f9bdc5247a25052c80f29595c73c484db30d7c2fb852df8dea5b6"` [INFO] [stderr] Checking pretty-trait v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(context.writer, "")` [INFO] [stderr] --> src/lib.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | writeln!(context.writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(context.writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(context.writer, "")` [INFO] [stderr] --> src/lib.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | writeln!(context.writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(context.writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:655:5 [INFO] [stderr] | [INFO] [stderr] 655 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(context.writer, "")` [INFO] [stderr] --> src/lib.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | writeln!(context.writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(context.writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(context.writer, "")` [INFO] [stderr] --> src/lib.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | writeln!(context.writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(context.writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:655:5 [INFO] [stderr] | [INFO] [stderr] 655 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / fn reborrow<'b>(&'b mut self) -> Context<'b> { [INFO] [stderr] 148 | | Context { [INFO] [stderr] 149 | | max_line: self.max_line, [INFO] [stderr] 150 | | tab_size: self.tab_size, [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:772:9 [INFO] [stderr] | [INFO] [stderr] 772 | / match self { [INFO] [stderr] 773 | | &Some(ref inner) => inner.size(), [INFO] [stderr] 774 | | &None => Size::Size(0), [INFO] [stderr] 775 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *self { [INFO] [stderr] 773 | Some(ref inner) => inner.size(), [INFO] [stderr] 774 | None => Size::Size(0), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | / match self { [INFO] [stderr] 780 | | &Some(ref inner) => inner.pretty_write(context), [INFO] [stderr] 781 | | &None => Ok(()), [INFO] [stderr] 782 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 779 | match *self { [INFO] [stderr] 780 | Some(ref inner) => inner.pretty_write(context), [INFO] [stderr] 781 | None => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / fn reborrow<'b>(&'b mut self) -> Context<'b> { [INFO] [stderr] 148 | | Context { [INFO] [stderr] 149 | | max_line: self.max_line, [INFO] [stderr] 150 | | tab_size: self.tab_size, [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:772:9 [INFO] [stderr] | [INFO] [stderr] 772 | / match self { [INFO] [stderr] 773 | | &Some(ref inner) => inner.size(), [INFO] [stderr] 774 | | &None => Size::Size(0), [INFO] [stderr] 775 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *self { [INFO] [stderr] 773 | Some(ref inner) => inner.size(), [INFO] [stderr] 774 | None => Size::Size(0), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | / match self { [INFO] [stderr] 780 | | &Some(ref inner) => inner.pretty_write(context), [INFO] [stderr] 781 | | &None => Ok(()), [INFO] [stderr] 782 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 779 | match *self { [INFO] [stderr] 780 | Some(ref inner) => inner.pretty_write(context), [INFO] [stderr] 781 | None => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "2374e0e52a1f9bdc5247a25052c80f29595c73c484db30d7c2fb852df8dea5b6"` [INFO] running `"docker" "rm" "-f" "2374e0e52a1f9bdc5247a25052c80f29595c73c484db30d7c2fb852df8dea5b6"` [INFO] [stdout] 2374e0e52a1f9bdc5247a25052c80f29595c73c484db30d7c2fb852df8dea5b6