[INFO] crate pretty-good 0.2.2 is already in cache
[INFO] extracting crate pretty-good 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/pretty-good/0.2.2
[INFO] extracting crate pretty-good 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretty-good/0.2.2
[INFO] validating manifest of pretty-good-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pretty-good-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pretty-good-0.2.2
[INFO] finished frobbing pretty-good-0.2.2
[INFO] frobbed toml for pretty-good-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/pretty-good/0.2.2/Cargo.toml
[INFO] started frobbing pretty-good-0.2.2
[INFO] finished frobbing pretty-good-0.2.2
[INFO] frobbed toml for pretty-good-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretty-good/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pretty-good-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pretty-good/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b516f9352a6294d7d2980e2f95309bf09fcd62f7a0d60d1a9a8a303bbbd406d9
[INFO] running `"docker" "start" "-a" "b516f9352a6294d7d2980e2f95309bf09fcd62f7a0d60d1a9a8a303bbbd406d9"`
[INFO] [stderr]     Checking nom v3.2.1
[INFO] [stderr]     Checking ripemd160 v0.7.0
[INFO] [stderr]     Checking yasna v0.1.3
[INFO] [stderr]     Checking pretty-good v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/literal.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/signature.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/signature.rs:157:1
[INFO] [stderr]     |
[INFO] [stderr] 157 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             sig_type: sig_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `sig_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:213:13
[INFO] [stderr]     |
[INFO] [stderr] 213 |             pubkey_algo: pubkey_algo,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pubkey_algo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             hash_algo: hash_algo,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_algo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/literal.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/signature.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/signature.rs:157:1
[INFO] [stderr]     |
[INFO] [stderr] 157 | #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             sig_type: sig_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `sig_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:213:13
[INFO] [stderr]     |
[INFO] [stderr] 213 |             pubkey_algo: pubkey_algo,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pubkey_algo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/signature.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             hash_algo: hash_algo,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_algo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/compression.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | / named!(
[INFO] [stderr] 29 | |     compressed_data<Result<CompressedDataPacket, Error>>,
[INFO] [stderr] 30 | |     switch!(be_u8,
[INFO] [stderr] 31 | |         0 => call!(uncompressed_data) |
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |     )
[INFO] [stderr] 36 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/compression.rs:90:39
[INFO] [stderr]     |
[INFO] [stderr] 90  |           let mut deflater: Box<Read> = match self {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 91  | |             &CompressedDataPacket::Uncompressed(ref data) => {
[INFO] [stderr] 92  | |                 out.push(0);
[INFO] [stderr] 93  | |                 Box::new(&data[..])
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |             }
[INFO] [stderr] 107 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 90  |         let mut deflater: Box<Read> = match *self {
[INFO] [stderr] 91  |             CompressedDataPacket::Uncompressed(ref data) => {
[INFO] [stderr] 92  |                 out.push(0);
[INFO] [stderr] 93  |                 Box::new(&data[..])
[INFO] [stderr] 94  |             }
[INFO] [stderr] 95  |             CompressedDataPacket::Zip(ref data) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/key.rs:73:55
[INFO] [stderr]    |
[INFO] [stderr] 73 |             expiration_time: Some(Duration::from_secs(expires_days as u64 * 24 * 60 * 60)),
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(expires_days)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/key.rs:82:1
[INFO] [stderr]     |
[INFO] [stderr] 82  | / named!(
[INFO] [stderr] 83  | |     v4_pubkey<Key>,
[INFO] [stderr] 84  | |     do_parse!(
[INFO] [stderr] 85  | |         tag!(&[4_u8]) >>
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |     )
[INFO] [stderr] 117 | | );
[INFO] [stderr]     | |__^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/compression.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | / named!(
[INFO] [stderr] 29 | |     compressed_data<Result<CompressedDataPacket, Error>>,
[INFO] [stderr] 30 | |     switch!(be_u8,
[INFO] [stderr] 31 | |         0 => call!(uncompressed_data) |
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |     )
[INFO] [stderr] 36 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/key.rs:346:9
[INFO] [stderr]     |
[INFO] [stderr] 346 | /         match self {
[INFO] [stderr] 347 | |             &KeyMaterial::Rsa(ref public, _) => {
[INFO] [stderr] 348 | |                 out.write_u16::<BigEndian>(public.n.bits() as u16)?;
[INFO] [stderr] 349 | |                 out.extend(&public.n.to_bytes_be());
[INFO] [stderr] ...   |
[INFO] [stderr] 370 | |             }
[INFO] [stderr] 371 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 346 |         match *self {
[INFO] [stderr] 347 |             KeyMaterial::Rsa(ref public, _) => {
[INFO] [stderr] 348 |                 out.write_u16::<BigEndian>(public.n.bits() as u16)?;
[INFO] [stderr] 349 |                 out.extend(&public.n.to_bytes_be());
[INFO] [stderr] 350 |                 out.write_u16::<BigEndian>(public.e.bits() as u16)?;
[INFO] [stderr] 351 |                 out.extend(&public.e.to_bytes_be());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/compression.rs:90:39
[INFO] [stderr]     |
[INFO] [stderr] 90  |           let mut deflater: Box<Read> = match self {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 91  | |             &CompressedDataPacket::Uncompressed(ref data) => {
[INFO] [stderr] 92  | |                 out.push(0);
[INFO] [stderr] 93  | |                 Box::new(&data[..])
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |             }
[INFO] [stderr] 107 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 90  |         let mut deflater: Box<Read> = match *self {
[INFO] [stderr] 91  |             CompressedDataPacket::Uncompressed(ref data) => {
[INFO] [stderr] 92  |                 out.push(0);
[INFO] [stderr] 93  |                 Box::new(&data[..])
[INFO] [stderr] 94  |             }
[INFO] [stderr] 95  |             CompressedDataPacket::Zip(ref data) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/key.rs:379:9
[INFO] [stderr]     |
[INFO] [stderr] 379 | /         match self {
[INFO] [stderr] 380 | |             &KeyMaterial::Rsa(_, Some(ref private)) => {
[INFO] [stderr] 381 | |                 out.write_u16::<BigEndian>(private.d.bits() as u16)?;
[INFO] [stderr] 382 | |                 out.extend(&private.d.to_bytes_be());
[INFO] [stderr] ...   |
[INFO] [stderr] 400 | |             | &KeyMaterial::Elgamal(_, None) => {}
[INFO] [stderr] 401 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 379 |         match *self {
[INFO] [stderr] 380 |             KeyMaterial::Rsa(_, Some(ref private)) => {
[INFO] [stderr] 381 |                 out.write_u16::<BigEndian>(private.d.bits() as u16)?;
[INFO] [stderr] 382 |                 out.extend(&private.d.to_bytes_be());
[INFO] [stderr] 383 |                 out.write_u16::<BigEndian>(private.p.bits() as u16)?;
[INFO] [stderr] 384 |                 out.extend(&private.p.to_bytes_be());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/key.rs:73:55
[INFO] [stderr]    |
[INFO] [stderr] 73 |             expiration_time: Some(Duration::from_secs(expires_days as u64 * 24 * 60 * 60)),
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(expires_days)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/key.rs:82:1
[INFO] [stderr]     |
[INFO] [stderr] 82  | / named!(
[INFO] [stderr] 83  | |     v4_pubkey<Key>,
[INFO] [stderr] 84  | |     do_parse!(
[INFO] [stderr] 85  | |         tag!(&[4_u8]) >>
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |     )
[INFO] [stderr] 117 | | );
[INFO] [stderr]     | |__^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/packet.rs:29:43
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn new_tag_format(inp: (&[u8], usize)) -> IResult<(&[u8], usize), (u8, &[u8])> {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]   --> src/packet.rs:29:1
[INFO] [stderr]    |
[INFO] [stderr] 29 | / fn new_tag_format(inp: (&[u8], usize)) -> IResult<(&[u8], usize), (u8, &[u8])> {
[INFO] [stderr] 30 | |     let (remaining, tag) = match take_bits!(inp, u8, 6) {
[INFO] [stderr] 31 | |         IResult::Done(remaining, tag) => (remaining, tag),
[INFO] [stderr] 32 | |         IResult::Error(e) => return IResult::Error(e),
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |     )))
[INFO] [stderr] 80 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]    = help: you could split it up into multiple smaller functions
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:36:42
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let (remaining, first_octet) = match bytes!(remaining, be_u8) {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:43:15
[INFO] [stderr]    |
[INFO] [stderr] 43 |         match bytes!(remaining, take!(first_octet)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let (remaining, second_octet) = match bytes!(remaining, be_u8) {
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let length = ((first_octet as u16 - 192) << 8) + second_octet as u16 + 192;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(first_octet)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:55:58
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let length = ((first_octet as u16 - 192) << 8) + second_octet as u16 + 192;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(second_octet)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 |         match bytes!(remaining, take!(length)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:63:41
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let (remaining, length) = match bytes!(remaining, be_u32) {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:69:15
[INFO] [stderr]    |
[INFO] [stderr] 69 |         match bytes!(remaining, take!(length)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/packet.rs:82:1
[INFO] [stderr]    |
[INFO] [stderr] 82 | / named!(
[INFO] [stderr] 83 | |     pgp_packet_header<(u8, &[u8])>,
[INFO] [stderr] 84 | |     bits!(preceded!(
[INFO] [stderr] 85 | |         tag_bits!(u8, 1, 0b1),
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |     ))
[INFO] [stderr] 91 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/packet.rs:112:5
[INFO] [stderr]     |
[INFO] [stderr] 112 |     PublicSubkey(Key),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 112 |     PublicSubkey(Box<Key>),
[INFO] [stderr]     |                  ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/packet.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |                 reason: format!("packet has reserved tag"),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"packet has reserved tag".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/packet.rs:223:25
[INFO] [stderr]     |
[INFO] [stderr] 223 |                 reason: format!("unknown tag"),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown tag".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/key.rs:346:9
[INFO] [stderr]     |
[INFO] [stderr] 346 | /         match self {
[INFO] [stderr] 347 | |             &KeyMaterial::Rsa(ref public, _) => {
[INFO] [stderr] 348 | |                 out.write_u16::<BigEndian>(public.n.bits() as u16)?;
[INFO] [stderr] 349 | |                 out.extend(&public.n.to_bytes_be());
[INFO] [stderr] ...   |
[INFO] [stderr] 370 | |             }
[INFO] [stderr] 371 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 346 |         match *self {
[INFO] [stderr] 347 |             KeyMaterial::Rsa(ref public, _) => {
[INFO] [stderr] 348 |                 out.write_u16::<BigEndian>(public.n.bits() as u16)?;
[INFO] [stderr] 349 |                 out.extend(&public.n.to_bytes_be());
[INFO] [stderr] 350 |                 out.write_u16::<BigEndian>(public.e.bits() as u16)?;
[INFO] [stderr] 351 |                 out.extend(&public.e.to_bytes_be());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/key.rs:379:9
[INFO] [stderr]     |
[INFO] [stderr] 379 | /         match self {
[INFO] [stderr] 380 | |             &KeyMaterial::Rsa(_, Some(ref private)) => {
[INFO] [stderr] 381 | |                 out.write_u16::<BigEndian>(private.d.bits() as u16)?;
[INFO] [stderr] 382 | |                 out.extend(&private.d.to_bytes_be());
[INFO] [stderr] ...   |
[INFO] [stderr] 400 | |             | &KeyMaterial::Elgamal(_, None) => {}
[INFO] [stderr] 401 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 379 |         match *self {
[INFO] [stderr] 380 |             KeyMaterial::Rsa(_, Some(ref private)) => {
[INFO] [stderr] 381 |                 out.write_u16::<BigEndian>(private.d.bits() as u16)?;
[INFO] [stderr] 382 |                 out.extend(&private.d.to_bytes_be());
[INFO] [stderr] 383 |                 out.write_u16::<BigEndian>(private.p.bits() as u16)?;
[INFO] [stderr] 384 |                 out.extend(&private.p.to_bytes_be());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/s2k.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let c = c as u32;
[INFO] [stderr]    |             ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/signature.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |     inp.into_iter()
[INFO] [stderr]    |         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | / named!(old_tag_format<(&[u8], usize), (u8, &[u8])>,
[INFO] [stderr] 16 | |     do_parse!(
[INFO] [stderr] 17 | |         tag: take_bits!(u8, 4) >>
[INFO] [stderr] 18 | |         length: switch!(take_bits!(u8, 2),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |     )
[INFO] [stderr] 27 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/packet.rs:29:43
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn new_tag_format(inp: (&[u8], usize)) -> IResult<(&[u8], usize), (u8, &[u8])> {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]   --> src/packet.rs:29:1
[INFO] [stderr]    |
[INFO] [stderr] 29 | / fn new_tag_format(inp: (&[u8], usize)) -> IResult<(&[u8], usize), (u8, &[u8])> {
[INFO] [stderr] 30 | |     let (remaining, tag) = match take_bits!(inp, u8, 6) {
[INFO] [stderr] 31 | |         IResult::Done(remaining, tag) => (remaining, tag),
[INFO] [stderr] 32 | |         IResult::Error(e) => return IResult::Error(e),
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |     )))
[INFO] [stderr] 80 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]    = help: you could split it up into multiple smaller functions
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:36:42
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let (remaining, first_octet) = match bytes!(remaining, be_u8) {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:43:15
[INFO] [stderr]    |
[INFO] [stderr] 43 |         match bytes!(remaining, take!(first_octet)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let (remaining, second_octet) = match bytes!(remaining, be_u8) {
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let length = ((first_octet as u16 - 192) << 8) + second_octet as u16 + 192;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(first_octet)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:55:58
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let length = ((first_octet as u16 - 192) << 8) + second_octet as u16 + 192;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(second_octet)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 |         match bytes!(remaining, take!(length)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:234:31
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 let header = (header as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^ help: try: `f64::from(header)`
[INFO] [stderr]     |
[INFO] [stderr]    |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:249:33
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 let header_r = (header_r as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(header_r)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:259:33
[INFO] [stderr]     |
[INFO] [stderr] 259 |                 let header_s = (header_s as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(header_s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:63:41
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let (remaining, length) = match bytes!(remaining, be_u32) {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/packet.rs:69:15
[INFO] [stderr]    |
[INFO] [stderr] 69 |         match bytes!(remaining, take!(length)) {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/packet.rs:82:1
[INFO] [stderr]    |
[INFO] [stderr] 82 | / named!(
[INFO] [stderr] 83 | |     pgp_packet_header<(u8, &[u8])>,
[INFO] [stderr] 84 | |     bits!(preceded!(
[INFO] [stderr] 85 | |         tag_bits!(u8, 1, 0b1),
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |     ))
[INFO] [stderr] 91 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/packet.rs:112:5
[INFO] [stderr]     |
[INFO] [stderr] 112 |     PublicSubkey(Key),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 112 |     PublicSubkey(Box<Key>),
[INFO] [stderr]     |                  ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/packet.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |                 reason: format!("packet has reserved tag"),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"packet has reserved tag".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/packet.rs:223:25
[INFO] [stderr]     |
[INFO] [stderr] 223 |                 reason: format!("unknown tag"),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown tag".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/s2k.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let c = c as u32;
[INFO] [stderr]    |             ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:104:21
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn asn1_oid(&self) -> Result<ObjectIdentifier, Error> {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:127:33
[INFO] [stderr]     |
[INFO] [stderr] 127 |     pub fn hash<T: AsRef<[u8]>>(&self, contents: T) -> Result<Vec<u8>, Error> {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:163:24
[INFO] [stderr]     |
[INFO] [stderr] 163 |     pub fn block_bytes(&self) -> usize {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/signature.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |     inp.into_iter()
[INFO] [stderr]    |         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:234:31
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 let header = (header as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^ help: try: `f64::from(header)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:249:33
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 let header_r = (header_r as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(header_r)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/signature.rs:259:33
[INFO] [stderr]     |
[INFO] [stderr] 259 |                 let header_s = (header_s as f64 / 8.0).ceil() as usize;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(header_s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:104:21
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn asn1_oid(&self) -> Result<ObjectIdentifier, Error> {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:127:33
[INFO] [stderr]     |
[INFO] [stderr] 127 |     pub fn hash<T: AsRef<[u8]>>(&self, contents: T) -> Result<Vec<u8>, Error> {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/types.rs:163:24
[INFO] [stderr]     |
[INFO] [stderr] 163 |     pub fn block_bytes(&self) -> usize {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.96s
[INFO] running `"docker" "inspect" "b516f9352a6294d7d2980e2f95309bf09fcd62f7a0d60d1a9a8a303bbbd406d9"`
[INFO] running `"docker" "rm" "-f" "b516f9352a6294d7d2980e2f95309bf09fcd62f7a0d60d1a9a8a303bbbd406d9"`
[INFO] [stdout] b516f9352a6294d7d2980e2f95309bf09fcd62f7a0d60d1a9a8a303bbbd406d9