[INFO] crate prefixopt_derive 0.4.0 is already in cache
[INFO] extracting crate prefixopt_derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/prefixopt_derive/0.4.0
[INFO] extracting crate prefixopt_derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prefixopt_derive/0.4.0
[INFO] validating manifest of prefixopt_derive-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of prefixopt_derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing prefixopt_derive-0.4.0
[INFO] finished frobbing prefixopt_derive-0.4.0
[INFO] frobbed toml for prefixopt_derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/prefixopt_derive/0.4.0/Cargo.toml
[INFO] started frobbing prefixopt_derive-0.4.0
[INFO] finished frobbing prefixopt_derive-0.4.0
[INFO] frobbed toml for prefixopt_derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prefixopt_derive/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting prefixopt_derive-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prefixopt_derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ebf977da8c1278cc69bbe7921abf2803a7f1cdcf4c4ff6d3faee220a6a5598e6
[INFO] running `"docker" "start" "-a" "ebf977da8c1278cc69bbe7921abf2803a7f1cdcf4c4ff6d3faee220a6a5598e6"`
[INFO] [stderr]    Compiling scopeguard v0.2.0
[INFO] [stderr]    Compiling map_in_place v0.1.0
[INFO] [stderr]    Compiling prefixopt v0.4.0
[INFO] [stderr]    Compiling prefixopt_derive v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/enum_data.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             add_arguments: add_arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/enum_data.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             override_arguments: override_arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `override_arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/enum_data.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             add_arguments: add_arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/enum_data.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             override_arguments: override_arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `override_arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     tokens
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |       let tokens = match ast.body {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 25 | |         syn::Body::Struct(_struct) => variant_data::derive(&generics, ident, &_struct),
[INFO] [stderr] 26 | |         syn::Body::Enum(_enum) => {
[INFO] [stderr] 27 | |             let generics = generics::with_default_constraints(generics);
[INFO] [stderr] 28 | |             enum_data::derive(&generics, ident, &_enum)
[INFO] [stderr] 29 | |         },
[INFO] [stderr] 30 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     tokens
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |       let tokens = match ast.body {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 25 | |         syn::Body::Struct(_struct) => variant_data::derive(&generics, ident, &_struct),
[INFO] [stderr] 26 | |         syn::Body::Enum(_enum) => {
[INFO] [stderr] 27 | |             let generics = generics::with_default_constraints(generics);
[INFO] [stderr] 28 | |             enum_data::derive(&generics, ident, &_enum)
[INFO] [stderr] 29 | |         },
[INFO] [stderr] 30 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/enum_data.rs:3:55
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn derive(gen: &Generics, ident: &Ident, variant: &Vec<Variant>) -> quote::Tokens {
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^ help: change this to: `&[Variant]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/variant_data.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |         VariantData::Tuple(ref fields) if fields.len() > 0 => {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/variant_data.rs:114:49
[INFO] [stderr]     |
[INFO] [stderr] 114 |         .map(|(i, f)| f.ident.as_ref().cloned().unwrap_or(Ident::new(i)));
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/variant_data.rs:115:29
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let unit_empty_tag = if fields.len() == 0 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/variant_data.rs:135:49
[INFO] [stderr]     |
[INFO] [stderr] 135 |         .map(|(i, f)| f.ident.as_ref().cloned().unwrap_or(Ident::new(i)))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let ref ident = ast.ident;
[INFO] [stderr]    |     ----^^^^^^^^^------------- help: try: `let ident = &ast.ident;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/enum_data.rs:3:55
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn derive(gen: &Generics, ident: &Ident, variant: &Vec<Variant>) -> quote::Tokens {
[INFO] [stderr]   |                                                       ^^^^^^^^^^^^^ help: change this to: `&[Variant]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/variant_data.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |         VariantData::Tuple(ref fields) if fields.len() > 0 => {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/variant_data.rs:114:49
[INFO] [stderr]     |
[INFO] [stderr] 114 |         .map(|(i, f)| f.ident.as_ref().cloned().unwrap_or(Ident::new(i)));
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/variant_data.rs:115:29
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let unit_empty_tag = if fields.len() == 0 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/variant_data.rs:135:49
[INFO] [stderr]     |
[INFO] [stderr] 135 |         .map(|(i, f)| f.ident.as_ref().cloned().unwrap_or(Ident::new(i)))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let ref ident = ast.ident;
[INFO] [stderr]    |     ----^^^^^^^^^------------- help: try: `let ident = &ast.ident;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]   --> bin/example.rs:10:15
[INFO] [stderr]    |
[INFO] [stderr] 10 |     A(Box<T>, Option<Option<u8>>),
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]   --> bin/example.rs:10:15
[INFO] [stderr]    |
[INFO] [stderr] 10 |     A(Box<T>, Option<Option<u8>>),
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.64s
[INFO] running `"docker" "inspect" "ebf977da8c1278cc69bbe7921abf2803a7f1cdcf4c4ff6d3faee220a6a5598e6"`
[INFO] running `"docker" "rm" "-f" "ebf977da8c1278cc69bbe7921abf2803a7f1cdcf4c4ff6d3faee220a6a5598e6"`
[INFO] [stdout] ebf977da8c1278cc69bbe7921abf2803a7f1cdcf4c4ff6d3faee220a6a5598e6