[INFO] crate prefetchkit 1.0.2 is already in cache [INFO] extracting crate prefetchkit 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/prefetchkit/1.0.2 [INFO] extracting crate prefetchkit 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prefetchkit/1.0.2 [INFO] validating manifest of prefetchkit-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prefetchkit-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prefetchkit-1.0.2 [INFO] finished frobbing prefetchkit-1.0.2 [INFO] frobbed toml for prefetchkit-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/prefetchkit/1.0.2/Cargo.toml [INFO] started frobbing prefetchkit-1.0.2 [INFO] finished frobbing prefetchkit-1.0.2 [INFO] frobbed toml for prefetchkit-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prefetchkit/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prefetchkit-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/prefetchkit/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bedb2eb2f1b4bf665460caa71cc96df0d90b4c2c975fbe43fb10e493a7200fb6 [INFO] running `"docker" "start" "-a" "bedb2eb2f1b4bf665460caa71cc96df0d90b4c2c975fbe43fb10e493a7200fb6"` [INFO] [stderr] Checking libprefetch v0.1.1 [INFO] [stderr] Checking prefetchkit v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/formatter.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/formatter.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/formatter.rs:181:11 [INFO] [stderr] | [INFO] [stderr] 181 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/formatter.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/formatter.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/formatter.rs:181:11 [INFO] [stderr] | [INFO] [stderr] 181 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formatter.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formatter.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter.rs:146:14 [INFO] [stderr] | [INFO] [stderr] 146 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 147 | | if !self.volumes { [INFO] [stderr] 148 | | print!(" │ └─"); [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | print!("│ │ └─"); [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | } else if !self.volumes { [INFO] [stderr] 147 | print!(" │ └─"); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | print!("│ │ └─"); [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter.rs:179:14 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 180 | | if !self.volumes { [INFO] [stderr] 181 | | print!("\n"); [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | print!("\n│"); [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | } else if !self.volumes { [INFO] [stderr] 180 | print!("\n"); [INFO] [stderr] 181 | } else { [INFO] [stderr] 182 | print!("\n│"); [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formatter.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formatter.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter.rs:146:14 [INFO] [stderr] | [INFO] [stderr] 146 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 147 | | if !self.volumes { [INFO] [stderr] 148 | | print!(" │ └─"); [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | print!("│ │ └─"); [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | } else if !self.volumes { [INFO] [stderr] 147 | print!(" │ └─"); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | print!("│ │ └─"); [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter.rs:179:14 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 180 | | if !self.volumes { [INFO] [stderr] 181 | | print!("\n"); [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | print!("\n│"); [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | } else if !self.volumes { [INFO] [stderr] 180 | print!("\n"); [INFO] [stderr] 181 | } else { [INFO] [stderr] 182 | print!("\n│"); [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match self.color { [INFO] [stderr] 46 | | false => format!("{:<26} {:^21} {:>18}", name, date, counter), [INFO] [stderr] 47 | | true => format!("{:<36} {:^19} {:>28}", name, date, counter) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.color { format!("{:<36} {:^19} {:>28}", name, date, counter) } else { format!("{:<26} {:^21} {:>18}", name, date, counter) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.color { [INFO] [stderr] 53 | | false => std::borrow::Cow::Borrowed(name), [INFO] [stderr] 54 | | true => std::borrow::Cow::Owned( [INFO] [stderr] 55 | | ansi_term::Colour::Green.paint(name).to_string()) [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 52 | if self.color { std::borrow::Cow::Owned( [INFO] [stderr] 53 | ansi_term::Colour::Green.paint(name).to_string()) } else { std::borrow::Cow::Borrowed(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match self.color { [INFO] [stderr] 61 | | false => std::borrow::Cow::Borrowed(counter), [INFO] [stderr] 62 | | true => std::borrow::Cow::Owned( [INFO] [stderr] 63 | | ansi_term::Colour::Green.bold().paint(counter).to_string()) [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if self.color { std::borrow::Cow::Owned( [INFO] [stderr] 61 | ansi_term::Colour::Green.bold().paint(counter).to_string()) } else { std::borrow::Cow::Borrowed(counter) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `metrics`. [INFO] [stderr] --> src/formatter.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0 .. metrics.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for in metrics.iter().take(metrics.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `volumes`. [INFO] [stderr] --> src/formatter.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0 .. volumes.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in volumes.iter().take(volumes.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/formatter.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / let result: std::string::String; [INFO] [stderr] 119 | | if date == 0 { [INFO] [stderr] 120 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 121 | | } else { [INFO] [stderr] 122 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 123 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 118 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 119 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match self.color { [INFO] [stderr] 127 | | false => result, [INFO] [stderr] 128 | | true => ansi_term::Colour::Yellow.paint(result).to_string() [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.color { ansi_term::Colour::Yellow.paint(result).to_string() } else { result }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `directories`. [INFO] [stderr] --> src/formatter.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | for i in 0 .. directories.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 206 | for in directories.iter().take(directories.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match self.color { [INFO] [stderr] 46 | | false => format!("{:<26} {:^21} {:>18}", name, date, counter), [INFO] [stderr] 47 | | true => format!("{:<36} {:^19} {:>28}", name, date, counter) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.color { format!("{:<36} {:^19} {:>28}", name, date, counter) } else { format!("{:<26} {:^21} {:>18}", name, date, counter) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.color { [INFO] [stderr] 53 | | false => std::borrow::Cow::Borrowed(name), [INFO] [stderr] 54 | | true => std::borrow::Cow::Owned( [INFO] [stderr] 55 | | ansi_term::Colour::Green.paint(name).to_string()) [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 52 | if self.color { std::borrow::Cow::Owned( [INFO] [stderr] 53 | ansi_term::Colour::Green.paint(name).to_string()) } else { std::borrow::Cow::Borrowed(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match self.color { [INFO] [stderr] 61 | | false => std::borrow::Cow::Borrowed(counter), [INFO] [stderr] 62 | | true => std::borrow::Cow::Owned( [INFO] [stderr] 63 | | ansi_term::Colour::Green.bold().paint(counter).to_string()) [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if self.color { std::borrow::Cow::Owned( [INFO] [stderr] 61 | ansi_term::Colour::Green.bold().paint(counter).to_string()) } else { std::borrow::Cow::Borrowed(counter) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | / match kit::file(&matches, &path) { [INFO] [stderr] 81 | | Err(e) => eprintln!("{}", e), [INFO] [stderr] 82 | | _ => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_______^ help: try this: `if let Err(e) = kit::file(&matches, &path) { eprintln!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | / match kit::dir(&matches, &path) { [INFO] [stderr] 86 | | Err(e) => eprintln!("{}", e), [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | } [INFO] [stderr] | |_______^ help: try this: `if let Err(e) = kit::dir(&matches, &path) { eprintln!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `metrics`. [INFO] [stderr] --> src/formatter.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0 .. metrics.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for in metrics.iter().take(metrics.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `volumes`. [INFO] [stderr] --> src/formatter.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0 .. volumes.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in volumes.iter().take(volumes.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/formatter.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / let result: std::string::String; [INFO] [stderr] 119 | | if date == 0 { [INFO] [stderr] 120 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 121 | | } else { [INFO] [stderr] 122 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 123 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 118 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 119 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match self.color { [INFO] [stderr] 127 | | false => result, [INFO] [stderr] 128 | | true => ansi_term::Colour::Yellow.paint(result).to_string() [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if self.color { ansi_term::Colour::Yellow.paint(result).to_string() } else { result }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `directories`. [INFO] [stderr] --> src/formatter.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | for i in 0 .. directories.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 206 | for in directories.iter().take(directories.len() - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | / match kit::file(&matches, &path) { [INFO] [stderr] 81 | | Err(e) => eprintln!("{}", e), [INFO] [stderr] 82 | | _ => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_______^ help: try this: `if let Err(e) = kit::file(&matches, &path) { eprintln!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | / match kit::dir(&matches, &path) { [INFO] [stderr] 86 | | Err(e) => eprintln!("{}", e), [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | } [INFO] [stderr] | |_______^ help: try this: `if let Err(e) = kit::dir(&matches, &path) { eprintln!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `"docker" "inspect" "bedb2eb2f1b4bf665460caa71cc96df0d90b4c2c975fbe43fb10e493a7200fb6"` [INFO] running `"docker" "rm" "-f" "bedb2eb2f1b4bf665460caa71cc96df0d90b4c2c975fbe43fb10e493a7200fb6"` [INFO] [stdout] bedb2eb2f1b4bf665460caa71cc96df0d90b4c2c975fbe43fb10e493a7200fb6