[INFO] crate pqgrams 0.9.2 is already in cache [INFO] extracting crate pqgrams 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/pqgrams/0.9.2 [INFO] extracting crate pqgrams 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pqgrams/0.9.2 [INFO] validating manifest of pqgrams-0.9.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pqgrams-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pqgrams-0.9.2 [INFO] finished frobbing pqgrams-0.9.2 [INFO] frobbed toml for pqgrams-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/pqgrams/0.9.2/Cargo.toml [INFO] started frobbing pqgrams-0.9.2 [INFO] finished frobbing pqgrams-0.9.2 [INFO] frobbed toml for pqgrams-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pqgrams/0.9.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pqgrams-0.9.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pqgrams/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b93281ad1ca1f1fe886ba66fa7aec02cc2d948a0d20e8f07bf1b3c96b871b98f [INFO] running `"docker" "start" "-a" "b93281ad1ca1f1fe886ba66fa7aec02cc2d948a0d20e8f07bf1b3c96b871b98f"` [INFO] [stderr] Checking pqgrams v0.9.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bdeque.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | BDeque{maxlen: maxlen, state: vd} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `maxlen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/default_tree.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | Tree{label: label, children: Box::new(vec![])} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bdeque.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | BDeque{maxlen: maxlen, state: vd} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `maxlen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/default_tree.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | Tree{label: label, children: Box::new(vec![])} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bdeque.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return i [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pqgrams.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return 1. - 2. * (intersection / union) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1. - 2. * (intersection / union)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_tree.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Node::Label(self.label.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node::Label(self.label.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bdeque.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return i [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pqgrams.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return 1. - 2. * (intersection / union) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1. - 2. * (intersection / union)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_tree.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Node::Label(self.label.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node::Label(self.label.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pqgrams.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | bits.push(match a { [INFO] [stderr] | _______________________^ [INFO] [stderr] 43 | | &Node::Label(ref v) => v.clone(), [INFO] [stderr] 44 | | &Node::Filler => filler_as.clone(), [INFO] [stderr] 45 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | bits.push(match *a { [INFO] [stderr] 43 | Node::Label(ref v) => v.clone(), [INFO] [stderr] 44 | Node::Filler => filler_as.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn flatten_profile(profile: &Vec>, filler_as: L) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/pqgrams.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | profile.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:104:48 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:104:72 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pqgrams.rs:104:137 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pqgrams.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let ref ig = left[i]; [INFO] [stderr] | ----^^^^^^----------- help: try: `let ig = &left[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pqgrams.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let ref jg = right[j]; [INFO] [stderr] | ----^^^^^^------------ help: try: `let jg = &right[j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/pqgrams.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | .expect(format!("Ordering not possible for l, r: {:?}, {:?}", l, r).as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Ordering not possible for l, r: {:?}, {:?}", l))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:157:53 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:157:77 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pqgrams.rs:157:142 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:167:45 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn pqgram_distance(left: &Vec>, right: &Vec>, alt_filler_value: Option) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:167:69 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn pqgram_distance(left: &Vec>, right: &Vec>, alt_filler_value: Option) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/default_tree.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | pub children: Box>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pqgrams.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | bits.push(match a { [INFO] [stderr] | _______________________^ [INFO] [stderr] 43 | | &Node::Label(ref v) => v.clone(), [INFO] [stderr] 44 | | &Node::Filler => filler_as.clone(), [INFO] [stderr] 45 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | bits.push(match *a { [INFO] [stderr] 43 | Node::Label(ref v) => v.clone(), [INFO] [stderr] 44 | Node::Filler => filler_as.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn flatten_profile(profile: &Vec>, filler_as: L) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/pqgrams.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | profile.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:104:48 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:104:72 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pqgrams.rs:104:137 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn pqgram_profile_intersection(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pqgrams.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let ref ig = left[i]; [INFO] [stderr] | ----^^^^^^----------- help: try: `let ig = &left[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pqgrams.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let ref jg = right[j]; [INFO] [stderr] | ----^^^^^^------------ help: try: `let jg = &right[j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/pqgrams.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | .expect(format!("Ordering not possible for l, r: {:?}, {:?}", l, r).as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Ordering not possible for l, r: {:?}, {:?}", l))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:157:53 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:157:77 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pqgrams.rs:157:142 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn pqgram_distance_with_fn(left: &Vec>, right: &Vec>, alt_filler_value: Option, distance_function: Box, &PQGram, L)->(f64, cmp::Ordering)>) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:167:45 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn pqgram_distance(left: &Vec>, right: &Vec>, alt_filler_value: Option) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pqgrams.rs:167:69 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn pqgram_distance(left: &Vec>, right: &Vec>, alt_filler_value: Option) -> f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[PQGram]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/default_tree.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | pub children: Box>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(f64_round_2dp(dist12), 0.); // Same [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(f64_round_2dp(dist12), 0.); // Same [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(f64_round_2dp(dist13), 0.31); // Differ by 0.31 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(f64_round_2dp(dist13), 0.31); // Differ by 0.31 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(f64_round_2dp(dist12), 0.); // Same [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(f64_round_2dp(dist12), 0.); // Same [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(f64_round_2dp(dist13), 0.31); // Differ by 0.31 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(f64_round_2dp(dist13), 0.31); // Differ by 0.31 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pqgrams`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b93281ad1ca1f1fe886ba66fa7aec02cc2d948a0d20e8f07bf1b3c96b871b98f"` [INFO] running `"docker" "rm" "-f" "b93281ad1ca1f1fe886ba66fa7aec02cc2d948a0d20e8f07bf1b3c96b871b98f"` [INFO] [stdout] b93281ad1ca1f1fe886ba66fa7aec02cc2d948a0d20e8f07bf1b3c96b871b98f